Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: PCPp/EQzeM89S0Sw4wHPvwhWOF6tgCnMnZ2M63eImU/3Gu636+Lhr5iXV7aevOiztO+UxQi3sU
 XHq/BkadbA3zRJUBJH5TCZu83x1GE4iVwlGgORNplM9efYlUQhuQfIPDrHI0n8yjpXQQSRIpJC
 J6x7jUPG8fww2iG7l9wlKos9GRT0YfTUMbx1RWA5CWViU1teQBDxM3QA/5vaBTag8A7pff19Qj
 bbRW3DRiLve7oO3dFTBluN3oA5aFWYjojECCeIKMtvnYztyAhdpF92TYGgnaON4GzWK4ZyqzB+
 tJskO26hYIBws7y8aA2a0gAV
IronPort-SDR: t6y8j06PgcI6YD6r8xtYtuRtOQ+1zgCyTnL4J/zBGx8OhHVSxMKW92Jmd8Ul1wc27XpdnRPrDK
 8RV/ju075ZdBQJTAQgbD/4FiFktgQn68T0dWGd5jkaqyVMiYt+2ZhHG2gTB9YQh8L6zXY1z1SR
 CCOXjzgCIT5rk9uTHn0IYb9IcLKNR8Gs/HQYautdRYcdNoK+6Pve6s/yejSyfm1BnbIupJn0jY
 9ZNgt5JKgdN/bbpfCwS7KXsAphVdn/idAGkP0w/jeNR4++R4flWpG4evgAlrpZJ/RpKN0DiCdm
 KlI=
WDCIronportException: Internal
Message-ID: <1d5064f6-0498-c78c-d98f-df7ca74e0a8d@opensource.wdc.com>
Date:   Thu, 21 Oct 2021 19:38:30 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH] ata: sata_mv: Fix the return value of the probe function
Content-Language: en-US
To:     Sergey Shtylyov <s.shtylyov@omp.ru>, Zheyu Ma <zheyuma97@gmail.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1634795836-1803-1-git-send-email-zheyuma97@gmail.com>
 <e1f96f77-cf44-7783-bf88-0814bbabbfbc@omp.ru>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital
In-Reply-To: <e1f96f77-cf44-7783-bf88-0814bbabbfbc@omp.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/10/21 17:37, Sergey Shtylyov wrote:
> On 21.10.2021 8:57, Zheyu Ma wrote:
> 
>> mv_init_host() propagates the value returned by mv_chip_id() which in turn
>> gets propagated by mv_pci_init_one() and hits local_pci_probe().
>>
>> During the process of driver probing, the probe function should return < 0
>> for failure, otherwise, the kernel will treat value > 0 as success.
>>
>> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
>> ---
>>   drivers/ata/sata_mv.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
>> index 9d86203e1e7a..7461fe078dd1 100644
>> --- a/drivers/ata/sata_mv.c
>> +++ b/drivers/ata/sata_mv.c
>> @@ -3897,7 +3897,7 @@ static int mv_chip_id(struct ata_host *host, unsigned int board_idx)
>>   
>>   	default:
>>   		dev_err(host->dev, "BUG: invalid board index %u\n", board_idx);
>> -		return 1;
>> +		return -ENODEV;
> 
>     Doesn't -EINVAL fit better here?

If the error message is correct and this can only happen if there is a bug
somewhere, I do not think the error code really matters much. The dev_err()
should probably be changed to dev_alert() or even dev_crit() for this case.

> 
> [...]
> 
> MBR, Sergey
> 


-- 
Damien Le Moal
Western Digital Research