Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp491215pxb; Thu, 21 Oct 2021 03:47:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVBFrpB3Pic5aVwMDehb4G6gnTyHPQnmNS1xu1Mn4KhoJCCItino/aIn7QZMSrKxy8mdsP X-Received: by 2002:a63:6e8f:: with SMTP id j137mr3726236pgc.381.1634813272090; Thu, 21 Oct 2021 03:47:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634813272; cv=none; d=google.com; s=arc-20160816; b=RV0JdVsQOKfOjLQxITeD6VDBflzxkiqDvNKO71qzslYvb35ybCZeXrPoPROEjN+26Y C5dtUOUszbwlp5i/YiTd5tsOlyvjj9NQ4EUUauXIKEQiyUX5elbg2HmwuissWg0i5FZ3 oX6EYI+Y3iMtk8Qi53124UFwYUA94h/QKcJ/uRe8OXxS0E8WBNecT8pVRprnv9WAlr0w wx8iLB8ViYUI4SYM2WgNwP9yAchUCfkDq0iz4bp1lKhyClH1UWZTgomvz7uYaHoblGro LjjF8znvV0QEcLLqMs3yf+UjE/mi/YZ6FtdbIXoI+SMg5IAjemGQiIHhF9DjZhJsz/b7 bPYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=voEkZx//tffn4HZbn22kJ7Vu0dRLcQMKyUGtOImvaQc=; b=hUmPScfprvYRftqvr8HqMFUDSAiIIuEA7y/1tQ820cQW/HRXGi4bTPCfaNFZnJ2VK5 kb0fjs6ja7TyOLL/2Fo7Ixy2L7bTEuuit1Wu3INOpmC9/zPCkFeH0Dvzs+2VYwRJXAiQ LdbRtE+dZXetGtWtknkejyknR6vT/Yw2QtEQ0vq2DR4Hybx4cPWJDSHwOT/pWKYAuD7a t6uHGkof3JSyShgut9b+KiblZ0bs/F2sf5tYqruovIhKYrtUHQ8TROivXebi7c5rwJQi yTcWf/kb2H3uAwKGpCVAPS4OXRnyCCVrU04JmphM+uw2OEMz52rZA2BYBcpnjfPC7NPE KRYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sYRpMVtz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a24si6290514pls.254.2021.10.21.03.47.39; Thu, 21 Oct 2021 03:47:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sYRpMVtz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231379AbhJUKsF (ORCPT + 99 others); Thu, 21 Oct 2021 06:48:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:57856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230316AbhJUKru (ORCPT ); Thu, 21 Oct 2021 06:47:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E8DE861212; Thu, 21 Oct 2021 10:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634813134; bh=eLjGS50emBath6Dva8luhePYLJ4Az8GwBrWJmSsy4uk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sYRpMVtzxNPkcsOF60SFW1uOdAQ1EHGjL/Hh9spBJtxXkOQltTAynSugOPk7YVgOB uTKHVvtxH5vBZbv/G9cxew4EeXQ7aEX8qw/zRiL1p2IUpc4HehWShHz+j7CtLubBg7 YuiBp4o7K16S4CIDs/VY2ZoDi7P8uRBdXVtKIRMiUDx55UD9lNChFdA5tdkiy/xQNN tJZBlZ6+GizPKffv5ERxfUEYHjPrrkiezSXc4yBdgKnFDxAeyCZa5UCd4Zn2sFOMj+ 0niGK7alY+oIeAGEJMM3Wvv/INQ6u+tVgc9BC9ZV2YRkqi8e/EZwtDMvJbIMckntlt k5N5Stc7/i7Eg== Received: by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1mdVZj-002z5N-7N; Thu, 21 Oct 2021 11:45:31 +0100 From: Mauro Carvalho Chehab To: Lorenzo Pieralisi Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Binghui Wang , Bjorn Helgaas , Rob Herring , Xiaowei Song , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v15 12/13] PCI: kirin: De-init the dwc driver Date: Thu, 21 Oct 2021 11:45:19 +0100 Message-Id: <838621e1c84ebaac153ccd9c36ea5e1254c61ead.1634812676.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The logic under .remove ops is missing a call to dw_pcie_host_deinit(). Add it, in order to allow the DWC core to be properly cleaned up. Acked-by: Xiaowei Song Signed-off-by: Mauro Carvalho Chehab --- To mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v15 00/13] at: https://lore.kernel.org/all/cover.1634812676.git.mchehab+huawei@kernel.org/ drivers/pci/controller/dwc/pcie-kirin.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c index 4c3fa02b7108..fea4d717fff3 100644 --- a/drivers/pci/controller/dwc/pcie-kirin.c +++ b/drivers/pci/controller/dwc/pcie-kirin.c @@ -750,6 +750,8 @@ static int __exit kirin_pcie_remove(struct platform_device *pdev) { struct kirin_pcie *kirin_pcie = platform_get_drvdata(pdev); + dw_pcie_host_deinit(&kirin_pcie->pci->pp); + kirin_pcie_power_off(kirin_pcie); return 0; -- 2.31.1