Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Kiwoong Kim" <kwmad.kim@samsung.com>
To:     "'Adrian Hunter'" <adrian.hunter@intel.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
        <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <beanhuo@micron.com>, <cang@codeaurora.org>, <sc.suh@samsung.com>,
        <hy50.seo@samsung.com>, <sh425.lee@samsung.com>,
        <bhoon95.kim@samsung.com>, <vkumar.1997@samsung.com>
In-Reply-To: <2e35d23b-babb-a617-d93e-ce9b522dafb3@intel.com>
Subject: RE: [PATCH RESEND v2] scsi: ufs: clear doorbell for hibern8 errors
 when using ah8
Date:   Thu, 21 Oct 2021 20:04:35 +0900
Message-ID: <029e01d7c66b$6f6e7830$4e4b6890$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIPpLk+GfI6SjvCnzedxKlglX7R9QIy3PWBAkTuWMOrSctakA==
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20211019051346epcas2p132d3b9c6a1c812f3132e913525235b83@epcas2p1.samsung.com>
        <1634619427-171880-1-git-send-email-kwmad.kim@samsung.com>
        <2e35d23b-babb-a617-d93e-ce9b522dafb3@intel.com>
Precedence: bulk

> On 19/10/2021 07:57, Kiwoong Kim wrote:
> > Changes from v1:
> > * Change the time to requeue pended commands
> >
> > When an scsi command is dispatched right after host complete all the
> > pended requests and ufs driver tries to ring a doorbell, host might be
> > still during entering into hibern8.
> > If the hibern8 error occurrs during that period, the doorbell might
> > not be zero and clearing it should have done.
> > But, current ufshcd_err_handler goes directly to reset w/o clearing
> > the doorbell when the driver's link state is broken.
>=20
> So you mean HCE 1->0 does not clear the doorbell register?
>=20
> > This patch is to requeue pended commands after host reset.
>=20
> So you mean HCE 0->1 does clear the doorbell register?


I talked about this again and maybe he didn't seem to accept its descriptio=
n like that
Because he just focused on the term 'disable' in the description.
Instead, there is an vendor sfr to clear all the contexts.

Yes, the description contains like this, but I think he could think it's do=
ne when setting one.
--
When HCE is =E2=80=980=E2=80=99=20and=20software=20writes=20=E2=80=981=E2=
=80=99,=20the=20host=20=0D=0Acontroller=20hardware=20shall=20execute=20the=
=20step=202=20described=20in=207.1.1=20of=20this=20standard,=20=0D=0Ainclud=
ing=20>>>>>=20reset=20<<<<<=20of=20the=20host=20UTP=20and=20UIC=20layers.=
=0D=0A=0D=0AOf=20course,=20some=20statements,=20such=20as=208.2.2.=20UIC=20=
Error=20Handling,=20seems=20to=20show=20setting=20zero=20means=20clearing.=
=0D=0ABut=20speaking=20the=20description,=20it's=20not=20quite=20clear=20to=
=20me.=0D=0A=0D=0AAnyway,=20let=20me=20know=20how=20to=20deal=20with=20this=
.=0D=0A=0D=0AThanks.=0D=0AKiwoong=20Kim=0D=0A=0D=0A