Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
        Olivier Moysan <olivier.moysan@foss.st.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Xu Wang <vulab@iscas.ac.cn>,
        Ahmad Fatoum <a.fatoum@pengutronix.de>,
        Wan Jiabing <wanjiabing@vivo.com>, linux-iio@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net
Subject: [PATCH v2] iio: adc: stm32-adc: Fix of_node_put() issue in stm32-adc
Date:   Thu, 21 Oct 2021 08:18:23 -0400
Message-Id: <20211021121826.6339-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DB1Jy4r89lc9BJkZ5o3vqXjc/9HIBXo/ZzKYtXH0YHmZm1QqvBlqt4m+J27Z?=
 =?us-ascii?Q?2canYFQ8Tc2x/v657MuUgbGSbcoIEyRJPofamwoaC0g64xMcBcoZoXF6xnxN?=
 =?us-ascii?Q?mp1MLxD+80fCSVCeBl+qcjs+KQs8AIAvDHgz+dPLCVMFM1mnyIjGO116qVUa?=
 =?us-ascii?Q?YVGlyd0clAOACl7sARlBGSiIkiNqBQZlgOIF3UdfSXkhriWttU4aUPgUbdip?=
 =?us-ascii?Q?5LAg2CBSaZQVPd1AGjmigqOGsCsyJHRg+xm+evShhbZkhg3e6mHvocuLESQL?=
 =?us-ascii?Q?JoMXZFVhptXjsYZQmmESfHc5F7sEYmozSjFgR7Z17kGjOxsbDxVdg0nCIF5J?=
 =?us-ascii?Q?gBM7JaQgGUN7KktJKINhHpHJM6BdJXyHlVbmycOk5ZGEPASVbGAdUgbyyvOX?=
 =?us-ascii?Q?nZ6uYf846QwUAYNaYktv2g1QOehybHjgEAH0g+/oJFwQVTKCpGIWAoOqXHZW?=
 =?us-ascii?Q?fwCrwbT9whddp7V7u7/GWTfSI8hDNK7qwhSt3Gfp2jheKAhVfgHUd30PBJ/N?=
 =?us-ascii?Q?9vn77vV2Byre8N1fYIJZEAmAaRsBckt3FGZNaAlQzMOFyhT22uXd01Cadt96?=
 =?us-ascii?Q?WgZIt/b8lejSxE2mR9X0NFACqj8VPkhw9x0oX1km6bToRhAFThWi2bGWncgi?=
 =?us-ascii?Q?S0W3KO2g2ED30s9/fNXY3+1HgLzbHvsQCHrqQhr1g7Ds1gSv1Ik4pAF5kSDr?=
 =?us-ascii?Q?7z/VYJqQE6X+X3nJc/5P2mZNO3piO7ocjaBXgSNgGJYzPAwM4acVeu703Uc0?=
 =?us-ascii?Q?IOroTd9vjBug4rv416PfvA1qr+/hXWStIYgtVJeqwxE5C6tMFt/5j2Y/7ABP?=
 =?us-ascii?Q?8nDecqegwfZsRzxCrvkGd0/C0dBUoCj94lBkXVhNALmhMNkEKBJcpz6Dt0AU?=
 =?us-ascii?Q?1yw5oXaJbafds5mqZuDsBR8Kpuosrn0Ywt/+7YvMPbTOeWrQ9nG0E/r7lb7N?=
 =?us-ascii?Q?TMSe9g7KDDUQXJpwMJ43ud8X4oQOfjsM5yQmVZjTOUQ6uA5oLXK4VgiB8oZm?=
 =?us-ascii?Q?UrAgdHQuH4fM8nn3mCr1rTaMAnNMq6hv3u3vey4u88LSsXLOkWAMLknVI3uG?=
 =?us-ascii?Q?Yr+s0JkwYWD6IAZIjFTmrTlVZNQXcwT0qy/tZt0rRRtaFHYl6+YDW2uIjTmT?=
 =?us-ascii?Q?2jOxuDco/nTdVhsgNex9M4MoJWt6DjB/ftxjFP/JvAWr573EgwqADYzRqDL0?=
 =?us-ascii?Q?gMOJP2w0uZlRMtbXLM5BhxvUp4Y/gzxldNU0+rprDh3O/BP9N8sQBO2xOpMF?=
 =?us-ascii?Q?XvGMwtBeSWtwalzzY4mdueW1C85nNd43vEwFIlCyWtDqGoRutENtzKEVNN2t?=
 =?us-ascii?Q?JBJoELVAlSHyiWFTBgKqp0Pkki25wuOwZvuT3QFyN4TcWsJeN9nWyjYyvgk3?=
 =?us-ascii?Q?qkwO1arUASsE3Nfe42fLRr19JzEzGnbYu/d8PeLoqoQgNFxb+KTWoU0DAOyl?=
 =?us-ascii?Q?LepFVVxO4ts=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f69f6b86-b303-4a05-6543-08d9948cebec
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 12:18:42.6275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 11126903@vivo.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3727
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/iio/adc/stm32-adc.c:2014:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter. Repalce return by goto here.

Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Changelog:
v2:
- Fix typo and add reviewed-by.
---
 drivers/iio/adc/stm32-adc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
index 6245434f8377..7f1fb36c747c 100644
--- a/drivers/iio/adc/stm32-adc.c
+++ b/drivers/iio/adc/stm32-adc.c
@@ -2024,7 +2024,8 @@ static int stm32_adc_generic_chan_init(struct iio_dev *indio_dev,
 			if (strlen(name) >= STM32_ADC_CH_SZ) {
 				dev_err(&indio_dev->dev, "Label %s exceeds %d characters\n",
 					name, STM32_ADC_CH_SZ);
-				return -EINVAL;
+				ret = -EINVAL;
+				goto err;
 			}
 			strncpy(adc->chan_name[val], name, STM32_ADC_CH_SZ);
 			ret = stm32_adc_populate_int_ch(indio_dev, name, val);
-- 
2.20.1