Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Straube <straube.linux@gmail.com>,
        Martin Kaiser <martin@kaiser.cx>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net, Wan Jiabing <wanjiabing@vivo.com>
Subject: [PATCH] staging: r8188eu: Use memdup_user instead of kmalloc/copy_from_user
Date:   Thu, 21 Oct 2021 08:20:02 -0400
Message-Id: <20211021122015.6974-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o+6U2rpNdh2hf5k1QhVBOCDLSKGkPlv+mvFLULKAxzsk+q6jRaEsDoV/gYpW?=
 =?us-ascii?Q?shClID0T2w3SWqnvNmyvtKOtzIZneazA9YDnVgb/G2TEKfUKQ4ifO1d+4K55?=
 =?us-ascii?Q?cPDkqAjryoujiMU7Hnx0eUkJsPiLYIzuYrn6xEhdQgTidyia91CtdOW1f5VV?=
 =?us-ascii?Q?r0LT8BBpUS1i+NN4Ka85F8MlP3JMzDTA0Ju0nwBw1SrydSKx07TgYVFRXre2?=
 =?us-ascii?Q?60OX2KXqA7zZEAHbd3CL9MgrREeHpqZO7JOmkPrr5VjbwxIep3HUhZEL/cbR?=
 =?us-ascii?Q?PmK66+RmK7ykRYuvzBtCsh6/G09ZiNOr17VMX3zdOrmjDfEEIwaV+W4RP1sp?=
 =?us-ascii?Q?+pz9lqRy/L5hkdSLGyaju71U+lzKodPHVOGf86iLq9sbyaRDjT+jWTrt5O7Q?=
 =?us-ascii?Q?N6RM8IipA2iY7C7SGnnj+4Mj3ZfK9G1ewnsihUGpPoqLg3UpEPigNjlZKRvb?=
 =?us-ascii?Q?6k4I5LrticpU39gLulFG4NRlAahXXTFtDUJHSl9/kOyLVeR7A20d0z/4UPh9?=
 =?us-ascii?Q?v2BmXDVPQ2tV9ntCZ7ECZqHwL2R7tymrOafXvAVjmhUq60lIYN9R4KSvMh2N?=
 =?us-ascii?Q?abKWKMOxLpVK4CXWiuu8kcWLA5TIO9VJyK7Psmt2H9MiFBWDBFxRYk0SREbV?=
 =?us-ascii?Q?YN4EpY5+aQnxkGEilcZ9Jv/d5PhTnCGQ+6X6lI6C01Om2Sq8t1K1Yoj5CFpK?=
 =?us-ascii?Q?5MrjysHrm7hle8ZqAq28f8TxU5JWdUoKMIaXMdujxMIMk/CVY/9JhL2B7Zwk?=
 =?us-ascii?Q?G4Twfl1G1mOTg7lvBlVgvDS6t0asj/zFl6d6+0M1EnDXG4yFWgNFmKHmrdNR?=
 =?us-ascii?Q?GN7WPdcFZzLDGpZN2F2MDCcguRc8I7l6XK0XhSgAoQSMmkxBG0RIGMaa8ngZ?=
 =?us-ascii?Q?R4kqA5e6BYlC3UxVh7+MJiFViDYS4k7eVBDXPKzhbQ9OjgQ2sqU+KejVeUDL?=
 =?us-ascii?Q?3kOtptKJhHNwLYQtkP0qOiNCjGGJ1saT8sOCrIyaId0iQhKPO7dWsQvbpfYB?=
 =?us-ascii?Q?/T1JLvatJgANdxjPdPgw8AJqpoXOL+wWyQHNDbk5AbKrLCTeZQ5D0Erjr423?=
 =?us-ascii?Q?RRm9NEnSD61E7gGDSEQS0CAltvivtMMyMtJGz/OGkexJ4CBEQfvcXJ+MiOwf?=
 =?us-ascii?Q?dpjAgTOeSYdOgtDYtMeScUSozZZ85bdUkQqBw0vc/wlw++Y0tA2IMTzLaLbN?=
 =?us-ascii?Q?gSRGcod7/lO/Jq9T4YyTLUbALs9mcnP71oyDl9MldjzIWgDxfW2C3q/R5FaK?=
 =?us-ascii?Q?9ckqgMr1YiiwM2uu1OTj/L4FuoqKGT3a+EBWlMjWKCMYj4xySsl8ybSUX2iA?=
 =?us-ascii?Q?4abn0tZWvGRDeefR9brly+NhP1MM2NnTkZ+cS3Xf0xdslBYQCIVNhvUYHU1i?=
 =?us-ascii?Q?pk0h+WYez8DtZEbqoQtJl8C21wJsVvKcUXY7tohdhf/Ryh79mWkVXQDU+pOm?=
 =?us-ascii?Q?Laww/kAmf/Q=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b95954ed-099b-42e2-10ae-08d9948d31bc
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 12:20:39.7362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 11126903@vivo.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3727
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/staging/r8188eu/os_dep/ioctl_linux.c:1986:8-15: WARNING
opportunity for memdup_user.

Use memdup_user rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/staging/r8188eu/os_dep/ioctl_linux.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
index 4f0ae821d193..301a29984fad 100644
--- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
+++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
@@ -1983,14 +1983,9 @@ static int rtw_wx_read32(struct net_device *dev,
 	padapter = (struct adapter *)rtw_netdev_priv(dev);
 	p = &wrqu->data;
 	len = p->length;
-	ptmp = kmalloc(len, GFP_KERNEL);
-	if (!ptmp)
-		return -ENOMEM;
-
-	if (copy_from_user(ptmp, p->pointer, len)) {
-		kfree(ptmp);
-		return -EFAULT;
-	}
+	ptmp = memdup_user(p->pointer, len);
+	if (IS_ERR(ptmp))
+		return PTR_ERR(ptmp);
 
 	bytes = 0;
 	addr = 0;
-- 
2.20.1