Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 0/2] perf jevents: Enable build warnings
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     <peterz@infradead.org>, <mark.rutland@arm.com>,
        <alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>,
        <namhyung@kernel.org>, <mingo@redhat.com>, <irogers@google.com>,
        <linux-perf-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kjain@linux.ibm.com>, <james.clark@arm.com>
References: <1634807805-40093-1-git-send-email-john.garry@huawei.com>
 <YXFjSR6ZRQbMjiG3@kernel.org>
From:   John Garry <john.garry@huawei.com>
Message-ID: <9075dc5c-25a2-c977-a1c2-675e972115e7@huawei.com>
Date:   Thu, 21 Oct 2021 14:02:41 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <YXFjSR6ZRQbMjiG3@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 21/10/2021 13:55, Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 21, 2021 at 05:16:43PM +0800, John Garry escreveu:
>> Currently jevents builds without any complier warning flags enabled. So
>> use newly-defined HOSTCFLAGS, which comes from EXTRA_WARNINGS.
>>
>> Changes for v2:
>> - Add Werror, Wall, and Wextra (James Clark suggestion)
> 
> Thanks, applied.
> 

Hi Arnaldo,

Can you please wait until I check the review response from jirka?

Thanks

> - Arnaldo
> 
>   
>> Baseline is acme perf/core + mainline commit b94729919db2 ("perf jevents:
>> Free the sys_event_tables list after processing entries"):
>>
>> 680453e63302 perf jevents: Free the sys_event_tables list after processing entries
>> be8ecc57f180 (origin/perf/core) perf srcline: Use long-running addr2line per DSO
>> 2b775152bbe8 perf tests vmlinux-kallsyms: Ignore hidden symbols
>>
>> John Garry (2):
>>    perf jevents: Fix some would-be warnings
>>    perf jevents: Enable warnings through HOSTCFLAGS
>>
>>   tools/perf/Makefile.config      |  5 +++++
>>   tools/perf/Makefile.perf        |  2 +-
>>   tools/perf/pmu-events/Build     |  2 +-
>>   tools/perf/pmu-events/jevents.c | 10 ++++------
>>   4 files changed, 11 insertions(+), 8 deletions(-)
>>
>> -- 
>> 2.17.1
>