Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
In-Reply-To: <20211021120135.3003-1-caihuoqing@baidu.com>
Subject: Re: [PATCH 0/6] kthread: Add the helper macro kthread_run_on_cpu()
From:   "Bernard Metzler" <BMT@zurich.ibm.com>
To:     "Cai Huoqing" <caihuoqing@baidu.com>
Cc:     "Doug Ledford" <dledford@redhat.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        "Josh Triplett" <josh@joshtriplett.org>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
        "Lai Jiangshan" <jiangshanlai@gmail.com>,
        "Joel Fernandes" <joel@joelfernandes.org>,
        "Ingo Molnar" <mingo@redhat.com>,
        "Daniel Bristot de Oliveira" <bristot@kernel.org>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <rcu@vger.kernel.org>
Date:   Thu, 21 Oct 2021 13:48:15 +0000
Message-ID: <OFACD03FD5.99AACE16-ON00258775.004BD474-00258775.004BD47C@ibm.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
MIME-Version: 1.0
Sensitivity: 
Importance: Normal
References: <20211021120135.3003-1-caihuoqing@baidu.com>
Precedence: bulk

-----"Cai Huoqing" <caihuoqing@baidu.com> wrote: -----

>To: <caihuoqing@baidu.com>
>From: "Cai Huoqing" <caihuoqing@baidu.com>
>Date: 10/21/2021 02:02PM
>Cc: "Bernard Metzler" <bmt@zurich.ibm.com>, "Doug Ledford"
><dledford@redhat.com>, "Jason Gunthorpe" <jgg@ziepe.ca>, "Davidlohr
>Bueso" <dave@stgolabs.net>, "Paul E. McKenney" <paulmck@kernel.org>,
>"Josh Triplett" <josh@joshtriplett.org>, "Steven Rostedt"
><rostedt@goodmis.org>, "Mathieu Desnoyers"
><mathieu.desnoyers@efficios.com>, "Lai Jiangshan"
><jiangshanlai@gmail.com>, "Joel Fernandes" <joel@joelfernandes.org>,
>"Ingo Molnar" <mingo@redhat.com>, "Daniel Bristot de Oliveira"
><bristot@kernel.org>, <linux-rdma@vger.kernel.org>,
><linux-kernel@vger.kernel.org>, <rcu@vger.kernel.org>
>Subject: [EXTERNAL] [PATCH 0/6] kthread: Add the helper macro
>kthread=5Frun=5Fon=5Fcpu()
>
>the helper macro kthread=5Frun=5Fon=5Fcpu() inculdes
>kthread=5Fcreate=5Fon=5Fcpu/wake=5Fup=5Fprocess().
>In some cases, use kthread=5Frun=5Fon=5Fcpu() directly instead of
>kthread=5Fcreate=5Fon=5Fnode/kthread=5Fbind/wake=5Fup=5Fprocess() or
>kthread=5Fcreate=5Fon=5Fcpu/wake=5Fup=5Fprocess() or
>kthreadd=5Fcreate/kthread=5Fbind/wake=5Fup=5Fprocess() to simplify the cod=
e.

I do not see kthread=5Fbind() being covered by the helper,
as claimed? rcutorture, ring-buffer, siw are using it in
the code potentially being replaced by the helper.
kthread=5Fbind() is best to be called before thread starts
running, so should be part of it.

Thanks,
Bernard.
>
>Cai Huoqing (6):
>  kthread: Add the helper macro kthread=5Frun=5Fon=5Fcpu()
>  RDMA/siw: Make use of the helper macro kthread=5Frun=5Fon=5Fcpu()
>  ring-buffer: Make use of the helper macro kthread=5Frun=5Fon=5Fcpu()
>  rcutorture: Make use of the helper macro kthread=5Frun=5Fon=5Fcpu()
>  trace/osnoise: Make use of the helper macro kthread=5Frun=5Fon=5Fcpu()
>  trace/hwlat: Make use of the helper macro kthread=5Frun=5Fon=5Fcpu()
>
> drivers/infiniband/sw/siw/siw=5Fmain.c |  7 +++----
> include/linux/kthread.h              | 22 ++++++++++++++++++++++
> kernel/rcu/rcutorture.c              |  7 ++-----
> kernel/trace/ring=5Fbuffer.c           |  7 ++-----
> kernel/trace/trace=5Fhwlat.c           |  6 +-----
> kernel/trace/trace=5Fosnoise.c         |  3 +--
> 6 files changed, 31 insertions(+), 21 deletions(-)
>
>--=20
>2.25.1
>
>