Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp688190pxb; Thu, 21 Oct 2021 07:39:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAFRwQYZ/9fyV7H1WF86wqY9YnaTbmhFwIqBhHn2xSq1kE1hxc07lfcHi//USF52EGz0/5 X-Received: by 2002:a17:903:32cf:b0:13f:d59:7a4c with SMTP id i15-20020a17090332cf00b0013f0d597a4cmr5552300plr.78.1634827175375; Thu, 21 Oct 2021 07:39:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634827175; cv=none; d=google.com; s=arc-20160816; b=FY/Ss3X94yCUXg2YtiyUXEMAPSk1tLrnqlrhYnPremV0qvRgYWtLU+Pcv4N5LrGZHu 3tueZB/Cw2iFVQq+hT0HkVkwPBthDnAfnV0UUsEn8qFLZ37Nm3Pj30INiIXJhZtniH0i ZW/76N3Q6BxImWmF1oSh9tqlURW2N1aGaYfKwFzbmitgURWldtdhnT/8hV0MKvVVp9dl t+ZDbEELFmTnwfGbjA/1ogKOytQWwj/Q6XXumVcQzsC3hYv/rSi2M7JNMdkf5OIovCzK dSG3O88p6ZPAs7xxDZj4Qv6vFptYLjXwaoxtdWfI/Eg2+QyTUWqXuwv9pJ1+qcOGYyNY 9W0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=dDWiDipIHK5HS6MeBxjwAzx3AX6EeZz5LXZckVi1/bo=; b=k7T7XgwktoHklPyc9CY84iFxmOHUTVV4w/Wsbr3ArFZfzoaQP1kL1hhwrYZtk/wbWh 5AxJGjf3Sodufw5d1ems9SgRWEbqHOJp24VzvfbQv7jRNlT82aOCuxtJOtYctxA15Dp8 ZVjKHafdJ0bCg+Kr0ooUpmFQOTHG2usnogKNN/NMYbpT20piJmVpMILF13I3ASKPEYir CV1e31pDb8YZJd4U9NpWPSLk2cZ64m9rAR6EX2sZihIgwXcEE8ZjvfULAeDYOBSE/T+N OjDEcUSJ8zrEACPQit5KmbXrRLbAVt5IcmNW60g7GGyYZCHlKwAiUf1hDOuYCWrcPXKy UOvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=GK5V02IS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id il9si8413191pjb.99.2021.10.21.07.39.21; Thu, 21 Oct 2021 07:39:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=GK5V02IS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230390AbhJUOj6 (ORCPT + 99 others); Thu, 21 Oct 2021 10:39:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230484AbhJUOj5 (ORCPT ); Thu, 21 Oct 2021 10:39:57 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D58B7C061348 for ; Thu, 21 Oct 2021 07:37:41 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id x27-20020a9d459b000000b0055303520cc4so606030ote.13 for ; Thu, 21 Oct 2021 07:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=dDWiDipIHK5HS6MeBxjwAzx3AX6EeZz5LXZckVi1/bo=; b=GK5V02ISlYBHzpOBLF1zpta1GjhfAs9dy2MvUVgN5TUFpyOInmeAsVfJP+6ah1rZVv bNIlx97VDxD5ozhsnrZZdE3Yn1O3JsA5IdMmdE6ZkcdhXHQFcVyTXcjjAMTie4cXf+0U WM8isIKKkZJEZffuGxvnr5jfzL6xGo6TW6NawGLgOIgbYFVPAFy7PeKfOXv8/SZx2kFp ljkEVIabkyc9VzhlUyVw2hH0o4ouYSc0MspRk+qCO98md3YCz7CxX0GlMRcHmHdfrtBb OBxSugbTXw0jsGomAnItJKwo1ZJplwg0mTw/1ARmCBWIfNuOQRepNV7ep24Dwe5pv7yz J3rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=dDWiDipIHK5HS6MeBxjwAzx3AX6EeZz5LXZckVi1/bo=; b=AokHzq460z0neBvsUX4Ioq2IAXoaaNQOVt+qVpiNuEKr17rnNh+BEMHG8vBKZCbcbR x8ITXu2jllBdT8negKQXYy+T9CatDKgbXqkaZYS0bnqB7e2eiEp2DHsv7v9ZFu3PxIaq yteMywzahutOXx9YdgTgKS2bJlOA6ao7k9KPPoNCuLQtsA9JSYUwwP/xRj+dnLusHRzR uQUmRDbjAo6E1/ttM31M5dgVecU23w4VwVLPqSYfY2i13wJOOS6tPUg12x9gxXv9JvnR JYAHUrq5s3V94d9DB282TG28ysEjbLc7PEcKX86FYMqdlRbtEBMQv6QYDi3a7m4YR3R0 wNJg== X-Gm-Message-State: AOAM532cUYL+Q/ioZwbFkTk/JyWGLVlxa1FBO0Vd50GXinEeE2ooBjmE jcUxwELfTCIXGw8Y7NgN+OyDhg== X-Received: by 2002:a9d:20a3:: with SMTP id x32mr4783922ota.91.1634827061206; Thu, 21 Oct 2021 07:37:41 -0700 (PDT) Received: from [127.0.1.1] ([2600:380:783a:c43c:af64:c142:4db7:63ac]) by smtp.gmail.com with ESMTPSA id bk8sm1131310oib.57.2021.10.21.07.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 07:37:40 -0700 (PDT) From: Jens Axboe To: Pavel Begunkov , linux-block@vger.kernel.org Cc: Dennis Zhou , Tejun Heo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter In-Reply-To: References: Subject: Re: [PATCH v2 0/2] optimise blk_try_enter_queue() Message-Id: <163482705916.41758.93518625125015139.b4-ty@kernel.dk> Date: Thu, 21 Oct 2021 08:37:39 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Oct 2021 14:30:50 +0100, Pavel Begunkov wrote: > Kill extra rcu_read_lock/unlock() pair in blk_try_enter_queue(). > Testing with io_uring (high batching) with nullblk: > > Before: > 3.20% io_uring [kernel.vmlinux] [k] __rcu_read_unlock > 3.05% io_uring [kernel.vmlinux] [k] __rcu_read_lock > > [...] Applied, thanks! [1/2] percpu_ref: percpu_ref_tryget_live() version holding RCU commit: 3b13c168186c115501ee7d194460ba2f8c825155 [2/2] block: kill extra rcu lock/unlock in queue enter commit: e94f68527a35271131cdf9d3fb4eb3c2513dc3d0 Best regards, -- Jens Axboe