Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <c5b405ed-c22a-1bcd-b81f-d93b34e5a9e2@oracle.com>
Date:   Thu, 21 Oct 2021 15:41:04 +0100
Subject: Re: [PATCH v2] mm: Optimise put_pages_list()
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>,
        Anthony Yznaga <anthony.yznaga@oracle.com>
Cc:     Mel Gorman <mgorman@techsingularity.net>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
References: <20211007192138.561673-1-willy@infradead.org>
 <20211007123109.6a49c7c625e414acf7546c89@linux-foundation.org>
 <YV9eueky+lBfSWA3@casper.infradead.org>
 <20211007163554.d9088a65f0e293e2bd906a56@linux-foundation.org>
 <YWBS6iJr/4RJ+hNE@casper.infradead.org>
From:   Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <YWBS6iJr/4RJ+hNE@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVpqYi82OXhNL2ZDQmUrR0JUNkFvU01EQnZXTG5XZVRyZ2tNelRYV25xWnJm?=
 =?utf-8?B?YUk5TEJ5SDZwaEk0VTgyNWRiOW1iYmtKUmZEOUF3bG9XZ1VQaGNxQ2lid0VP?=
 =?utf-8?B?c2RyVk95S2cwL2lEZUJRQnlmdE9uNWJrSkJnVGRMTktjWmk1RU5OZmhXeStx?=
 =?utf-8?B?Wi95MjdmOTNmaUtlMVpZeU8yaHY0eUFsNzRBVHVDRXg3WmVlakhtTDF5VWJ0?=
 =?utf-8?B?a2VwVXFZc29LMzZGbHlhZFZlMCtSSUNSbTJpa2F2eE9VOWxKWHVTZE9YRDBl?=
 =?utf-8?B?TVphdWx5TlE4ZTVsZHh4d09SUW1jdTd5ZmF1OW42aE1tVGpPN1lwM0ovV09N?=
 =?utf-8?B?ZlV5VnZnTi9LOXlWdjZYY0Q4K2xzalljcHRzbjg0YmlWSDJMdWZINjAzNFhS?=
 =?utf-8?B?dmFyU0pIU3QxWkozcmhIa2hvK1ltZElaQlJsb0xvdTViZ2pwbDJtNWpaV1h6?=
 =?utf-8?B?bjhVcGdrL28vZ0ZkWkhqbU9sbFA2M1ZubWFFQkw1eW9GbXZxMFR1cUI4c085?=
 =?utf-8?B?aW5GbkkybEU3RHQyejNSc0UwWXFGT3RlMnJoeHhmMTFBYkRDYnVHVko0aWpM?=
 =?utf-8?B?RnFHbUJNTk40TjRHenVVWElxejdCZ1dRNUdyaklmTjZNY0hEaktTMTJ2VTdG?=
 =?utf-8?B?MHZVT2hGemdROExKN2JUd3RiQWx6NmgxbUcyN3lYanRRZ0xuWWRnakdVM014?=
 =?utf-8?B?NzlsT2l1YWlGY3pIYnllTUVQd204bU4rKzBFYWxKUlhhL3p4b01TVFUzeHJR?=
 =?utf-8?B?b2RmQ3gyV0RJU3NCa2NsMXM4OVRiRy8xVjg5K2pOUTlFSlJMaFd2YWpiS01Q?=
 =?utf-8?B?YlJqWjErdGRBSFdKRDZZOEIzNjMvb2hRZGFNY2xRRGE4d0ZNZkUreHplcnRF?=
 =?utf-8?B?VGVnSFlKRnBvM1haMXBCT3RDdXVsd0FqSThxdCthaHZOOHA2bzZCdUhwbC9G?=
 =?utf-8?B?RnhTK2xMWWM2RmpQb1hGSVVMcVV2QnJYMXU0ZHNCU2lRZXg2a09pMlVDakVO?=
 =?utf-8?B?ZVd1QmRaMnR1WGswWnNuVHdHUkx3bzAzVUtCbU5jbDcvOWd0MmhFL1pabDB5?=
 =?utf-8?B?a1FGU2pDMjFCdld4Z1NhWThaa28rSGV3WmpmQ0NxdFJpMVBjRFJwOWp2aDB6?=
 =?utf-8?B?RmhzUW14ZjU1b0pDTG1iNU9YNHU5NSthSWhES3ErOUZNczR3Njc4aCtLMXBD?=
 =?utf-8?B?b004bURjS2krd3ZJbDBOeEYzaHdNcWFraFNkZ2hsYk45TjB0MmtHVllCVXpJ?=
 =?utf-8?B?L3RPbXdEdVB4ZXhOUEljNlpmK2NVcVZKMUZjbGtvRlU4MXFRMU5McWp2M1JQ?=
 =?utf-8?B?dmVTQnNIdmlLRFZMcGJqbXQ4azVqY1kxZDF0S09EVVFUSUxsR2pKd0U0SzYx?=
 =?utf-8?B?ekJKZXdBZXYrYy9RRDc5VUJaWVZKU3FLLzliUTFUdktVODg5QXN4Zm9XSDNP?=
 =?utf-8?B?NlFFekoxOU54OHNMeFZBZUc4OXhsaFg2cmpBSEI1THkrbDdSV3N1Z2ViNXha?=
 =?utf-8?B?ZXVrVlB4d0U3QXBOOHduWVJSYUdZK1kwQVh2N1BER3ZaOUxQVDZxNVpiUjg4?=
 =?utf-8?B?YmZjTFVGRHBkZkFyb0FOOXZhU01KNEVWcE1UUWF6amZpUHhsTDhiR05yRGJs?=
 =?utf-8?B?MGpiV09yNFBXMURSWkhKeXJXZnFkL0p3UWgwMUZpdDlnNjNhWUJsZFBWdnVY?=
 =?utf-8?B?b0lzRkRmQkpZMXdPejZkTUM2OUNyQnJkbnlzTytUK2ROZDVBdmZzT0VPQTV6?=
 =?utf-8?B?d3lpUTQ2dE1WRzlqRHhXQ0loaUhxWUtEUHhuY2Zwdkg0U1pzZGFZUFIvc2xV?=
 =?utf-8?B?bWdmMUsveXdPOWpseVlmZ2tqaThOVFEvajVDa0FXYThCWUJvUTN5MjhBcGFp?=
 =?utf-8?B?NEpEbGxCTzFqN2dJTzkvaUNLQVdsZHM1bjVpaGticVNuazV0dkdLeHova2ZB?=
 =?utf-8?Q?VhjaNP9Md38NWlwKFTDBNe/sPc/vnK10?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a2de3d2-7787-4fbb-2f89-08d994a0d3bc
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 14:41:12.0865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: joao.m.martins@oracle.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5139
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10144 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110210078
X-Proofpoint-ORIG-GUID: fD9nWs2w17t-UdQQE1n9WcSbNPQXoesK
X-Proofpoint-GUID: fD9nWs2w17t-UdQQE1n9WcSbNPQXoesK
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/8/21 15:17, Matthew Wilcox wrote:
> On Thu, Oct 07, 2021 at 04:35:54PM -0700, Andrew Morton wrote:
>> On Thu, 7 Oct 2021 21:55:21 +0100 Matthew Wilcox <willy@infradead.org> wrote:
>>> My first response is an appeal to authority -- release_pages() does
>>> this same thing.  Only it takes an array, constructs a list and passes
>>> that to put_unref_page_list().  So if that's slower (and lists _are_
>>> slower than arrays), we should have a put_unref_page_array().
>>
>> And put_unref_page_list() does two passes across the list!
>>
>> <quietly sobs>
>>
>> Here is my beautiful release_pages(), as disrtibuted in linux-2.5.33:
> 
> I think that looks much better!
> 

For what is worth, something that was suggested by Jason over the unpin_user_pages*
improvements series was to apply the same trick to how we iterate a page array to
release_pages(). Purpose would be to batch the page refcount update if you pass N
contiguous struct pages.

	Joao