Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 21 Oct 2021 15:55:51 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Naveen Krishna Chatradhi <nchatrad@amd.com>
Cc:     linux-edac@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, bp@alien8.de, mingo@redhat.com,
        mchehab@kernel.org, Muralidhara M K <muralimk@amd.com>
Subject: Re: [PATCH v4 2/4] EDAC/mce_amd: Extract node id from MCA_IPID
Message-ID: <YXGNh4gfWbZSJHkK@yaz-ubuntu>
References: <20210823185437.94417-1-nchatrad@amd.com>
 <20211014185400.10451-1-nchatrad@amd.com>
 <20211014185400.10451-3-nchatrad@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211014185400.10451-3-nchatrad@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nGRDYpw1MCvCKzHMN9+3EbqZgRbzJo3t4m1ZbD8NtSmn1yp2ZUnmt968SKCK?=
 =?us-ascii?Q?AJqput9FXOVVA7lwoqoZgn91RjUDzHlBWj0gIbnmAd58oSzGmOK8jAujYITa?=
 =?us-ascii?Q?iG7xq45NdVxBqKJSs6T0qSPsEt2cHPMm6kysl2Q8QmUIsEc+jXVbcQC2zE7y?=
 =?us-ascii?Q?9onyslsPPZgx/88WzpB/arukGKE4yAkN7qs0fO9dGLLsRjwIgxfhRSidEt6g?=
 =?us-ascii?Q?kB5N82LvonQI5hr35vQ931KfSZdVmo2OqoRkg40lqmqx/vNDC+PV9/fLbJEz?=
 =?us-ascii?Q?LKTuRQ1MDWUeVUn5aU4j4kzzjxWEzDhHzEP9Hh9GfPqo0vBNWKJWJkFN2rZI?=
 =?us-ascii?Q?ncsszox/bU7mF4pLEju2LNiXbWtq5PcWGUl7NpJLGDYXQ7zHFmtCj1X8kreL?=
 =?us-ascii?Q?X8CUkUOGgItVIoSDT1R3QbRE/yG5Pj6GDdTH5XG/W6YJ48dxpwfMbrceYbAG?=
 =?us-ascii?Q?4U5DjynhDmllpUvOqlitWNA9RD/lkBnhevPCuBYOEgdyciN0dss5aXiqifwe?=
 =?us-ascii?Q?i2RK76kwVlxGLmN5ghL3eT3SWcjLXp/+931ZP3SasJVSbJnZtON5XgX6sela?=
 =?us-ascii?Q?LPF/oApREU5Eb/a7AcoJobAVv1pE232V6+oXewGprl0Y/43FOVeHdYp7Ifx0?=
 =?us-ascii?Q?PLcj15K5ft04xn1cf+rH25qmf0n4PUzhoGqPHS/NCZwigi+IufPSZSws+Wss?=
 =?us-ascii?Q?zYBSJiobVRh8fAM4c62jRRe6qFE/rce/fkDR5QlAbXeVRdPhGqfYR/QYv4GK?=
 =?us-ascii?Q?64mtSlL96t2yUDkqVa870LjlmKbcWcCk6GiNFHs66Q0RTNictCiiTBwJlf+K?=
 =?us-ascii?Q?zRqOzd7FJ7/UKewygxzeAOnjgfWV3cpogZDNLQVfGUgkvys/vHfVKFTDRbY0?=
 =?us-ascii?Q?JBv0K03pr/ETXU6H564HQfOiRXKfvQlrasKqgfcU15qp1lXuxAyrykjX+GFV?=
 =?us-ascii?Q?D4v7ZRDP+kUAVMSDiBSoaVE3WS4+ag8eGF8JFwAVi7/IxOsh4kwEAp0qD03N?=
 =?us-ascii?Q?6bjdarDm0ioUBSgR4z8tmI2R48RYBHfgDaiApLO7HCrppIY8zYkiAVytXWey?=
 =?us-ascii?Q?nVCceYerSl0TpdcTfhrWFc6CPd7BfLFW8ENao7iGJU7qk7r2vENOPKdEhz73?=
 =?us-ascii?Q?KqEp4lxghA7WJv0CaGhQi9khvpXgGNoouk/ltg9RwDip5Me5NipKybFwigtl?=
 =?us-ascii?Q?dyv+GudXWyP+AYJblx7sr8mya3R/rFHMrZvhy4RD1tJaJRQ6r+sOrH0cAZ5s?=
 =?us-ascii?Q?hiOxEw0cjdPK6D0pKFjxc6RuLgmVey6TqGWHVldG/bVEHjgyYOZtRGyOCSkb?=
 =?us-ascii?Q?5zmdL+rK9fyKPHbSsXajuF7mzrz98RMUk0OFzhLeW6Nw6uyalYYmUtRwYZDW?=
 =?us-ascii?Q?rGFlvdZHLhDWjigTRltEPeJk2W4d9RPvl8bKHvIAOyy3lJZ/neNqBEah4xwX?=
 =?us-ascii?Q?HwADrMghGX4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6199a100-4b09-4c7a-c5f2-08d994ab4685
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 15:55:59.5684
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yghannam@amd.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1316
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 15, 2021 at 12:23:58AM +0530, Naveen Krishna Chatradhi wrote:
> On SMCA banks of the GPU nodes, the node id information is
> available in register MCA_IPID[47:44](InstanceIdHi).
> 
> Convert the hardware node ID to a value used by Linux
> where GPU nodes are sequencially after the CPU nodes.
> 
> Co-developed-by: Muralidhara M K <muralimk@amd.com>
> Signed-off-by: Muralidhara M K <muralimk@amd.com>
> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
> Link: https://lkml.kernel.org/r/20210823185437.94417-3-nchatrad@amd.com
> ---
> Changes since v3:
> 1. Use APIs from amd_nb to identify the gpu_node_start_id and cpu_node_count.
>    Which is required to map the hardware node id to node id enumerated by Linux.
> 
> Changes since v2:
> 1. Modified subject and commit message
> 2. Added Reviewed by Yazen Ghannam
> 
> Changes since v1:
> 1. Modified the commit message
> 2. rearranged the conditions before calling decode_dram_ecc()
> 
>  drivers/edac/mce_amd.c | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
> index 67dbf4c31271..af6caa76adc7 100644
> --- a/drivers/edac/mce_amd.c
> +++ b/drivers/edac/mce_amd.c
> @@ -2,6 +2,7 @@
>  #include <linux/module.h>
>  #include <linux/slab.h>
>  
> +#include <asm/amd_nb.h>
>  #include <asm/cpu.h>
>  
>  #include "mce_amd.h"
> @@ -1072,8 +1073,27 @@ static void decode_smca_error(struct mce *m)
>  	if (xec < smca_mce_descs[bank_type].num_descs)
>  		pr_cont(", %s.\n", smca_mce_descs[bank_type].descs[xec]);
>  
> -	if (bank_type == SMCA_UMC && xec == 0 && decode_dram_ecc)
> -		decode_dram_ecc(topology_die_id(m->extcpu), m);
> +	if (xec == 0 && decode_dram_ecc) {
> +		int node_id = 0;
> +
> +		if (bank_type == SMCA_UMC) {
> +			node_id = topology_die_id(m->extcpu);
> +		} else if (bank_type == SMCA_UMC_V2) {
> +			/*
> +			 * SMCA_UMC_V2 exists on GPU nodes, extract the node id
> +			 * from register MCA_IPID[47:44](InstanceIdHi).
> +			 * The InstanceIdHi field represents the instance ID of the GPU.
> +			 * Which needs to be mapped to a value used by Linux,
> +			 * where GPU nodes are simply numerically after the CPU nodes.
> +			 */
> +			node_id = ((m->ipid >> 44) & 0xF) -
> +				   amd_gpu_node_start_id() + amd_cpu_node_count();
> +		} else {
> +			return;
> +		}
> +
> +		decode_dram_ecc(node_id, m);
> +	}
>  }
>  
>  static inline void amd_decode_err_code(u16 ec)
> -- 

This looks good to me.

Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>

Thanks,
Yazen