Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d436f663-2b9b-1625-3de6-1b29130de8bd@oracle.com>
Date:   Fri, 22 Oct 2021 00:18:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [btrfs] 0f80799866: WARNING:at_fs/sysfs/file.c:#sysfs_emit
Content-Language: en-US
To:     dsterba@suse.cz, kernel test robot <oliver.sang@intel.com>,
        0day robot <lkp@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, lkp@lists.01.org,
        linux-btrfs@vger.kernel.org, dsterba@suse.com
References: <f748bd08259e2b770a5d9f2355c58c33d8566d16.1634598572.git.anand.jain@oracle.com>
 <20211021133538.GA16330@xsang-OptiPlex-9020>
 <20211021160648.GD20319@twin.jikos.cz>
From:   Anand Jain <anand.jain@oracle.com>
In-Reply-To: <20211021160648.GD20319@twin.jikos.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUR0UWRJQUJWcm9nTzgxaGFZRWtXOUpmY2tmeGZsOFlYYkIxcVB0dnBGTG9j?=
 =?utf-8?B?MGVGSzVLcHBHM2pNOXgzaThwUWVGUndzejU3V3JXSUJBMjkvK3RZY1hzWjZ1?=
 =?utf-8?B?dm9EbGZ6cXJER3Z4cUNzc3VzSTZmaXJjWDVJSDVQY3Y3M0NFdVFVMUVGUmRJ?=
 =?utf-8?B?eU51c29STTVqRWN2TGlQdzRsL2JHdUg0QzZxd1Nzbm1ha1pLNWh5QnlxampQ?=
 =?utf-8?B?dUNISm9laGgwT3Y3anBGaGQrek5hOWQvbmhNWDRnKzQwNVB1ZldIem1CWENx?=
 =?utf-8?B?VlJIaEVJVms1ajRjTVdwRDVIeWFSODREbjFtQ3ZEZUFTTVBWMXF6dWNvWjNW?=
 =?utf-8?B?cDBScnlCVVB3eXlUSlQ1WGtTL2twVThra3NmQTdYaUplRlNYSzRIdTk2eE15?=
 =?utf-8?B?dXJ6dGtVa0ZRSVgrUDUvb2g0U0VFZ0kweDVHYmFQR2w1RzYvNnBQRGpPLzdM?=
 =?utf-8?B?K2kzNXpDUjM3OVdEaFoyYlU5eEhwdVNyWnhaY1VDOGw4ZXdFV3BhUVEzQXFl?=
 =?utf-8?B?czAzZkVud3ZCVGpHdDQ5Y2hLU2RwOURRUGdtNFNQTGFXZ1ZjQTdZdnNlNGdV?=
 =?utf-8?B?bUtrYU5nc3J3dm5vZXE0end3WklIekFkeVR2cmxWck9SWm9pakwyM2h3Q0tG?=
 =?utf-8?B?c1FmZXN1amQ2Y1I3Ym1nRUtsZis3RTdYLzVOTm1yaDI3TkVSci9zelM2WGhT?=
 =?utf-8?B?bEZqWTh3M25MUUNNeDVnUkdkQWZwelR3Q3dPckZ5UDJ5alY3WndVdmV0Ulpr?=
 =?utf-8?B?dy9lRGJQdjNLVVZHSjM0ckowZ1FaSzE5am50UzREYVVTT2p5OW5mUUVwb2RQ?=
 =?utf-8?B?VnpyQW92aEdNTklTU0lRSzFraVQzdjVFTXJmemU3UHZwak5rN0VqZkpJQ0dH?=
 =?utf-8?B?YmxWVDExSWYwaXMrc28zMW55SkNNYlV5Wmxad1hMU2F5VERnV3gzZWV4MmJD?=
 =?utf-8?B?RUdzOXhZenQyL0pDWFlsN2ZQWG15L25tZExlOTBCQWJ0d2Nyc1NWeVhDblN0?=
 =?utf-8?B?YVNwZXkyV2dBc0crSnZrV3h6SW9QSnhLdmVuZWtGc091U0RJV0h0V2o4Vzh2?=
 =?utf-8?B?cjVZbkV4YlpvYndSTHJodlBTY3ptNG85bEdBT1U4L2hyWGJ1V2d1VlYzVGNR?=
 =?utf-8?B?dnVFTjAxT01HbXRFYmVyNmNXT3EwTXRzcmFNV0Z4cnA2R1BYTytIQmd6aWk2?=
 =?utf-8?B?eFRsZDNMakloZm5yS3FsMnVhZEx4TmNCK3QrYXh2dThIYWlCcGhiTkc5cm1R?=
 =?utf-8?B?eGl0eUR3akdmYUdmQU9XWmRKSW5QTEdmVTZQRUsvNGZ3Tjl2L0t5Wmh6M3Nv?=
 =?utf-8?B?QVNPbWN3K3VTY3h1S2k4RUsyY0NBd0JqWWxBTStQa0dhT2F5SC9EZkNvWkNr?=
 =?utf-8?B?eEZsdnplUUhLc2Nud0dsTE1Ic09jcXFLcmx6dlFUcVJ1Qlp1aDF3M05hMVRq?=
 =?utf-8?B?NnFxTHJPNjdiVWI1RURSU3pSQUdTRTM4WUloZXFVZU05TW1TdGcvSTZxRjAw?=
 =?utf-8?B?WHdVZ1NCZGpZV0szckwrNktqaytmYXF4eDFzUnJKbFhHcUhXQXd3amM4SDFs?=
 =?utf-8?B?a0tyUVhINHBtQzlSczdidUY4MCtRZGw1T3NkdmhSTVhsV2VVRzhIVEJlbk5a?=
 =?utf-8?B?cnhHSGdNYTJUNWpoSDcvVTl3MGkrcDlKVWtRVmdHUXhOQUZoeC9yMlUreEpC?=
 =?utf-8?B?THo2TlhpL3Z3RHorTVRmOEgxd2lHTUQvZ0dBbFRUeEFYL2w2eGNzYnJBaTFW?=
 =?utf-8?Q?bCSFybE30F5x+D+2B6AACqaZfQDycuCglU6fJZZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bcb32ab-0e88-4626-990e-08d994ae7436
X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 16:18:44.8852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: anand.jain@oracle.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4045
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10144 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0
 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001
 definitions=main-2110210082
X-Proofpoint-ORIG-GUID: neY5RAX1B-hKWc6BBEAP6DyklEVXN06u
X-Proofpoint-GUID: neY5RAX1B-hKWc6BBEAP6DyklEVXN06u
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 22/10/2021 00:06, David Sterba wrote:
> On Thu, Oct 21, 2021 at 09:35:38PM +0800, kernel test robot wrote:
>>
>>
>> Greeting,
>>
>> FYI, we noticed the following commit (built with gcc-9):
>>
>> commit: 0f807998661ecadb74638c18cbaff8785bb46f8d ("[PATCH 1/2] btrfs: sysfs convert scnprintf and snprintf to use sysfs_emit")
>> url: https://github.com/0day-ci/linux/commits/Anand-Jain/provide-fsid-in-sysfs-devinfo/20211019-082356
>> base: https://git.kernel.org/cgit/linux/kernel/git/kdave/linux.git for-next
>>
>> in testcase: boot
>>
>> on test machine: qemu-system-i386 -enable-kvm -cpu SandyBridge -smp 2 -m 4G
> 
> I wonder if it's related to the 32bit host, I don't see any crash.
> 


We are hitting this warning:

int sysfs_emit(char *buf, const char *fmt, ...)
{
         va_list args;
         int len;

         if (WARN(!buf || offset_in_page(buf),   <====
                  "invalid sysfs_emit: buf:%p\n", buf))
                 return 0;
<snip>


The input buf wasn't page-aligned because it wasn't part of the show().