Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 21 Oct 2021 16:40:51 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Naveen Krishna Chatradhi <nchatrad@amd.com>
Cc:     linux-edac@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, bp@alien8.de, mingo@redhat.com,
        mchehab@kernel.org, Muralidhara M K <muralimk@amd.com>
Subject: Re: [PATCH v4 4/4] EDAC/amd64: Enumerate memory on Aldebaran GPU
 nodes
Message-ID: <YXGYEz8MmPybnoI0@yaz-ubuntu>
References: <20210823185437.94417-1-nchatrad@amd.com>
 <20211014185400.10451-1-nchatrad@amd.com>
 <20211014185400.10451-5-nchatrad@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211014185400.10451-5-nchatrad@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bFQlEe6tPaRck8OrM2VxWzSsqPYjwOO7SGB/VRkQxdbzOPLJPn2LOwmz1lTc?=
 =?us-ascii?Q?2JH4y6kR+gcP8/1uQor177jvwOWzSjiLmWYpQIeXPHqVdhVU62yWm+iK1ntx?=
 =?us-ascii?Q?sfmOfIzX7Bw1s6OA/0w6AE7ufkL98znK7M2DM+lcVSll2zU9BBGSsZExLXcA?=
 =?us-ascii?Q?N/Z1inGVHv5MpY8jyx8XSa0LnuGyr7v8jwxmJyszaiO0lN8jeBCtdal/3lUa?=
 =?us-ascii?Q?BpCbP1Fey9s1LKDxBgV4T9zctNNQs86w++aZ1dfo1+1AOCPr82/npNJFMmGv?=
 =?us-ascii?Q?2S5ZcHpeXvvwXzUt5tDvPvYwtl1JVTmhI4j4fOiQmS1Q0WMwd18yKv1OzUl1?=
 =?us-ascii?Q?uOgjyzqMajazUZEZqT/yMWtqrdLSx1/MpXa5odT+tWTIs4N6pDqjlA6r5oIZ?=
 =?us-ascii?Q?kvp/+tZbmg7MwNbVixjbDe1JkcxD3MqWMybdx9uf5S/aGxTStKd7Rp/E2ZWW?=
 =?us-ascii?Q?vTFmSTpDyzcv2wax7/KO/lYrKbd7JANpIjg48dS/FAjKSp0vFJtBxCLKHuQ1?=
 =?us-ascii?Q?2vCuD8/SC0fANcOZpdwkRVVaKj00qjGk+8yh5DOGEtl3oUc/Ej+NOwwec+C1?=
 =?us-ascii?Q?pfkBcInWlbsMnO62hOKvEogozw1m9m8Tp5WnWkGMsCaoRlQVsOj2ZOgv5bJm?=
 =?us-ascii?Q?zcpDi56XVPlZtrtj44olkXZeohjWzL7F6hm68E/oY1oINKx2TARUq4XOl+km?=
 =?us-ascii?Q?Y3OZyMB87sh+NGz2BPVUPE0MHlVNLj71ei7ekTxf72jOQ5z7vnvC+0tZ7TSK?=
 =?us-ascii?Q?uhatW5QV7th0PGOaS9pdyPqVsZqD7wSRnIn0mGO6DmVLROPd94nTPNNqu6B3?=
 =?us-ascii?Q?G7YTnQ9JiUllssCK4oIAH1b/0iWTHgDHdCmJe1DDiiBI1xw2C9h9MluA+qQf?=
 =?us-ascii?Q?j92pXnULCjjdOFDhiLJ19r2VWezoAZmd/+9fGpUrJdo5n/PngbM62Gf0bFqL?=
 =?us-ascii?Q?29NZCzQt6aGT3HWg8g3F/pcMLGyWvNGfHVENaP4D7FfQO6+YDB58Km3P98OU?=
 =?us-ascii?Q?SoSlLT6zy+b8PZsKrmUDXVZgwwNqsrIPobPr8LNKfDncIj5dluLhCUlxR27Q?=
 =?us-ascii?Q?JTXK8W+4T1JZ7HBAzQXHOAfCuUqnVhYmIsFPjcSVKHgzWq2umeoid9IK/cdx?=
 =?us-ascii?Q?Qq7ClgfZrd8sAHY7ipOFAoGuNvJxjKKkD06WGcTKpwQl2X+o/UF2qpMsTM6+?=
 =?us-ascii?Q?vVCeSYdbaE3aei4x+1D8HNFfdQWuaOZc2nmsuV/Yi1Tn9pe7Nxuid2lMkz+B?=
 =?us-ascii?Q?dHgfw7QTcfdfO0B8ff4R2FtS1Jl1Pd67iIxWzplA4pQ3PKvtRsJY/XvB/Fcv?=
 =?us-ascii?Q?vhvcVbu+09enrOU6NLxW4ckc?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef0ab217-798c-4843-629f-08d994b18fec
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 16:40:59.7080
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yghannam@amd.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR12MB2595
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 15, 2021 at 12:24:00AM +0530, Naveen Krishna Chatradhi wrote:
...
> @@ -3726,6 +3935,17 @@ static struct amd64_family_type *per_family_init(struct amd64_pvt *pvt)
>  			pvt->ops = &family_types[F17_M70H_CPUS].ops;
>  			fam_type->ctl_name = "F19h_M20h";
>  			break;
> +		} else if (pvt->model >= 0x30 && pvt->model <= 0x3f) {
> +			if (pvt->mc_node_id >= amd_cpu_node_count()) {
> +				fam_type = &family_types[ALDEBARAN_GPUS];

The fam_type needs to become part of amd64_pvt.

Otherwise, what happens here is the module loads on a CPU node and sets a CPU
family type. Then a GPU node is probed and the family type is overwritten
with a GPU family type.

> +				pvt->ops = &family_types[ALDEBARAN_GPUS].ops;
> +				pvt->is_gpu = true;
> +			} else {
> +				fam_type = &family_types[F19_CPUS];
> +				pvt->ops = &family_types[F19_CPUS].ops;
> +				fam_type->ctl_name = "F19h_M30h";
> +			}
> +			break;
>  		}
>  		fam_type	= &family_types[F19_CPUS];
>  		pvt->ops	= &family_types[F19_CPUS].ops;
> @@ -3808,9 +4028,10 @@ static int init_one_instance(struct amd64_pvt *pvt)

Thanks,
Yazen