Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp819302pxb; Thu, 21 Oct 2021 10:04:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyK8jmDlDbFoCAy0VWrMYB6WNwQDP3MxrAXMMZ49sRrOQBVxN5mI73AdEBp0Tm6exshBWlh X-Received: by 2002:a05:6402:3509:: with SMTP id b9mr9156437edd.187.1634835890190; Thu, 21 Oct 2021 10:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634835890; cv=none; d=google.com; s=arc-20160816; b=zTM7w26EEt0jBaeyNnIeqO+qFTzdJvqupPO5AMkav31WvuLim1DRr9dql7A/1l54dp qi2PL5murFWDh/yuHTBHa6ozWWmf8JUbWaJ8VzCAEUvOHzPiMiGf+BAVYjXDiYOKA7bK kFrvWN4DKR0xCG85Rf9h+32tPulPPWenoFgzaKXPBqsRWTlsfQCdFL2vSTJStM2ILL4p xRhWQcTf4v55Yd+UYKIvKlbcFA+IEAqQG0IJVDCq5FYIuLoRHQ5go3lXDoNMaKDP3kde rR0M/XtmCtrCVqjj9VkeDizbi1RiIKRK2OfaLarnxMQfPHSr3xQ/ti6BaKKzRIEzpA7U dEwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ROWLVcA3zbx0a2s7WZ6YTOzMe5htCzY/r3YEXiuLx4o=; b=YUC7MWXW7WJvI0QxlKYhviOsjnVqRpRHjXLBVKRlauIv5i4vBY+ZzhNFSZam0m62iT b8lMc/Ctpxjk0pWiMp5LnqyBA+EXLDd0w1F7LuvPOKSND1ku8q1eZx+7uVyQVFNNcx05 3+kYkEW+sojh8uif7NiSdb50oUTLrP9/DVl44GgCrzxNW6EH+kYkjeF+LSG27tPDgtqg 8UZAzdHspFQQJZ3Tu9vQ3NNFyP3f5UBSNA6/x36HG1CfIO6nk4KaEXWbPwL10MA3MkWL //qCtmk/I55RqxPAfJowP8HiNelNbGwAVjfweS4BZM3nlxtI9EDgx4tNORwSVcSI1BG/ Q70w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kbtKqp86; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u3si7894838ejb.361.2021.10.21.10.04.19; Thu, 21 Oct 2021 10:04:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kbtKqp86; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231220AbhJUREE (ORCPT + 99 others); Thu, 21 Oct 2021 13:04:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhJUREE (ORCPT ); Thu, 21 Oct 2021 13:04:04 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D69AFC0613B9 for ; Thu, 21 Oct 2021 10:01:47 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id y1so839944plk.10 for ; Thu, 21 Oct 2021 10:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ROWLVcA3zbx0a2s7WZ6YTOzMe5htCzY/r3YEXiuLx4o=; b=kbtKqp869IvvyYrIFZ+BH/Q0al7dwwzh5cM6+zpyBkF7KGxb3RdZG6AjqL12NXrkvj i8TwIJqIVmoMIBKGrwILTA3CQO+qDER/xHXw3nm0xh43UVeuwQ5oTRs40LK7OHGWTEpH JrpCjJhrhkPbXr4Kp1cbU+RO3L2iBO/XAW84g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ROWLVcA3zbx0a2s7WZ6YTOzMe5htCzY/r3YEXiuLx4o=; b=AUW6XQsaZ05Hov5u4p1V8jym3o8Fu5DPTBWQuAp5eIhVzcY3v83f67vjHt7jsyQNCZ WIcc0hinFHOg7lbBdP6z4jOepXYcQgNKDdlOfTHw0TzTlis3Xi/qJ+wmuORV9zUyHQmv loXTUGf/s8JuomG8byJm4h3cXA/dNyC1zlzXUbt/0mNv67idjpdSpLdnSn3A7tZc/vJj Ce+sLL+HFYgL/zEnv38CNMBOQxTdu+VfWvx5WOpzINn1cLcM8AJTpIJjPl0nfkT/nyra RFdggqez7szUKxMP5gQ+Eu2M94hq47rv7+K97cMfHruqrxmW/2GQcHxk8SAuFIJKKO71 fQLw== X-Gm-Message-State: AOAM532VWrgp3RGupRYgXhP8h5v6TCqGRRqAm26OTUNbSfg3cE8K8GkA 7xeFzKRkYilurHMqSWuA5Fplig== X-Received: by 2002:a17:90a:cd:: with SMTP id v13mr8130252pjd.81.1634835707409; Thu, 21 Oct 2021 10:01:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id l29sm5899803pgc.47.2021.10.21.10.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 10:01:46 -0700 (PDT) Date: Thu, 21 Oct 2021 10:01:45 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Joerg Roedel , Will Deacon , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] iommu/dma: Use kvcalloc() instead of kvzalloc() Message-ID: <202110211001.F9F26D90@keescook> References: <20210928222229.GA280355@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210928222229.GA280355@embeddedor> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2021 at 05:22:29PM -0500, Gustavo A. R. Silva wrote: > Use 2-factor argument form kvcalloc() instead of kvzalloc(). > > Link: https://github.com/KSPP/linux/issues/162 > Signed-off-by: Gustavo A. R. Silva Looks right. Reviewed-by: Kees Cook -- Kees Cook