Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp825244pxb; Thu, 21 Oct 2021 10:10:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJ6OFjCVLgNEaDNi0KDu0VXN0tbI2MAWkBqcO4ScxtbLQs3timCgvJeEAsxQQJKLU6A+9/ X-Received: by 2002:a05:6402:c93:: with SMTP id cm19mr9407382edb.40.1634836250567; Thu, 21 Oct 2021 10:10:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634836250; cv=none; d=google.com; s=arc-20160816; b=CS9QL+z6lh0Yd69z5pZcnjvfhUg9sc5oBRPhxxqSaegXJgXKkH/pwfYJdcgM4+APXI D9Pk0B/XaU+9DwqnYo+8+t1Wj1BTRrCExO0LUnOjtWvKKcf/oktVMh4aEqghVP2S2MoM pnZzdIdJ7ovlvL+OlA9pjsabShstd66nPMWar12APupdfJhk2haYG8fRO0utE0yf6Dpa g5DfnkjktkkL3IxJAZuSLpc85Pt9A86k5lB0E6wqj15ltzeBUe4z1XOknniSARIh7XOK WtC8KIQ5suu76QDWk2wxyZp6veNVMONypt4QE8qibco8/YmLz0XA0I6StmP5XIZm7pj+ pVBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7rSlILWSLtNm1l/dt0JGZldq939/2rynRrUJ8zKeXI0=; b=ag8I9lyCfRQ2ggnEWiXjdzSAOKdqA8MP9qt430Ezi6V5gWac5WIx8uTGRh6CksrQvR 22u9hFKORu6RMuQKpNmwtnHMYy6goTQVm0PqoSm0wjLQwfDpTBd/4VPZT964JLSpxtO0 kJP4l67CkD0QR8rvSwQQTxT21PtfNsnMLmBDDJi+Cv/JR/fRxj8FKiqI16k7bAn/4qer fx3nzd9oQPykhT8YsZobzuvuvaGAlFny/Ib/QaQzs+DI77j29GzEU2Nw1PKpqEFTCKNy RVs5tgpn4dMYUE+JtCnxpfkCrqpSpvgLf0W5AVrYsqQUndOY1qgw4YHVrCD0l69txve3 jRVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Na/vDPjg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o17si12091826edc.228.2021.10.21.10.10.26; Thu, 21 Oct 2021 10:10:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Na/vDPjg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232241AbhJURH7 (ORCPT + 99 others); Thu, 21 Oct 2021 13:07:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232226AbhJURHo (ORCPT ); Thu, 21 Oct 2021 13:07:44 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9738DC061348 for ; Thu, 21 Oct 2021 10:05:26 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id s136so897239pgs.4 for ; Thu, 21 Oct 2021 10:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7rSlILWSLtNm1l/dt0JGZldq939/2rynRrUJ8zKeXI0=; b=Na/vDPjgNlUzBFN4GMNIo3Shs5X6jSidKQISyssc1oT1WZZKdpKmy7O6AP6kNzB37C MRItv1idJFk6vxcNVM8YVNM/Lrnh/CmkC0RRngCO/jWtB9rY/j3tN+VEJE9qooifV0QA EOu3swvOtOuEojO2uvMd06RceQRYd4JwoosKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7rSlILWSLtNm1l/dt0JGZldq939/2rynRrUJ8zKeXI0=; b=kQm5S8EbS2ak8Wr+SjwcK/2jSeuz+A2xT2Um0cm+fvyG3utKr1GcCr3UksOB70nMF9 w19EZgV/50QRdeCbdE/rHEKF4Y/W6l21RoFv/NzzRnBfqrD2/wBZLwzM5CFIIq7E8hvU kdwZdOQKTYO7CrZsKmXf5GQkiptLOSTkQ3ZKun2fWDH3z+1xtCRKXh/jRcPC9PaBvQhE 53o4lE9/6VPdx/W2nDTKnxk0m7Gblj7KR5Ya/bJXWAS8c8dDfDCDmyGDBFSA03C2VqWP DtobJ6dbL4u1lsMPY58tJm+6OITwikBJLJeWVPpMUzSpe1a7LBWq2VyMJQ58CyIkv3e4 QaGA== X-Gm-Message-State: AOAM533X+7y+aqGH8atig00eZY/zoE+420vFJTy4EkptBmTgOCzcwTa3 cWTYo0HszvUt4ah82OA5sL+0Aw== X-Received: by 2002:a62:61c3:0:b0:44d:2518:cdf1 with SMTP id v186-20020a6261c3000000b0044d2518cdf1mr6805487pfb.31.1634835926105; Thu, 21 Oct 2021 10:05:26 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id oa4sm7004169pjb.13.2021.10.21.10.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 10:05:25 -0700 (PDT) Date: Thu, 21 Oct 2021 10:05:25 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Jakub Kicinski , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] ice: use devm_kcalloc() instead of devm_kzalloc() Message-ID: <202110211004.6CF2B2C5D@keescook> References: <20211006180908.GA913430@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211006180908.GA913430@embeddedor> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 06, 2021 at 01:09:08PM -0500, Gustavo A. R. Silva wrote: > Use 2-factor multiplication argument form devm_kcalloc() instead > of devm_kzalloc(). > > Link: https://github.com/KSPP/linux/issues/162 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook Similar patch state here, it seems? Who needs to Ack this? https://patchwork.kernel.org/project/netdevbpf/patch/20211006180908.GA913430@embeddedor/ Thanks! -- Kees Cook