Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1021161pxb; Thu, 21 Oct 2021 14:12:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxR4Gf7zwkV70w/e1HV+PS4liD1fNxVKosjGD+XJHIZe6kpiNl6iwDBo0sDLXY1auZ37+LY X-Received: by 2002:a17:90a:e7cc:: with SMTP id kb12mr9471740pjb.182.1634850729547; Thu, 21 Oct 2021 14:12:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634850729; cv=none; d=google.com; s=arc-20160816; b=BgabgwFLf0L91US/P+M7W+DwPyHCTm5S6XCPI9GkyTDUq9xj+U9/3FPwxLwh3vEh0K HmJGu4uP9xgDxIIPwoG8swCUITWzihnhEev4QTjbkI7WkpuyDrJhAwAFxNVmliBy1g1O q/HHIAhBR72iJ2CAEJlSkbPOk9Dl1EC5mPXDqkKgd/bQUbfFJZzPrhGBIg0V2Eh+p3rB Fthd9YvK6z/ckOY/OsvIMQAVCgoQ7W1s9llaKX2kT0jEdQssQAJzLFC6XvMaQPABC7Jb 4mwsnxJnBjQzHHxu0LDNPu7RgLzgC63ZSlpGs7NOVIsIFKsWtUq5FYW8HsqBbvaa0a40 O2TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature:dkim-filter; bh=/5PqWLE4FcBhImTJA9XMH2rm/C/TLG5+zjc1qYZQyFg=; b=pdIBltylvgqSeI7wkkX6pKDy+7K5Upvb1cbAPAiOZn8Ly9Fig/j0CNXAoW+0k9E2fN 9oagKbQnk7BI81xJkNkVCHVgfvuS5p5/anG6u7WFtUkYYWAwpXeCm4xniNsOZRhPhOvo 6x5fd/pne613RXzyaPbmlNw/kvk/oDxlN8w3KL+FBr/P09nKIiRs74Vyt1KPtIHE800h Cni7YiJC2RkJVmzxw21vOAmaPsWiu6Y7+zzWm3dNhZJYbv3Gsw1r52hLcQ+49Hsd+rmQ A8vV+l9Z99i7i279UcyJ7pPmWlqF5BhoCJCGb1CEux0On8hqRoDnva61yLIt+YdyidB8 CdyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=lPVFQP7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si6683491pgp.227.2021.10.21.14.11.53; Thu, 21 Oct 2021 14:12:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=lPVFQP7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232176AbhJUVMr (ORCPT + 99 others); Thu, 21 Oct 2021 17:12:47 -0400 Received: from ms.lwn.net ([45.79.88.28]:53294 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232158AbhJUVMq (ORCPT ); Thu, 21 Oct 2021 17:12:46 -0400 Received: from localhost (unknown [IPv6:2601:281:8300:104d::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 9578B97D; Thu, 21 Oct 2021 21:10:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 9578B97D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1634850629; bh=/5PqWLE4FcBhImTJA9XMH2rm/C/TLG5+zjc1qYZQyFg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lPVFQP7lLogTE0no1qOXHEdfSoBuq2YKavzjGD4P+t0Sp7YFZJlY4iyAIA2q+40AC Lt9mih0Ta4F82gBMnS1hRNUZT/od3nkl7L92gpIuxwMSRRL/IPt+UwtV3GCSqTHGRn SP9oy4QDk4LjiNPqVeNEPPZdxeMmiX6HrhFN5SOGxerGiXiQ5bBBU4DLyLK1uIDVmN lGZTI2x+rfyjk5DcbM2nnOnj9urzUD8h4YFhtZ28DodZY2IODRUHgaZApI93Dh9ilC vr0H/DTzzOpk+Q47k+QjzKlvevt9jH/IGLP2huS8a8F/5WZVfLMDqYgsPHsiMMk8Pq hcvE0tILiobTw== From: Jonathan Corbet To: Stephen Rothwell , Vadim Pasternak Cc: Hans de Goede , Mark Gross , Linux Kernel Mailing List , Linux Next Mailing List , Mauro Carvalho Chehab Subject: Re: linux-next: build warnings after merge of the drivers-x86 tree In-Reply-To: <20211022070452.28924855@canb.auug.org.au> References: <20211021184735.794b22a7@canb.auug.org.au> <20211022070452.28924855@canb.auug.org.au> Date: Thu, 21 Oct 2021 15:10:28 -0600 Message-ID: <87lf2mjd8b.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [CC += Mauro] Stephen Rothwell writes: > On Thu, 21 Oct 2021 09:07:03 +0000 Vadim Pasternak wrote: >> >> What is wrong with the syntax at line 230 and where blank line is expected? >> >> What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/bios_active_image >> What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/bios_auth_fail >> What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/bios_upgrade_fail >> Date: October 2021 <--- this is line 230 >> KernelVersion: 5.16 > > I am sorry, I don't know. Added Jon to cc for advice. The problem isn't that line at all, it's the use of a bulleted list a few lines further down; that doesn't work in ABI files. Mauro, this ABI stuff is fragile, and this kind of problem occurs fairly often. How hard would it be to (1) make it a bit more robust, (2) make it issue useful warnings where it can't be robust, and (3) properly document the restrictions for ABI files? Meanwhile, the attached patch fixes it; feel free to use it or to just fold the change into your work. Thanks, jon ----------------------------- From 97371e6afda75eef71b7d5d1794645e5cfaf1811 Mon Sep 17 00:00:00 2001 From: Jonathan Corbet Date: Thu, 21 Oct 2021 15:02:43 -0600 Subject: [PATCH] docs: ABI: fix documentation warning in sysfs-driver-mlxreg-io The use of a Sphinx list within this ABI file caused the following warning: Documentation/ABI/stable/sysfs-driver-mlxreg-io:230: WARNING: Unexpected indentation. Documentation/ABI/stable/sysfs-driver-mlxreg-io:230: WARNING: Block quote ends without a blank line; unexpected unindent. Remove the bullets to make the warning go away and get proper formatting. Reported-by: Stephen Rothwell Signed-off-by: Jonathan Corbet --- .../ABI/stable/sysfs-driver-mlxreg-io | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/Documentation/ABI/stable/sysfs-driver-mlxreg-io b/Documentation/ABI/stable/sysfs-driver-mlxreg-io index c84795ccecad..12c3f895cd2f 100644 --- a/Documentation/ABI/stable/sysfs-driver-mlxreg-io +++ b/Documentation/ABI/stable/sysfs-driver-mlxreg-io @@ -231,16 +231,19 @@ Date: October 2021 KernelVersion: 5.16 Contact: Vadim Pasternak Description: The files represent BIOS statuses: - - bios_active_image: location of current active BIOS image: - 0: Top, 1: Bottom. - The reported value should correspond to value expected by OS - in case of BIOS safe mode is 0. This bit is related to Intel - top-swap feature of DualBios on the same flash. - - bios_auth_fail: BIOS upgrade is failed because provided BIOS - image is not signed correctly. - - bios_upgrade_fail: BIOS upgrade is failed by some other - reason not because authentication. For example due to - physical SPI flash problem. + + bios_active_image: location of current active BIOS image: + 0: Top, 1: Bottom. + The reported value should correspond to value expected by OS + in case of BIOS safe mode is 0. This bit is related to Intel + top-swap feature of DualBios on the same flash. + + bios_auth_fail: BIOS upgrade is failed because provided BIOS + image is not signed correctly. + + bios_upgrade_fail: BIOS upgrade is failed by some other + reason not because authentication. For example due to + physical SPI flash problem. The files are read only. -- 2.31.1