Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e2fc87c9-570b-546a-5c7e-867b26b9840e@intel.com>
Date:   Thu, 21 Oct 2021 16:33:51 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] sfc: Don't use netif_info before net_device setup
Content-Language: en-US
To:     Erik Ekman <erik@kryo.se>, Edward Cree <ecree.xilinx@gmail.com>,
        "Martin Habets" <habetsm.xilinx@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20211019224016.26530-1-erik@kryo.se>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20211019224016.26530-1-erik@kryo.se>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0RFdmRBZDJvUm83NVRnbWY5OVltb01acWc2dTZaYklyRnA0YXA4UnU4N0Q3?=
 =?utf-8?B?TU0vam9icTM1TE4zdTBNZWdZZ0tRN0RQZUsxT3ZWYkdXYVNlZ0hBY1RPc1dx?=
 =?utf-8?B?Q1djRDJSRVRmakhoL1ZNUjM4cUlBK202bDdoY0VxRjFpc2lXVXY5b21JTitw?=
 =?utf-8?B?Z09nMU5VRTdzcSt6Q1J6dkZOMDFTS2hjcFJJRXViNFZ5UGlNZUpnUGdYaXNG?=
 =?utf-8?B?aG1PaXJUbVVhTkF4TkEyeXI2cVkxb3hjb2k4RUtURzMyYjVBUk5XbmhTZFFC?=
 =?utf-8?B?NUxoMXRIUVIxNUdhMVBsNlUrejU4Mk5WbDJTdXZId2hFR3RkQytycml3dXov?=
 =?utf-8?B?eWZMT1RLbnQwNm1OSk1tM011SEhCMHRnLzVSNUVSM3p5d2g3SEovM25iTXZC?=
 =?utf-8?B?eFhSQnZBZ2FZbjgyWlBGYmoxaGRxK1pJNW9rbmVlejQ1MkNnR1NNTjE3S2Uy?=
 =?utf-8?B?SUdvZmdRVmRZSG1USy8xUEFaazBCb3cyczZHaVgrNnBTNXdNTnlqK1lyZkEx?=
 =?utf-8?B?MzlpcG4zRHhIanU5dmVOeEVtSGdqM3NHb1B0V20rUmRjaEpqSG1ha29QZnlx?=
 =?utf-8?B?b3VDeXQ3a0RVQ0txcWx1WjA4aFZSUnMvQmhkY1RiZ2JSN05PeUtZL2Q1amFH?=
 =?utf-8?B?dUJtbDdvYkt3TC9iL2h6R2ZtdkJaU25qelZ5UzMrbXQxbEtQeGhFcnlldEhP?=
 =?utf-8?B?eUR1T2ZrQmZQVUZiVkFqbzBtZjN0MUR4MjN1N1FDeXVaWWw0T3ZUZVNKZ0N3?=
 =?utf-8?B?WG9taVhxZUF4ZkgzRUxFNEdtZXB5S0ZPN2MxNmc5WWdrN3grTHpSaFJRZDZa?=
 =?utf-8?B?ZkJlZ1dETzZKZzJzakpWUUtPZlU2bnR1T2ZaTmV3TWY3SlJoMnpKQjl0STBW?=
 =?utf-8?B?NlNKeHppZHBPMkJzQXd0TFl2S0t5WlF0YlZCREo2ZjFObFhoRXZFMUF6OFFQ?=
 =?utf-8?B?NGNaQUY1NEdCeDd3Z3h0eGlPK0FXbk9iVE5Dd0trNmloSlBtbnFxdzQ3d2hV?=
 =?utf-8?B?ODlpSjVrQmpLVGpnL2tpMmp6ZitzWXUxUlJhWlB3N1dkYkVUZm5MUW9VUFNZ?=
 =?utf-8?B?Y0lHZHRVaVJMSFlobDhWV2FOWVNxY0dIS3pnM0NGczVFdTFHdzNEbVFjWFNX?=
 =?utf-8?B?ZFk4VzFRRGtMQVVLWmppcjM1QkEyTkdKbjVnSmpwVXlqcE84QjlyczBnczZi?=
 =?utf-8?B?U0p0MHU3Ykx5NTY2WWtsUDdENUpHMGF6WHJqVHl2MTFPWGJOMHF0WXRxS2F3?=
 =?utf-8?B?bU1rVzMwU2NpRG1kdDBTRWNqTUUwTVB0MHgwb1NOYTJtYWRGbUZvdms3ZHc2?=
 =?utf-8?B?aFJDMGVwSDV5V3dQQmNTOVBzeVUyUmg3V3Mra21HdU4zTGVRRzhoUmwzWHJX?=
 =?utf-8?B?bVZndFl5UVJBOU1WSVFwaVRrWmU0RlF1WlMyWHN4bXBvS1Z6YkFaZDgrWW5Q?=
 =?utf-8?B?eXpsYjdNbnV6S0VaMHFraG1qaTlrUUtycXJnU3dyK1REank4TUFMb0M5VSs0?=
 =?utf-8?B?dHNqZ3hLdm5WbGRjWXJHVldvR1ozNmVxa0ZJV3pkUmZPZUNGenFXMGRPMHRI?=
 =?utf-8?B?a2JiUXUxalNSUEZZR2V3UEdTcUFibldVZ013MzBlMlFSWjFWUlp0a0R4TnNa?=
 =?utf-8?B?RkVpUEp0NGcycFdHclhuNzYwRlZZUXJ3UktaU0NhWVdGdFp2ZVJRSnhFYVlO?=
 =?utf-8?B?STRiRXRMcG4vUVgrMDlCUmo0MVF5M05hak15WS9DTWx2VlNPMTNXQW13aHNj?=
 =?utf-8?B?QUlXbUxWejMxVjdlQzg1bzdldnA3UUFtNmx6N3NOR0ZRdDBpd0wvbmtQbVc4?=
 =?utf-8?B?SkIwMTd1Zk5iMjVWaXo0aVV3V2c5WWFIN0k2TkprSGhkRWZIRjdSUCtnTVA5?=
 =?utf-8?B?Q2hzVHdObXZEcUR3a1BZNGdVZmcrTnZjU0tIUFRHL1U2M1B2L2JBQ3MrTVFm?=
 =?utf-8?Q?X7buBLDRTpsY1Dzh6k1v4Hs23Mi6BdY2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd9d212-6e61-4d96-d260-08d994eb3e8c
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Oct 2021 23:33:53.8362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jesse.brandeburg@intel.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5009
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/19/2021 3:40 PM, Erik Ekman wrote:
> Use pci_info instead to avoid unnamed/uninitialized noise:
> 
> [197088.688729] sfc 0000:01:00.0: Solarflare NIC detected
> [197088.690333] sfc 0000:01:00.0: Part Number : SFN5122F
> [197088.729061] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no SR-IOV VFs probed
> [197088.729071] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no PTP support
> 
> Inspired by fa44821a4ddd ("sfc: don't use netif_info et al before
> net_device is registered") from Heiner Kallweit.
> 
> Signed-off-by: Erik Ekman <erik@kryo.se>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>