Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211020223920.2810727-1-alistair.francis@opensource.wdc.com> <YXFqYJsPYA4c4Fqw@kernel.org>
In-Reply-To: <YXFqYJsPYA4c4Fqw@kernel.org>
From:   Alistair Francis <alistair23@gmail.com>
Date:   Fri, 22 Oct 2021 10:35:08 +1000
Message-ID: <CAKmqyKMMQ7UaUTaCBHWrrtT-W+s5-ERAx6H97oOdNyCoXG7ngg@mail.gmail.com>
Subject: Re: [PATCH v4 1/4] perf bench futex: Call the futex syscall from a function
To:     Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc:     Alistair Francis <alistair.francis@opensource.wdc.com>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        linux-perf-users@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Darren Hart <dvhart@infradead.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Atish Patra <atish.patra@wdc.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Alistair Francis <alistair.francis@wdc.com>,
        Davidlohr Bueso <dbueso@suse.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 21, 2021 at 11:25 PM Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Thu, Oct 21, 2021 at 08:39:17AM +1000, Alistair Francis escreveu:
> > From: Alistair Francis <alistair.francis@wdc.com>
> >
> > In preparation for a more complex futex() function let's convert the
> > current macro into two functions. We need two functions to avoid
> > compiler failures as the macro is overloaded.
> >
> > This will allow us to include pre-processor conditionals in the futex
> > syscall functions.
> >
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > Acked-by: Davidlohr Bueso <dbueso@suse.de>
> > ---
> >  tools/perf/bench/futex.h | 43 ++++++++++++++++++++++++----------------
> >  1 file changed, 26 insertions(+), 17 deletions(-)
>
> Right after applying this one:
>
> In file included from bench/futex-hash.c:29:
> bench/futex.h: In function =E2=80=98futex_syscall=E2=80=99:
> bench/futex.h:52:61: error: =E2=80=98ts32=E2=80=99 undeclared (first use =
in this function); did you mean =E2=80=98s32=E2=80=99?
>    52 |         return syscall(SYS_futex, uaddr, op | opflags, val, ts32,=
 uaddr2, val3);
>       |                                                             ^~~~
>       |                                                             s32

Sorry about that. There is a copy and paste error here. I have fixed this p=
atch.

Alistair

> bench/futex.h:52:61: note: each undeclared identifier is reported only on=
ce for each function it appears in
> bench/futex.h:49:82: error: unused parameter =E2=80=98timeout=E2=80=99 [-=
Werror=3Dunused-parameter]
>    49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, s=
truct timespec *timeout,
>       |                                                                 ~=
~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Wer=
ror=3Dreturn-type]
>    53 | }
>       | ^
> cc1: all warnings being treated as errors
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp=
/build/perf/bench/futex-hash.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> In file included from bench/futex-wake-parallel.c:31:
> bench/futex.h: In function =E2=80=98futex_syscall=E2=80=99:
> bench/futex.h:52:61: error: =E2=80=98ts32=E2=80=99 undeclared (first use =
in this function); did you mean =E2=80=98s32=E2=80=99?
>    52 |         return syscall(SYS_futex, uaddr, op | opflags, val, ts32,=
 uaddr2, val3);
>       |                                                             ^~~~
>       |                                                             s32
> bench/futex.h:52:61: note: each undeclared identifier is reported only on=
ce for each function it appears in
> bench/futex.h:49:82: error: unused parameter =E2=80=98timeout=E2=80=99 [-=
Werror=3Dunused-parameter]
>    49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, s=
truct timespec *timeout,
>       |                                                                 ~=
~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Wer=
ror=3Dreturn-type]
>    53 | }
>       | ^
> cc1: all warnings being treated as errors
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp=
/build/perf/bench/futex-wake-parallel.o] Error 1
> In file included from bench/futex-requeue.c:26:
> bench/futex.h: In function =E2=80=98futex_syscall=E2=80=99:
> bench/futex.h:52:61: error: =E2=80=98ts32=E2=80=99 undeclared (first use =
in this function); did you mean =E2=80=98s32=E2=80=99?
>    52 |         return syscall(SYS_futex, uaddr, op | opflags, val, ts32,=
 uaddr2, val3);
>       |                                                             ^~~~
>       |                                                             s32
> bench/futex.h:52:61: note: each undeclared identifier is reported only on=
ce for each function it appears in
> bench/futex.h:49:82: error: unused parameter =E2=80=98timeout=E2=80=99 [-=
Werror=3Dunused-parameter]
>    49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, s=
truct timespec *timeout,
>       |                                                                 ~=
~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Wer=
ror=3Dreturn-type]
>    53 | }
>       | ^
> cc1: all warnings being treated as errors
> In file included from bench/futex-lock-pi.c:19:
> bench/futex.h: In function =E2=80=98futex_syscall=E2=80=99:
> bench/futex.h:52:61: error: =E2=80=98ts32=E2=80=99 undeclared (first use =
in this function); did you mean =E2=80=98s32=E2=80=99?
>    52 |         return syscall(SYS_futex, uaddr, op | opflags, val, ts32,=
 uaddr2, val3);
>       |                                                             ^~~~
>       |                                                             s32
> bench/futex.h:52:61: note: each undeclared identifier is reported only on=
ce for each function it appears in
> bench/futex.h:49:82: error: unused parameter =E2=80=98timeout=E2=80=99 [-=
Werror=3Dunused-parameter]
>    49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, s=
truct timespec *timeout,
>       |                                                                 ~=
~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Wer=
ror=3Dreturn-type]
>    53 | }
>       | ^
> cc1: all warnings being treated as errors
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp=
/build/perf/bench/futex-requeue.o] Error 1
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp=
/build/perf/bench/futex-lock-pi.o] Error 1
> In file included from bench/futex-wake.c:25:
> bench/futex.h: In function =E2=80=98futex_syscall=E2=80=99:
> bench/futex.h:52:61: error: =E2=80=98ts32=E2=80=99 undeclared (first use =
in this function); did you mean =E2=80=98s32=E2=80=99?
>    52 |         return syscall(SYS_futex, uaddr, op | opflags, val, ts32,=
 uaddr2, val3);
>       |                                                             ^~~~
>       |                                                             s32
> bench/futex.h:52:61: note: each undeclared identifier is reported only on=
ce for each function it appears in
> bench/futex.h:49:82: error: unused parameter =E2=80=98timeout=E2=80=99 [-=
Werror=3Dunused-parameter]
>    49 | futex_syscall(volatile u_int32_t *uaddr, int op, u_int32_t val, s=
truct timespec *timeout,
>       |                                                                 ~=
~~~~~~~~~~~~~~~~^~~~~~~
> bench/futex.h:53:1: error: control reaches end of non-void function [-Wer=
ror=3Dreturn-type]
>    53 | }
>       | ^
> cc1: all warnings being treated as errors
> make[4]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:96: /tmp=
/build/perf/bench/futex-wake.o] Error 1
> make[3]: *** [/var/home/acme/git/perf/tools/build/Makefile.build:139: ben=
ch] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [Makefile.perf:660: /tmp/build/perf/perf-in.o] Error 2
> make[1]: *** [Makefile.perf:240: sub-make] Error 2
> make: *** [Makefile:113: install-bin] Error 2
> make: Leaving directory '/var/home/acme/git/perf/tools/perf'
>
>  Performance counter stats for 'make -k BUILD_BPF_SKEL=3D1 CORESIGHT=3D1 =
PYTHON=3Dpython3 O=3D/tmp/build/perf -C tools/perf install-bin':
>
>           2,467.00 msec task-clock:u              #    1.263 CPUs utilize=
d
>           2,457.82 msec cpu-clock:u               #    1.259 CPUs utilize=
d
>
>        1.952573032 seconds time elapsed
>
>        1.444401000 seconds user
>        1.111434000 seconds sys
>
>
> =E2=AC=A2[acme@toolbox perf]$
>
>