Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Yongxin Liu <yongxin.liu@windriver.com>,
        "Keller, Jacob E" <jacob.e.keller@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "kuba@kernel.org" <kuba@kernel.org>
Subject: RE: [PATCH net] ice: check whether PTP is initialized in
 ice_ptp_release()
Thread-Topic: [PATCH net] ice: check whether PTP is initialized in
 ice_ptp_release()
Thread-Index: AQHXvm71BKbovgK8dUSOJ9AjphaGYqvejHmg
Date:   Fri, 22 Oct 2021 05:22:27 +0000
Message-ID: <BYAPR11MB33676CD4ED95DC1EADB6BC0DFC809@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20211011070216.40657-1-yongxin.liu@windriver.com>
In-Reply-To: <20211011070216.40657-1-yongxin.liu@windriver.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KiKgco4iYSNmco7C8X1bqDTvPnQt/hPSY78dj47TNV+c5YKsjEfIpwmUanm5?=
 =?us-ascii?Q?ZL99ja6w1TPbqXlsD799oktKk86P63wRsx6ue9u4+VrKyHoXKl34j/ywDogO?=
 =?us-ascii?Q?i6XXaRsjQykMZGzohRms2b7Nlbl3szf0f8pLB3XpwQl/nKATziXeCzcPEl8M?=
 =?us-ascii?Q?YIwX8E5WLz/810mfOiapBUqQ7f4ObM/lQZLR7Ja6ibsJOofc/kz6+U+GOdv+?=
 =?us-ascii?Q?d8Y8NvLzYGAxxjWDW4/Jhuq3605E/NBydepTe19Cpcdp/Gg9VuasncgpPxgc?=
 =?us-ascii?Q?pBPhEPXsSmkEJqCoQAGTepEZBeuXA3g1ldctZfs86n883LreTshj+kA62Uz3?=
 =?us-ascii?Q?7tVIjnwbR2Rxi9qSrhZa6inFWPwycDndg3O9dqVC04Opn6ksCAN/a8BKGARW?=
 =?us-ascii?Q?HDWVUmSf9ctJjhb4AoI3Haxb/9rKwXQ6xivPahX/hX7acZ02QpIID+wzTP3V?=
 =?us-ascii?Q?8kSPPTd4sqCgCLD9wQq6z020B84f+BoQ6FqBc18MMpjfRN5OrNRxrDWDP8+n?=
 =?us-ascii?Q?GpgvXuXMi7ICw9be5AjPTbDLti35FyWJu50W4cfM9raF0jgR0lTLnuDwdHWc?=
 =?us-ascii?Q?sQOAQ5vkBuzGR5zB412JzG92PW16s4SgEHjJyE/27Ej4thclo+Y/dzJojMkg?=
 =?us-ascii?Q?Dq+A8Zhncd+E8IyTz/Hv5MLS5xqwAwkkOWpSCaD7f5F2oQ2oHx8jK4EOYW5a?=
 =?us-ascii?Q?ulSG+WliU6Fmwl1mUEonu2g5V9HjOZIKSwVL/6rR3OqBz8NzIGGI5OTNsGVx?=
 =?us-ascii?Q?4HkqOzxlVG1I6DAwnJ8FSnMuWROuSW2w1h95UfnkM75mdtCt9PXbl64F3hlQ?=
 =?us-ascii?Q?aA5BTjtSvUkV4+osIswPj5wtr9gKyQdunOMl9T9Gi1APX5oqWkjrJBK9Jupp?=
 =?us-ascii?Q?gR/cJhHzIv0CTfbJ3OFoy/BtRJFdb6AIkGwISxT1e5RbscTK3QPP1ns4WwIf?=
 =?us-ascii?Q?JS/YS+rdbkMrnqoCNBUju4hVJJ/TKf3I4vBO8VhXW7g84ka/QsboIjWVOmT+?=
 =?us-ascii?Q?vOwnDxoPbwwo6WxuWd65nI+6niZyzHQXqhRt5lI1yNPqVJ3J73lLqVmtnzK8?=
 =?us-ascii?Q?zpMk541qM+JWn9yeqYcDiyLWt816TWIczHSPRBkzsBJlioeisx7VcZs3bExd?=
 =?us-ascii?Q?598yYVqEWb3AkG/nV0OpvHQ/rlA/vDFoT2RGdPOFpzqf092pKH5vkUdgugLD?=
 =?us-ascii?Q?yX0QSN9uisQfq9XQnSuTrVhLh4uZeSpbLisTopv5WD9KVkYd13PhJ16s1qPJ?=
 =?us-ascii?Q?HtzapC5O3J8ooo/GMJ3iEzIsMYZJ4S9wctoC/LS3cS63g3I/kJPhP8dXOj5P?=
 =?us-ascii?Q?tsL1C2YgYzjV+ZnLR6slYwOAH+tbtnkk3SNN6UP/w1IlxvV6XgJ1RhIc/map?=
 =?us-ascii?Q?YlqEf5ECnUMzDXt9UeAgPyOrsJGfIAQ6Y99uxzFWjCHyx8YVQp9YZ874kK04?=
 =?us-ascii?Q?eOeVjGM+H+Q=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1b9ac08-bb74-4d05-03f0-08d9951bf02e
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2021 05:22:27.4339
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gurucharanx.g@intel.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3094
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Yongxin Liu <yongxin.liu@windriver.com>
> Sent: Monday, October 11, 2021 12:32 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>; G, GurucharanX
> <gurucharanx.g@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> davem@davemloft.net; Brandeburg, Jesse <jesse.brandeburg@intel.com>;
> intel-wired-lan@lists.osuosl.org; kuba@kernel.org
> Subject: [PATCH net] ice: check whether PTP is initialized in ice_ptp_rel=
ease()
>=20
> PTP is currently only supported on E810 devices, it is checked in ice_ptp=
_init().
> However, there is no check in ice_ptp_release().
> For other E800 series devices, ice_ptp_release() will be wrongly executed=
.
>=20
> Fix the following calltrace.
>=20
>   INFO: trying to register non-static key.
>   The code is fine but needs lockdep annotation, or maybe
>   you didn't initialize this object before use?
>   turning off the locking correctness validator.
>   Workqueue: ice ice_service_task [ice]
>   Call Trace:
>    dump_stack_lvl+0x5b/0x82
>    dump_stack+0x10/0x12
>    register_lock_class+0x495/0x4a0
>    ? find_held_lock+0x3c/0xb0
>    __lock_acquire+0x71/0x1830
>    lock_acquire+0x1e6/0x330
>    ? ice_ptp_release+0x3c/0x1e0 [ice]
>    ? _raw_spin_lock+0x19/0x70
>    ? ice_ptp_release+0x3c/0x1e0 [ice]
>    _raw_spin_lock+0x38/0x70
>    ? ice_ptp_release+0x3c/0x1e0 [ice]
>    ice_ptp_release+0x3c/0x1e0 [ice]
>    ice_prepare_for_reset+0xcb/0xe0 [ice]
>    ice_do_reset+0x38/0x110 [ice]
>    ice_service_task+0x138/0xf10 [ice]
>    ? __this_cpu_preempt_check+0x13/0x20
>    process_one_work+0x26a/0x650
>    worker_thread+0x3f/0x3b0
>    ? __kthread_parkme+0x51/0xb0
>    ? process_one_work+0x650/0x650
>    kthread+0x161/0x190
>    ? set_kthread_struct+0x40/0x40
>    ret_from_fork+0x1f/0x30
>=20
> Fixes: 4dd0d5c33c3e ("ice: add lock around Tx timestamp tracker flush")
> Signed-off-by: Yongxin Liu <yongxin.liu@windriver.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ptp.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)