Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1444581pxb; Fri, 22 Oct 2021 00:42:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtLj1kuRDk/kDrZFRPsj/oGLRgNP6wWBGueoKpVT8HaiC+wl1iJWF+5x8J4lSnTmkRSQnJ X-Received: by 2002:a17:906:948c:: with SMTP id t12mr7570138ejx.530.1634888520605; Fri, 22 Oct 2021 00:42:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634888520; cv=none; d=google.com; s=arc-20160816; b=I8YWzpDK3nAH4SeBKkIuBucJRzmlBJoco4DA6BtRrhoMVT+bFoj6hOnuwG/1DPjxMi Cqph59umt6yIBRCbpa6+BvnCqKkE1sJCDGiyD1P4T14/smUjocdHQji1fmVl2IN82MKw 9wbDFVpTzBqdeZWzkbeMnAHCGed1l6WON4clG89KYiPXJn1cLPgJTxJKxJQ1QWc3zKng BgPv+FvemgV3Yi1RMEr8/QRZa4h5ZGi6cFnLTV7Ewlr1P8+8KhwkQr/8TYsLcRUe9ueQ u3K0eli1YvIZXi4weWIE7XZjouMTo33FeYIRal1jSOzgdtK+fu1jl/Cg+rXUoqdV9feh 52qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=8Hqx8kcONFPoy9FxK/RezstvaCHSjn7Z1o+r8rUmvHQ=; b=sjXiJO5IbctGQwnSJ1hxTIC1r0w+CR6Ed5mH890SS+GrHlmsWck3V60X8fGMaUboZb y/4qeafTjbhoF+dGpMmfH19D5ki0I+c6zlQXHrpidMuWlxG3Z4CNebpZan7DGBEybAS8 qp6ws9BIVCeLNh34EUwN44vP4aA6QcTFmFOzYYo/3roJm1NbN1eoN4sQMPbBlHyWrcUD kDbT5u0SaFhIoMi77EXYEMkFSfkebdPmpX7YIJVG7RxHXGgXXqiKG9kNoaAt1Y2nGow/ SONZRCWbInPQcTRUJXkx+Nd9X+1yzLszIA1B+9aKMYsvTV6XGQ/rUwCJvAqfkNQesaiL oMLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h26si1757783edv.491.2021.10.22.00.41.37; Fri, 22 Oct 2021 00:42:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232370AbhJVHkV (ORCPT + 99 others); Fri, 22 Oct 2021 03:40:21 -0400 Received: from inva020.nxp.com ([92.121.34.13]:56218 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232201AbhJVHkM (ORCPT ); Fri, 22 Oct 2021 03:40:12 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 930941A1B8C; Fri, 22 Oct 2021 09:37:54 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 58F001A0783; Fri, 22 Oct 2021 09:37:54 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id E65DE183AD0B; Fri, 22 Oct 2021 15:37:52 +0800 (+08) From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com Cc: linux-pci@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Richard Zhu Subject: [PATCH v3 5/7] PCI: dwc: add a new callback host exit function into host ops Date: Fri, 22 Oct 2021 15:12:28 +0800 Message-Id: <1634886750-13861-6-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1634886750-13861-1-git-send-email-hongxing.zhu@nxp.com> References: <1634886750-13861-1-git-send-email-hongxing.zhu@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When link is never came up in the link training after host_init. The clocks and power supplies usage counter balance should be handled properly on some DWC platforms (for example, i.MX PCIe). Add a new host_exit() callback into dw_pcie_host_ops, then it could be invoked to handle the unbalance issue in the error handling after host_init() function when link is down. Signed-off-by: Richard Zhu --- drivers/pci/controller/dwc/pcie-designware-host.c | 5 ++++- drivers/pci/controller/dwc/pcie-designware.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index d1d9b8344ec9..9d450e71b93b 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -404,7 +404,7 @@ int dw_pcie_host_init(struct pcie_port *pp) if (!dw_pcie_link_up(pci) && pci->ops && pci->ops->start_link) { ret = pci->ops->start_link(pci); if (ret) - goto err_free_msi; + goto err_host_init; } /* Ignore errors, the link may come up later */ @@ -416,6 +416,9 @@ int dw_pcie_host_init(struct pcie_port *pp) if (!ret) return 0; +err_host_init: + if (pp->ops->host_exit) + pp->ops->host_exit(pp); err_free_msi: if (pp->has_msi_ctrl) dw_pcie_free_msi(pp); diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index 7d6e9b7576be..1153687ea9a6 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -174,6 +174,7 @@ enum dw_pcie_device_mode { struct dw_pcie_host_ops { int (*host_init)(struct pcie_port *pp); + void (*host_exit)(struct pcie_port *pp); int (*msi_host_init)(struct pcie_port *pp); }; -- 2.25.1