Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1444665pxb; Fri, 22 Oct 2021 00:42:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6v8pyFCNfedXRuY/kxX+NGL77mhdi5LNXA/OHiRtpFHLvyjIDwyAU91vw2THKsntjJ9dV X-Received: by 2002:a17:906:ad98:: with SMTP id la24mr13720525ejb.383.1634888527941; Fri, 22 Oct 2021 00:42:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634888527; cv=none; d=google.com; s=arc-20160816; b=PR3eTAM08nsOdx9jLnAGpssswMO8uDQ+VVFZBjgbam+sBdBREMLnB4C9B+M7tH+MPw l+4HTD77xJ1D1GSt/TmkHYChibd3dfaaNR5SQsht3O1MznHZmlKx60x2QVu/rSqol3fd KHRi3NlJit2lDsAcczxgHkFCb+DfrzPoN4+0HwZ2Ps7gEuO9sBwi0ppIdTehgRtpVZ1p B7k5KsIx2Y/kKNVaFCJA86B1SKmCLiNqQgrYUpl1aQ3oycGSCviRTcdYb96JMATuTHlS RAG+t+M8i1WSMhQnia6TSmQH7WWJOj8KgIGd2RsxHo6MiUg5zQI6m3+ozB0zwAGmdD3w jJgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:abuse-reports-to:tuid:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=oplauqdeed0/BUBAzAbADABw/zudTd2ShycyBvBs0so=; b=gw7sePmsdtwWKrL8NUi96CJ19xi+OSsTiE+9GQpMX77VlyGn06yhiAR1ZneI5UJFqh Al42b8L1L5m7tNlDD+746lGksLoCwJj2qqqxekK9q3eqYQMLwgMiC7KknIaOcS9v076u 2fhZftbs/ndjF7Am4l/pKhtPe6fIMXySlI9HjIibK8ejXFreiVQXdHGU7oW9U2vwL2dh yxDsKLy/tXc4pIz/ja2RErR16UmHglqH7mp10SQKGmoYWox4jK7c82odtxUGYe/8Q2Mg Pcg8hROQ4M2zk0E2ZMqKoQRoGmpJSkk8THbdGHWyHbK6tg6U/zFgaBjrbfqOWXS2L6Rr 7CFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hb44si13612759ejc.38.2021.10.22.00.41.44; Fri, 22 Oct 2021 00:42:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232140AbhJVHlf (ORCPT + 99 others); Fri, 22 Oct 2021 03:41:35 -0400 Received: from unicom146.biz-email.net ([210.51.26.146]:48569 "EHLO unicom146.biz-email.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231887AbhJVHle (ORCPT ); Fri, 22 Oct 2021 03:41:34 -0400 Received: from ([60.208.111.195]) by unicom146.biz-email.net ((LNX1044)) with ASMTP (SSL) id PHJ00011; Fri, 22 Oct 2021 15:39:11 +0800 Received: from localhost.localdomain (10.200.104.119) by jtjnmail201604.home.langchao.com (10.100.2.4) with Microsoft SMTP Server id 15.1.2308.14; Fri, 22 Oct 2021 15:39:11 +0800 From: Kai Song To: , CC: , , Kai Song Subject: [PATCH] ACPI: CPPC: fix return value in register_pcc_channel() Date: Fri, 22 Oct 2021 15:39:10 +0800 Message-ID: <20211022073910.14398-1-songkai01@inspur.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.200.104.119] tUid: 202110221539116c8af728a6c594ba2f1525590d3a69cf X-Abuse-Reports-To: service@corp-email.com Abuse-Reports-To: service@corp-email.com X-Complaints-To: service@corp-email.com X-Report-Abuse-To: service@corp-email.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It uses IS_ERR to judge the return value of pcc_mbox_request_channel().If it is invalid, maybe we should use PTR_ERR to get the correct return value. Signed-off-by: Kai Song --- drivers/acpi/cppc_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index bd482108310c..0bbb5fa27ce7 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -503,7 +503,7 @@ static int register_pcc_channel(int pcc_ss_idx) if (IS_ERR(pcc_data[pcc_ss_idx]->pcc_channel)) { pr_err("Failed to find PCC channel for subspace %d\n", pcc_ss_idx); - return -ENODEV; + return PTR_ERR(pcc_data[pcc_ss_idx]->pcc_channel); } /* -- 2.27.0