Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Richard Zhu <hongxing.zhu@nxp.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling
 unbalance when link never came up
Thread-Topic: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling
 unbalance when link never came up
Thread-Index: AQHXwY4ue+QOjCGA8ESB+dHo+5+VOqvUZ7iAgAAAjYCABY9dgIAEuu9Q
Date:   Fri, 22 Oct 2021 08:02:17 +0000
Message-ID: <AS8PR04MB867697359A6D51903D0098308C809@AS8PR04MB8676.eurprd04.prod.outlook.com>
References: <20211015184943.GA2139079@bhelgaas>
 <20211015185141.GA2139462@bhelgaas>
 <AS8PR04MB86767ADAB5021E1C320094148CBD9@AS8PR04MB8676.eurprd04.prod.outlook.com>
In-Reply-To: <AS8PR04MB86767ADAB5021E1C320094148CBD9@AS8PR04MB8676.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sqZIhH8cFDSCZfHkOTA//yY0cWqTQKhsceeVG49L47QexQyo6Oqhlun3bkc6?=
 =?us-ascii?Q?itGt5o9YJKov/vd0M4hDXpTw0eabR3OBmKECJW3zT4Ucz5OBdvvT17cpdZKk?=
 =?us-ascii?Q?nqukc9xHrbFhjZWGQTmfE2Hfy0Vlu9DEYcUfpYi5QmeNBik5rfGoplHkCI93?=
 =?us-ascii?Q?deRhlca/WmBI7LxNI+Bp1hgw2tE+8oKo7ayAfEW/Nc7q+OqnFGCmxKaARayI?=
 =?us-ascii?Q?f4TW+WjE9IZGySr/pcXt9RcGE6XVOLyOY+CsXyb8EdmfbcDWSM7F7u6SWv13?=
 =?us-ascii?Q?crtsJEZfOqF9KmLHWYM/vBN64H2ZHZnANbt60qsL05d2wA/EGrzdHtn/l+0J?=
 =?us-ascii?Q?5xRupdU5gvZDG4A2MKznfLgsV8l+MxyDDaMne54NuT6a+MbinUebgC/DCjDB?=
 =?us-ascii?Q?4m54ANua3bCCfh+wkwio+Ob0msd4ozM1R9HbCJU+GtiGGuwmYz7O/O/PL1Xk?=
 =?us-ascii?Q?1brx4Wn5rCBtFq3Hik5T1erUBISkkYu3JiDWAi5I8o4KfRgybjm12vOPNX2i?=
 =?us-ascii?Q?jsJ+8vDyKpAnl3Eg5ylJ/qlw8Pwk8eDvzbU0axt8LR4fUQK0ZX5j5/pzRfLZ?=
 =?us-ascii?Q?tnL/D2TUuLGwhn06SqHaSE0ypmpMF8GyIyIX/uyJo9ikQuAX4fZPtdV4gOAn?=
 =?us-ascii?Q?DB14Mau/5Q77Lup70X4iS+Pnk6iMqjlEUBLyi3Q3fJkRmDkTa9SV2Cojmdkh?=
 =?us-ascii?Q?Qq5wLJGcPL+Gld/LOWHhWEgaBzUSdvcGpO4ex7ENIiuZqkcwxlAH2d/dBwMc?=
 =?us-ascii?Q?fXQEKfKCZbPVUduP27VEsuY1nVxNwpPsErjjncK+ILWT8hxtETLDNP44Wx/9?=
 =?us-ascii?Q?DhSoI4i2bsclCPhOunw4jwA3YeIkdF88nXutZPA/gJQR6AnDaTStcxUkXnIj?=
 =?us-ascii?Q?6Vv35hXVku7ucnqLLXBhj0I4+nnkb6GPCB0fjgsNl166idNAkzKuLCEHA+VA?=
 =?us-ascii?Q?fVIli0CvC/J6j7TL67nXGQBK7Cd1ntm0OEZrr0jg3vq4PXXo2VHTuJtQ03ml?=
 =?us-ascii?Q?dLzYPE6eZ7ZydYSjVQcniucFfb/Z+Tt/sI/B1BM8KJxjxxIVmBHfyw/JiQEj?=
 =?us-ascii?Q?dtnlgfWxhEGHKzQ/0JMYSPywsIQBoXczUrWZtU+Gpk0Jx8EqzYF7caqFfrUo?=
 =?us-ascii?Q?wa79kEcVh1LjsggM45JJpreFKpKN55EhEZlRWXfele0f8gzgyq3FjlCrk3rl?=
 =?us-ascii?Q?jgMNVx6OoAn0DEIKbdrVRtaqQcb6uLkw8v2HSUHEj/ngjOGQ/cOt/1ylOjXk?=
 =?us-ascii?Q?XaTJrKcyj8B8Ocj9m7ugUcRu1iAiYZqt4UrZo1S37ppK/3pwi6Z9CiexTnUy?=
 =?us-ascii?Q?r+GUJeSg7434wVZ6D5y1kmExnMNVGrnjHJJqqm6FseAKUrVVgmIqOe/13eqb?=
 =?us-ascii?Q?oYte4BmEFd0xwQPWywf0s/GTnLxHBnMC58TQaBhWyrJZnzMag+UPTnpRKnFx?=
 =?us-ascii?Q?hAmFVmc4JPc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d914d962-466f-490d-12e2-08d9953244a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2021 08:02:18.1212
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hongxing.zhu@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8451
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

<snipped ...>
> >
> > > > -static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) -{
> > > > -	clk_disable_unprepare(imx6_pcie->pcie);
> > > > -	clk_disable_unprepare(imx6_pcie->pcie_phy);
> > > > -	clk_disable_unprepare(imx6_pcie->pcie_bus);
> > > > -
> > > > -	switch (imx6_pcie->drvdata->variant) {
> > > > -	case IMX6SX:
> > > > -		clk_disable_unprepare(imx6_pcie->pcie_inbound_axi);
> > > > -		break;
> > > > -	case IMX7D:
> > > > -		regmap_update_bits(imx6_pcie->iomuxc_gpr,
> IOMUXC_GPR12,
> > > > -				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
> > > > -				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL);
> > > > -		break;
> > > > -	case IMX8MQ:
> > > > -		clk_disable_unprepare(imx6_pcie->pcie_aux);
> > > > -		break;
> > > > -	default:
> > > > -		break;
> >
> > While you're at it, this "default: break;" thing is pointless.
> > Normally it's better to just *move* something without changing it at
> > all, but this is such a simple thing I think you could drop this at
> > the same time as the move.
> >
> [Richard Zhu] Okay, got that. Would remove the "default:break" later. Tha=
nks.
[Richard Zhu] I figure out that the default:break is required by IMX6Q/IMX6=
QP.
 So I just don't drop them in v3 patch-set.

>=20
> Best Regards
> Richard Zhu
>=20
> > > > -	}
> > > > -}