Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 3/3] mfd: tps80031: Remove driver
To:     Lee Jones <lee.jones@linaro.org>, Wolfram Sang <wsa@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
        linux-i2c@vger.kernel.org
References: <20211021192258.21968-1-digetx@gmail.com>
 <20211021192258.21968-4-digetx@gmail.com> <YXJw2fX42REHylOy@google.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <b8f6dffb-ec7b-c105-51f1-7b761e331a89@gmail.com>
Date:   Fri, 22 Oct 2021 11:20:45 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YXJw2fX42REHylOy@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

22.10.2021 11:05, Lee Jones пишет:
> On Thu, 21 Oct 2021, Dmitry Osipenko wrote:
> 
>> Driver was upstreamed in 2013 and never got a user, remove it.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  drivers/mfd/Kconfig          |  14 -
>>  drivers/mfd/Makefile         |   1 -
>>  drivers/mfd/tps80031.c       | 526 -----------------------------
>>  include/linux/mfd/tps80031.h | 637 -----------------------------------
>>  4 files changed, 1178 deletions(-)
>>  delete mode 100644 drivers/mfd/tps80031.c
>>  delete mode 100644 include/linux/mfd/tps80031.h
> 
>> -static const struct i2c_device_id tps80031_id_table[] = {
>> -	{ "tps80031", TPS80031 },
>> -	{ "tps80032", TPS80032 },
>> -	{ }
>> -};
> 
> This is an I2C driver, right?
> 
> I was under the impression that Linux could do auto-probing on I2C
> devices?  Such that they do not require platform code or DT in order
> to bind?
> 

It's I2C driver. I'm not sure about auto-probing because something
should provide information about device to Linux. It's possible to
detect/scan whether there is device sitting on I2C address, but there is
no auto-discovery mechanism, AFAIK.

TPS80031 device will fail to bind to this driver because it explicitly
requires platform data which should be NULL if device is probed solely
by I2C ID.