Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RESEND PATCH v6] arm64: dts: qcom: sc7280: Add venus DT node
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Dikshita Agarwal <dikshita@codeaurora.org>
Cc:     andy.gross@linaro.org, david.brown@linaro.org, robh+dt@kernel.org,
        mark.rutland@arm.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        vgarodia@codeaurora.org, stanimir.varbanov@linaro.org,
        Mansur Alisha Shaik <mansur@codeaurora.org>
References: <1632199829-25686-1-git-send-email-dikshita@codeaurora.org>
 <YUpZaQ42ldzEKtV/@builder.lan>
From:   Stanimir Varbanov <stanimir.varbanov@linaro.org>
Message-ID: <68a9da44-b568-85e9-6ec4-28fc8d95633f@linaro.org>
Date:   Fri, 22 Oct 2021 11:31:02 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YUpZaQ42ldzEKtV/@builder.lan>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Dikshita,

On 9/22/21 1:15 AM, Bjorn Andersson wrote:
> On Mon 20 Sep 23:50 CDT 2021, Dikshita Agarwal wrote:
> 
>> Add DT entries for the sc7280 venus encoder/decoder.
>>
>> this patch depends on [1].
>>
>> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=529463

Please drop those two lines above.

> 
> The stuff you write here will be forever imprinted in the git history
> and it's already unnecessary, given that the patch you reference here is
> available in linux-next.
> 
> Things you want to mention, but shouldn't go into the git history, put
> those below the '---' line.
> 
>>
>> Co-developed-by: Mansur Alisha Shaik <mansur@codeaurora.org>
>> Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>
>> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>

I guess this should be :

Co-developed-by: Mansur Alisha Shaik <mansur@codeaurora.org>
Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
Signed-off-by: Dikshita Agarwal <dikshita@codeaurora.org>

but checkpatch --strict should complain about this, no?

>> ---
>>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 75 ++++++++++++++++++++++++++++++++++++
>>  1 file changed, 75 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index a8c274a..f171ababc 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -63,6 +63,11 @@
>>  			no-map;
>>  			reg = <0x0 0x80b00000 0x0 0x100000>;
>>  		};
>> +
>> +		video_mem: memory@8b200000 {
>> +			reg = <0x0 0x8b200000 0x0 0x500000>;
>> +			no-map;
>> +		};
>>  	};
>>  
>>  	cpus {
>> @@ -1063,6 +1068,76 @@
>>  			qcom,bcm-voters = <&apps_bcm_voter>;
>>  		};
>>  
>> +		venus: video-codec@aa00000 {
>> +			compatible = "qcom,sc7280-venus";
> 
> I do however now see this compatible defined in a binding in linux-next,
> so you definitely should have listed that patch as a dependency - and
> preferably held off sending me 6 versions (plus resend) of a patch that
> I can't merge.
> 
> Please ping me once the binding is merged, so that I know when I can
> merge this patch.
Bjorn, the binding is in linux-next now.

-- 
-- 
regards,
Stan