Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 3/3] mfd: tps80031: Remove driver
To:     Wolfram Sang <wsa@kernel.org>, Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
        linux-i2c@vger.kernel.org
References: <20211021192258.21968-1-digetx@gmail.com>
 <20211021192258.21968-4-digetx@gmail.com> <YXJw2fX42REHylOy@google.com>
 <b8f6dffb-ec7b-c105-51f1-7b761e331a89@gmail.com> <YXJ6deXN7vWrSc++@ninjato>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <5c379d93-6940-f68b-2469-03fde8f39702@gmail.com>
Date:   Fri, 22 Oct 2021 11:50:07 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YXJ6deXN7vWrSc++@ninjato>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

22.10.2021 11:46, Wolfram Sang пишет:
> 
>> It's I2C driver. I'm not sure about auto-probing because something
>> should provide information about device to Linux. It's possible to
>> detect/scan whether there is device sitting on I2C address, but there is
>> no auto-discovery mechanism, AFAIK.
> 
> Well, in general, it could be manually instantiated from userspace...
> 
>>
>> TPS80031 device will fail to bind to this driver because it explicitly
>> requires platform data which should be NULL if device is probed solely
>> by I2C ID.
> 
> ..but I agree in this case. The driver has this code:
> 
>         if (!pdata) {
>                 dev_err(&client->dev, "tps80031 requires platform data\n");
>                 return -EINVAL;
>         }
> 
> and git grep shows no user having platform data.
> 
> Shouldn't 'drivers/regulator/tps80031-regulator.c' and
> './rtc/rtc-tps80031.c' be removed as well?
> 

They are removed by the other 2 patches of this series [1].

[1] https://lore.kernel.org/all/20211021192258.21968-1-digetx@gmail.com/