Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1500201pxb; Fri, 22 Oct 2021 02:05:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziEiveYFW28MDdp0LBtcLO2dXPSXcsAPErivFlvtVdbLlW5DcLWwpCJ44BH20UiAxZc0bH X-Received: by 2002:a63:7a4a:: with SMTP id j10mr8268725pgn.284.1634893539035; Fri, 22 Oct 2021 02:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634893539; cv=none; d=google.com; s=arc-20160816; b=NE+XZePfDet58s8wJBDM+4ftv/glqFGGxlHbb3Ln9Fb52PPwmQd8Nkd6RgSNDE3F2S NgjZJ3oW6jgbMro7RP9RuEzEObbZyHpxj80z9aBF43Kq3A3n/aDME5OxmJt77qpCcl16 NqqnK9e3/cINQO1Ua02HRUC0RG9JSW/fxkrN5fvXVCpXyPnSGUHo4Pu+t/1nCUd1NyB8 qva39k+UhtwKCtrC1Ku2Mupn8v9FYw5A80XV7wqKtF3PyTL+pzNkSdL2PBIiZYFPM50x oazO4QkV89D4PHw3vUPaL9yQOE3FRMEnnUvp/dTmJp7Wrb5unovh2mHYnfvZfXHZePma dMVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CeGO65XBV5sMS2KaX+XAtPvytmkhKOWLA32WW5zIiB4=; b=xRNdTnZFyJMbGMWhsVuPg7KEKGh1H9bSXQmrinvnDf6P8z336tWxuXh7eRoC9J/jOl XzKSnkl7IUbynchlRSPVRMn6IUPuHZqxoogBAvWp9ZiMJo5r9+WaB5magHnI/VvF/X+u a2yiD5E0mc8rgfC3+JKTrtyCFTMfcrneotK85LHL/nvQfAkNtlNm4zt8TxHTJxiBMuUC 3GvaWcHb/J1wfQ9yeRKlEZhxk8wdyW2YmFxRclKTrG8PE5LHF8cmE1hO/SrTWYyJZoq7 awUJYraDbZZ6evwSj7kkeT3ktjWrKXFbMmT0Gfh8L+Tlo3FTE5K0pVpyAIZdBIYKqHum gAmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=T25fqf7k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j21si9613750pll.84.2021.10.22.02.05.26; Fri, 22 Oct 2021 02:05:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=T25fqf7k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232552AbhJVJGF (ORCPT + 99 others); Fri, 22 Oct 2021 05:06:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:37812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232532AbhJVJGE (ORCPT ); Fri, 22 Oct 2021 05:06:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 38078610EA; Fri, 22 Oct 2021 09:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634893427; bh=P+ywsJ2Bf8sf28DpGW5jUByITYwueQM+FB+Y2KKGxR0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T25fqf7kExb+0NMwyMFXXxoW+vgqg4v2zUzXpgvr7oV3AEtBdXy0JrW4EOp5NfL57 +OIPMPbtPlL2wdJH5PB7S1ga1aXzaHkK1KUACx9zopTI68lqjlf4yr9CcYEQAuWErb lTSfnUs///IRu1TvVOF7ziHNIXe1AkzEmCLPVyUg= Date: Fri, 22 Oct 2021 11:03:45 +0200 From: Greg Kroah-Hartman To: Cai Huoqing Cc: Nicolas Saenz Julienne , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vchiq_arm: Make use of the helper macro kthread_run() Message-ID: References: <20211021084328.2395-1-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021084328.2395-1-caihuoqing@baidu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 21, 2021 at 04:43:27PM +0800, Cai Huoqing wrote: > Repalce kthread_create/wake_up_process() with kthread_run() > to simplify the code. > > Signed-off-by: Cai Huoqing > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index a5e33da74726..6130b95aaca3 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -1717,15 +1717,12 @@ void vchiq_platform_conn_state_changed(struct vchiq_state *state, > write_unlock_bh(&arm_state->susp_res_lock); > snprintf(threadname, sizeof(threadname), "vchiq-keep/%d", > state->id); > - arm_state->ka_thread = kthread_create(&vchiq_keepalive_thread_func, > - (void *)state, > - threadname); > + arm_state->ka_thread = kthread_run(&vchiq_keepalive_thread_func, > + (void *)state, threadname); > if (IS_ERR(arm_state->ka_thread)) { > vchiq_log_error(vchiq_susp_log_level, > "vchiq: FATAL: couldn't create thread %s", > threadname); > - } else { > - wake_up_process(arm_state->ka_thread); > } > } > As others have pointed out for other busses where you sent this patch, this is _VERY_ racy and probably wrong. Be more careful when sending changes like this that can modify functionality without testing the code. thanks, greg k-h