Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1503548pxb; Fri, 22 Oct 2021 02:10:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxY/prq4q0btTJRJpu5VJwKxwLBF2z/QnfGHoHpmSe1Rf7NHCGw1wm8tN0OWw/Bm4yYin4U X-Received: by 2002:a17:906:11cd:: with SMTP id o13mr14532801eja.208.1634893828282; Fri, 22 Oct 2021 02:10:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634893828; cv=none; d=google.com; s=arc-20160816; b=ayV/q/hRvJmRkBU6ptmUlPu+ZuthivwDYnojuBb/Alj11v5JCU13gyLcokBm0W2Lbh /rNTUzkdaUfvi94FTM665lcF8dxEhN/RbDY/Ict7eUeQ14S8cHU3+AES2ucatVproQ59 myksuHSP7CTJ6BNXxjLbJMni9eyWZw7qn8jaBp2Ek0VLWVzFKE/23WXdU3amdgZfW2Y4 UdHFSj3d+hFsCWFrYJIplhHYD/Bpi5NsA24j9pJnwWEmlIIpL1X+UivHi68brrXMLR9+ ntoFXLuQYqWPSQLn/xz7n/roEYaimRcisAcjW5Lz7krRnWr47utGYUsCq7rpTiFvHwmu 2S0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JadGgm5oD8gm1U4mUOBVEveWdkIkm28HW5yJiKKbNT0=; b=z2g0TorxYM/uoLn5hKakY3nVbLfC0ksPVqZVc+Xuy/Ohu0tfWGzsXDDq5jsUTDnors MRN7rtiZmVtXxu4SJdAcS6txltNWJai85yj4TK7IgENmWm0NwdoSdFrFXdi2yLVVSwL2 Ckn2fYRzalrN9cWZ+PAXs/hdShoAyMXUYMJ2lu+eetS2+z7Z4x+tGfslXoP4+ES2xOJG Ptys8i+g1iDey1v0jiPSNjmsS6Z7oW3LGiVPn5l80PpRhcwy21levxINRQ6gniNxq8Kn 9Dzaqjwp2c7sTm4xVWmboTVEs6cn6iK4EA63z7TXTyK/C636acmga5eLeI/BCaIUshgU ZNWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y9xxuG1u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z11si14917760edc.556.2021.10.22.02.10.04; Fri, 22 Oct 2021 02:10:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y9xxuG1u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232314AbhJVJJ3 (ORCPT + 99 others); Fri, 22 Oct 2021 05:09:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:40832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232060AbhJVJJ2 (ORCPT ); Fri, 22 Oct 2021 05:09:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D8A1660F12; Fri, 22 Oct 2021 09:07:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634893631; bh=C511Ji1funobqNIOfA8ILUgvJjDmfOoWhWOgm02gUls=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y9xxuG1u/piPP4mDYAXsWlwhzcBvsZmVdDUV3jseLJSOavlIOCaukzhg8abWaERJK PmFSeg0aBouwM/KWJCDOCJAv7Aylilt6UkfUIGbOFloN2DcbZQQZoDIGJyeKOx1Zzd quYnEt2Ib26+zd6hYS+xqgsqTJfq+9KTDYhN3aAM= Date: Fri, 22 Oct 2021 11:07:09 +0200 From: Greg KH To: Kai Song Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: Use memdup_user instead of kmalloc/copy_from_user Message-ID: References: <20211022025555.6612-1-songkai01@inspur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211022025555.6612-1-songkai01@inspur.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 22, 2021 at 10:55:55AM +0800, Kai Song wrote: > Use memdup_user helper instead of open-coding to simplify > the code. > > Signed-off-by: Kai Song > --- > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) Someone sent this just before you did, sorry: https://lore.kernel.org/r/20211021122015.6974-1-wanjiabing@vivo.com