Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1546635pxb; Fri, 22 Oct 2021 03:09:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzX021B/PGHRF/NvXMv93BMtRX70NkZyCfZSJLpWT/VFSsvIXhgSOqFKdTqr5ncVYuh76F7 X-Received: by 2002:a05:6a00:2146:b0:44c:2922:8abf with SMTP id o6-20020a056a00214600b0044c29228abfmr11725870pfk.27.1634897360834; Fri, 22 Oct 2021 03:09:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634897360; cv=none; d=google.com; s=arc-20160816; b=VdEJ0DCHPSJaa2CNQpwgwbEHcl8V9v5yLoY6BTKCqYYl9moQAbdFBEGpAt6fKSVmbs HpbjReWYEiG3eh0at9LQ5JT6I8Ui2sJMloGjZkBtgo2jfgC9Vf9V8SjrOi8yNWEY1tG0 Uy7uU+Ik/EdbtiTx6eQlckjmlXnocwxRP0hnkZ2w+7VB0WnD9XzvCy+A83oKMQUhCajR 9R0ynyG9L3OvpQ3WR6GPzEajKphOdKrX7/oYFWM38yWGT1RkUyQZoYPVJNNwPfiXJyAM QIpv2oMMEI9rdBOydo6JyOF+lXGut2lDbRsHJsQzRkHKxhwngGormAIyFFw2dvwQJTOK S9SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=EQTQNbaqeo4/XZKNY13kjX+sBNDCPMWY/kaGUZEWXdk=; b=sbnafzX1QfEZYP0W3o5Zu0Yd43GeLINc+/GQz6laODuLxHd9GJO1pHOlvFlIQKjGAF H45GJRtUma52raY0ohCEtlovJ5OCSK0BTJGC92Uaw/7ynhWpgJwLc/dxXZgGxVrS66v3 9/hL+5+WY3OOG5Msq4r6Xk+VxHWa3FIzJf0uQBnhcM7FuvMU/t1HTScqfZGIeoJtOlJI E7FkJ3i5q/b4ucMzaziCujDxhWli8AdFOzVM8YpnDvoLROn9XkhJNglqf0dhxMI4DQBf PbVpG+lUcc9g9+oDSO2tmbn52KpasMA3NXJ7cBOO4aF9Lt0hXI2/YsTJzNFPD1w1Qrmf QUOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=Y1wO203L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j3si11679237plx.247.2021.10.22.03.09.08; Fri, 22 Oct 2021 03:09:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=Y1wO203L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232552AbhJVKJH (ORCPT + 99 others); Fri, 22 Oct 2021 06:09:07 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:51796 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231944AbhJVKJG (ORCPT ); Fri, 22 Oct 2021 06:09:06 -0400 Received: from Monstersaurus.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B711D2BA; Fri, 22 Oct 2021 12:06:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1634897208; bh=vjGCE1iJEOP6vV6D0o3cwyBykC5jl0LSgHg7NnDh2WE=; h=From:To:Cc:Subject:Date:From; b=Y1wO203LGw6PjdKbkmzC6kZ5Cx/aNu38JaYV83xhlT2yHJOOWtG6KQnlmqNtHczdh Iy83GXud7alkNIXRnppNdcnQR/5ZH1rIcALoBM+Wazi2Yubp3302UkL4CjHOpLsZqd pSAo7FxwxIz3ASxJOI4TJo65dN5i9TzRVw9Cdn1E= From: Kieran Bingham To: linux-media@vger.kernel.org Cc: Kieran Bingham , Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] media: tw5864: Disable PCI device when finished Date: Fri, 22 Oct 2021 11:06:44 +0100 Message-Id: <20211022100644.3447-1-kieran.bingham+renesas@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The cleanup in tw5864_finidev() neglected to disable the PCI device after enabling it in tw5864_initdev(). Call pci_disable_device() after releasing the associated resources. Signed-off-by: Kieran Bingham --- drivers/media/pci/tw5864/tw5864-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/tw5864/tw5864-core.c b/drivers/media/pci/tw5864/tw5864-core.c index fee3b7711901..5cae73e6fb9c 100644 --- a/drivers/media/pci/tw5864/tw5864-core.c +++ b/drivers/media/pci/tw5864/tw5864-core.c @@ -334,6 +334,7 @@ static void tw5864_finidev(struct pci_dev *pci_dev) /* release resources */ iounmap(dev->mmio); pci_release_regions(pci_dev); + pci_disable_device(pci_dev); v4l2_device_unregister(&dev->v4l2_dev); } -- 2.30.2