Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211022073910.14398-1-songkai01@inspur.com>
In-Reply-To: <20211022073910.14398-1-songkai01@inspur.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 22 Oct 2021 14:36:26 +0200
Message-ID: <CAJZ5v0ixPr8WN9hdTtqj1S4XakhH9hJSWJSf9EthdyMEScaOhQ@mail.gmail.com>
Subject: Re: [PATCH] ACPI: CPPC: fix return value in register_pcc_channel()
To:     Kai Song <songkai01@inspur.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 22, 2021 at 9:39 AM Kai Song <songkai01@inspur.com> wrote:
>
> It uses IS_ERR to judge the return value of
> pcc_mbox_request_channel().If it is invalid, maybe we should
> use PTR_ERR to get the correct return value.

Either there is a reason to make this change or there isn't.

If there is a reason, then what is it?

> Signed-off-by: Kai Song <songkai01@inspur.com>
> ---
>  drivers/acpi/cppc_acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index bd482108310c..0bbb5fa27ce7 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -503,7 +503,7 @@ static int register_pcc_channel(int pcc_ss_idx)
>                 if (IS_ERR(pcc_data[pcc_ss_idx]->pcc_channel)) {
>                         pr_err("Failed to find PCC channel for subspace %d\n",
>                                pcc_ss_idx);
> -                       return -ENODEV;
> +                       return PTR_ERR(pcc_data[pcc_ss_idx]->pcc_channel);
>                 }
>
>                 /*
> --
> 2.27.0
>