Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 22 Oct 2021 14:51:18 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
Cc:     kuba@kernel.org, mickeyr@marvell.com, serhiy.pshyk@plvision.eu,
        taras.chornyi@plvision.eu, Volodymyr Mytnyk <vmytnyk@marvell.com>,
        Vadym Kochan <vkochan@marvell.com>,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: marvell: prestera: add firmware v4.0
 support
Message-ID: <YXKzxvyZwsFmRaMf@lunn.ch>
References: <1634722349-23693-1-git-send-email-volodymyr.mytnyk@plvision.eu>
 <YXKuOSDraUsaN75U@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YXKuOSDraUsaN75U@lunn.ch>
Precedence: bulk

On Fri, Oct 22, 2021 at 02:27:37PM +0200, Andrew Lunn wrote:
> On Wed, Oct 20, 2021 at 12:32:28PM +0300, Volodymyr Mytnyk wrote:
> > From: Volodymyr Mytnyk <vmytnyk@marvell.com>
> > 
> > Add firmware (FW) version 4.0 support for Marvell Prestera
> > driver.
> > 
> > Major changes have been made to new v4.0 FW ABI to add support
> > of new features, introduce the stability of the FW ABI and ensure
> > better forward compatibility for the future driver vesrions.
> > 
> > Current v4.0 FW feature set support does not expect any changes
> > to ABI, as it was defined and tested through long period of time.
> > The ABI may be extended in case of new features, but it will not
> > break the backward compatibility.
> > 
> > ABI major changes done in v4.0:
> > - L1 ABI, where MAC and PHY API configuration are split.
> > - ACL has been split to low-level TCAM and Counters ABI
> >   to provide more HW ACL capabilities for future driver
> >   versions.
> > 
> > To support backward support, the addition compatibility layer is
> > required in the driver which will have two different codebase under
> > "if FW-VER elif FW-VER else" conditions that will be removed
> > in the future anyway, So, the idea was to break backward support
> > and focus on more stable FW instead of supporting old version
> > with very minimal and limited set of features/capabilities.
>  
> > +/* TODO: add another parameters here: modes, etc... */
> > +struct prestera_port_phy_config {
> > +	bool admin;
> > +	u32 mode;
> > +	u8 mdix;
> > +};
> 
> > @@ -242,10 +246,44 @@ union prestera_msg_port_param {
> >  	u8  duplex;
> >  	u8  fec;
> >  	u8  fc;
> > -	struct prestera_msg_port_mdix_param mdix;
> > -	struct prestera_msg_port_autoneg_param autoneg;
> > +
> > +	union {
> > +		struct {
> > +			/* TODO: merge it with "mode" */
> 
> > +		struct {
> > +			/* TODO: merge it with "mode" */
> > +			u8 admin:1;
> > +			u8 adv_enable;
> > +			u64 modes;
> > +			/* TODO: merge it with modes */
> > +			u32 mode;
> > +			u8 mdix;
> > +		} phy;

Please can you also make use of __le64, __le32, __le16 in messages
to/from the firmware, so sparse etc can help you catch were you are
missing htonl(), htons() etc.

    Andrew