Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1811426pxb; Fri, 22 Oct 2021 08:07:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOy7O/pYuDxPkJumynI2bCg521m/rel1mmcFt1DTI5U3jWK3z8SFJYzhGIoffXy6UVu02a X-Received: by 2002:a05:6402:cb2:: with SMTP id cn18mr622830edb.249.1634915236210; Fri, 22 Oct 2021 08:07:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634915236; cv=none; d=google.com; s=arc-20160816; b=YgaG43RFMa9aMFOn2CYTiVloSfGw6GgwAmPJoBwo/kDSKglwUNhO6js+SY+zNNZOyy dX1VCPItt5czLfETNPjg7M5hdO/iwn/cMtso1KowoRpV0Zr1I8xoCMh+up0rcNg9CPXD fkCVJbV4i2gkXeJqbY7l5yNSkxmbiIPKdjwb3j63qn3f++EAFSMhDhDPtw5FcvZ/28Nw 63p5mvOb+N1ctJIX+21j77vm7G86NmbQdYG7EqoeGDNUDU6KTgeDDLj1dNgCjJYyziub he207L9EzfFFxmTfYICYaVwn7cY/EbeP8iwAljemQeNqNja6WV2AStkYSFu569JPjz+9 /F3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=3OwTB01Y4l/+kVc73bUX9Z/iYlcMp8gV7w4ueFIx8Ew=; b=sfsMPwqt6U86xh6xbOxgrYYAB29WRuIEKcrBuPMdGEtPnKSB+7spxlecwmfjxY4N5R 5l+IxlfeOSzwNgAxsSaoEQHtFBpWGS/uGbtzcf7msVz1Z9WHOMKCbqGwgnYr0Tq0R1Fi HEI+aUN/I1mx2FfdIINvlqrW7bD09dnm90AdL+sivMnSiFbJK0pdyG990NrcdJkwywCf 69rMBtvMavrtop7bODCPPmnK9dSEkrQc1hjEiKZzPN4n+pcEQoL2LH5diy0vLyKOrWYr +sMnGWmA8+LF+10zClcHTKAnTfVYJsiBFD5XdlGkuBsTBG3k5r8S7pDzUrUAFt0QOClp RjCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@brainfault-org.20210112.gappssmtp.com header.s=20210112 header.b=wpSkuuN+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qb24si17005230ejc.558.2021.10.22.08.06.50; Fri, 22 Oct 2021 08:07:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@brainfault-org.20210112.gappssmtp.com header.s=20210112 header.b=wpSkuuN+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233280AbhJVPFX (ORCPT + 99 others); Fri, 22 Oct 2021 11:05:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233266AbhJVPFV (ORCPT ); Fri, 22 Oct 2021 11:05:21 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26046C061348 for ; Fri, 22 Oct 2021 08:03:04 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id v17so1179510wrv.9 for ; Fri, 22 Oct 2021 08:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3OwTB01Y4l/+kVc73bUX9Z/iYlcMp8gV7w4ueFIx8Ew=; b=wpSkuuN+E/3s4nGjBtt7p0E+89MzWCY9gMhvKz1Ef14MYys7krAIIthKGELpKTeuFk EpEzaOOtyERbGHOhnsembwGIFJlYjt5HVbHDton9+1RHtWbxoaITSkLIz0Kt7EjjjC8J pNe4gvOoH4qtoMDeBHIZ8ReIUfDiQFSikDCY6r/d/bJXnxJdRgd1/mU8m7NnyFK+1voW 82rIb+FkSGT7XfptFXc2QjTey0N78CVh1PNSnL5cCFi+3VBkogj6aoyqPL/MIUAiJc1K s/W2WkxFBjsfrs4WJnOORyd83lN5UWWWljCUYFHNyaV9WATYUTXDNA563tvvjDAxqEF1 /uZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3OwTB01Y4l/+kVc73bUX9Z/iYlcMp8gV7w4ueFIx8Ew=; b=cQUBGZiVPO7M0MSLTSvk0wYjMDi02aiIjw9xhcog7JeOWP6xE7InPrcbEYS+TJIOJf X8KYenBZue0EcjWwrb+17xy0tE+LGQMh2Q+iBaPXUDGL+xmIbBXXki3ZzbRoEWzXqLTb If/zDipn97sJ5nkV+TaURt23T6rGatNSJ48mNgHbAPNCu2SUncFGMPZuoYxptXP7juaN GI7N56+7ztyUAHKVBqGcFrm4x5AK3CKXVH2I4ufXlHR89m3ieN9NotHpWDvuZYD9yhE5 R1jGobhQjN+OojcYmOWXwU16EYPpn4rs3YPQGhpow0RKweKMuMnZ28wcKVynEnoN+a3e PdbA== X-Gm-Message-State: AOAM533qUeDGRhR3AlV4ChsLhiIenPCkZiJ39zvEOk174EQV2lrNp725 W5bwvrVX/uDuvs7JWIzNjHSAYshzXMHdADmhngTlGQ== X-Received: by 2002:a05:6000:1acc:: with SMTP id i12mr431822wry.249.1634914981152; Fri, 22 Oct 2021 08:03:01 -0700 (PDT) MIME-Version: 1.0 References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-10-seanjc@google.com> In-Reply-To: <20211009021236.4122790-10-seanjc@google.com> From: Anup Patel Date: Fri, 22 Oct 2021 20:32:49 +0530 Message-ID: Subject: Re: [PATCH v2 09/43] KVM: Drop obsolete kvm_arch_vcpu_block_finish() To: Sean Christopherson Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Paolo Bonzini , Wanpeng Li , KVM General , David Hildenbrand , "linux-kernel@vger.kernel.org List" , Atish Patra , linux-riscv , Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Joerg Roedel , kvm-ppc@vger.kernel.org, David Matlack , linux-arm-kernel , Jim Mattson , Cornelia Huck , linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, Vitaly Kuznetsov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 9, 2021 at 7:43 AM Sean Christopherson wrote: > > Drop kvm_arch_vcpu_block_finish() now that all arch implementations are > nops. > > No functional change intended. > > Acked-by: Christian Borntraeger > Reviewed-by: David Matlack > Signed-off-by: Sean Christopherson For KVM RISC-V: Acked-by: Anup Patel Reviewed-by: Anup Patel Regards, Anup > --- > arch/arm64/include/asm/kvm_host.h | 1 - > arch/mips/include/asm/kvm_host.h | 1 - > arch/powerpc/include/asm/kvm_host.h | 1 - > arch/riscv/include/asm/kvm_host.h | 1 - > arch/s390/include/asm/kvm_host.h | 2 -- > arch/s390/kvm/kvm-s390.c | 5 ----- > arch/x86/include/asm/kvm_host.h | 2 -- > virt/kvm/kvm_main.c | 1 - > 8 files changed, 14 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 369c30e28301..fe4dec96d1c3 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -716,7 +716,6 @@ void kvm_arm_vcpu_ptrauth_trap(struct kvm_vcpu *vcpu); > static inline void kvm_arch_hardware_unsetup(void) {} > static inline void kvm_arch_sync_events(struct kvm *kvm) {} > static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} > -static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > > void kvm_arm_init_debug(void); > void kvm_arm_vcpu_init_debug(struct kvm_vcpu *vcpu); > diff --git a/arch/mips/include/asm/kvm_host.h b/arch/mips/include/asm/kvm_host.h > index 696f6b009377..72b90d45a46e 100644 > --- a/arch/mips/include/asm/kvm_host.h > +++ b/arch/mips/include/asm/kvm_host.h > @@ -897,7 +897,6 @@ static inline void kvm_arch_memslots_updated(struct kvm *kvm, u64 gen) {} > static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} > static inline void kvm_arch_vcpu_blocking(struct kvm_vcpu *vcpu) {} > static inline void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu) {} > -static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > > #define __KVM_HAVE_ARCH_FLUSH_REMOTE_TLB > int kvm_arch_flush_remote_tlb(struct kvm *kvm); > diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h > index 876c10803cda..4a195c161592 100644 > --- a/arch/powerpc/include/asm/kvm_host.h > +++ b/arch/powerpc/include/asm/kvm_host.h > @@ -865,6 +865,5 @@ static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} > static inline void kvm_arch_exit(void) {} > static inline void kvm_arch_vcpu_blocking(struct kvm_vcpu *vcpu) {} > static inline void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu) {} > -static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > > #endif /* __POWERPC_KVM_HOST_H__ */ > diff --git a/arch/riscv/include/asm/kvm_host.h b/arch/riscv/include/asm/kvm_host.h > index d7e1696cd2ec..b3f0c3773603 100644 > --- a/arch/riscv/include/asm/kvm_host.h > +++ b/arch/riscv/include/asm/kvm_host.h > @@ -209,7 +209,6 @@ struct kvm_vcpu_arch { > static inline void kvm_arch_hardware_unsetup(void) {} > static inline void kvm_arch_sync_events(struct kvm *kvm) {} > static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} > -static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > > #define KVM_ARCH_WANT_MMU_NOTIFIER > > diff --git a/arch/s390/include/asm/kvm_host.h b/arch/s390/include/asm/kvm_host.h > index a604d51acfc8..a22c9266ea05 100644 > --- a/arch/s390/include/asm/kvm_host.h > +++ b/arch/s390/include/asm/kvm_host.h > @@ -1010,6 +1010,4 @@ static inline void kvm_arch_flush_shadow_memslot(struct kvm *kvm, > static inline void kvm_arch_vcpu_blocking(struct kvm_vcpu *vcpu) {} > static inline void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu) {} > > -void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu); > - > #endif > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index 08ed68639a21..17fabb260c35 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -5080,11 +5080,6 @@ static inline unsigned long nonhyp_mask(int i) > return 0x0000ffffffffffffUL >> (nonhyp_fai << 4); > } > > -void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) > -{ > - > -} > - > static int __init kvm_s390_init(void) > { > int i; > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 88f0326c184a..7aafc27ce7a9 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -1926,8 +1926,6 @@ static inline void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu) > static_call_cond(kvm_x86_vcpu_unblocking)(vcpu); > } > > -static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > - > static inline int kvm_cpu_get_apicid(int mps_cpu) > { > #ifdef CONFIG_X86_LOCAL_APIC > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 1292c7876d3f..f90b3ed05628 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -3304,7 +3304,6 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu) > } > > trace_kvm_vcpu_wakeup(block_ns, waited, vcpu_valid_wakeup(vcpu)); > - kvm_arch_vcpu_block_finish(vcpu); > } > EXPORT_SYMBOL_GPL(kvm_vcpu_block); > > -- > 2.33.0.882.g93a45727a2-goog > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm