Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1815487pxb; Fri, 22 Oct 2021 08:11:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2jCSFE3jdydlip5ftkJXD84OYAYbraV/elglgGXF9MmYrH5F/bMiB/I+b8f7n1Uwvj7ss X-Received: by 2002:a05:6402:4304:: with SMTP id m4mr723191edc.326.1634915481744; Fri, 22 Oct 2021 08:11:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634915481; cv=none; d=google.com; s=arc-20160816; b=a9QEfCamjQwBXl//btUxPGrR0S1CCIafat4FH+rG1HoXUruoGyawjM7gSNb6RH6uDF NYtcwqPQa5UaR2FxuZk79fq62eiDPs0OJ9ruC8hc2rQupipMPP3p3nO0025iC0g+nxG+ 2t+b4voEyIi5k3asuLLmcrLO55Ww+izTP/fx4sThAnDnH2vCR6tigS4jO5he83M4zz9p 3/gcIOWjI5+DyMQYmDeYmWQvkyaNgf34ney9Gk8ZBnfUPeY262qpDPfAtjkVIX5nusAA 01HeVjdXa4A239GbSZCj5cEsaRmXUEy2qeVvoE9GZ4X/o2WH4yXo1DmdEAHt81hdp4br P5UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=OOPVdOZuDE9LduKorBQE6wRCWdsMo7E1T1y8FUUzpm4=; b=LOLtpxVxaYaRg+ECnIZRi4wV+br9zhlrl1pmbm4cqRCAEUWLlxIZmnpi68DVaynoCo P6AI8ySMDx9yTF6maBrHPMMHtQwvIpLUkl6Bwlnm6UwZHeLIATW9k4ugyOze2xzetgEx G7zC2y0Z97q8ocYVbgCgTFEzwGe3VCHb4fcK/MLFXgnSQf4VpvsPlVZwu9np9yahj3JY UYNqsmgbyUZ17W2zesm3nPrijQcWGn+wGywVcW3METGkry1Ao/j9RkjbkprdV8nkUhsJ 0g0VmWg+ClSaLCWmcnKGJdiVo4dcdSvfbdmpr4ifDv2rAr1k5mcnQRD3KzaA3laxA1eX ulKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cq21si11206867ejc.236.2021.10.22.08.10.57; Fri, 22 Oct 2021 08:11:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233328AbhJVPI2 (ORCPT + 99 others); Fri, 22 Oct 2021 11:08:28 -0400 Received: from foss.arm.com ([217.140.110.172]:55466 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233332AbhJVPIV (ORCPT ); Fri, 22 Oct 2021 11:08:21 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B4CAA1FB; Fri, 22 Oct 2021 08:06:03 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.73.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C49FE3F694; Fri, 22 Oct 2021 08:05:58 -0700 (PDT) Date: Fri, 22 Oct 2021 16:05:55 +0100 From: Mark Rutland To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org, paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, torvalds@linux-foundation.org, tsbogend@alpha.franken.de, vgupta@kernel.org, will@kernel.org Subject: Re: [PATCH 04/15] irq: simplify handle_domain_{irq,nmi}() Message-ID: <20211022150555.GB86184@C02TD0UTHF1T.local> References: <20211021180236.37428-1-mark.rutland@arm.com> <20211021180236.37428-5-mark.rutland@arm.com> <87lf2lbac3.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lf2lbac3.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 22, 2021 at 11:52:28AM +0100, Marc Zyngier wrote: > On Thu, 21 Oct 2021 19:02:25 +0100, > Mark Rutland wrote: > > > > There's no need for handle_domain_{irq,nmi}() to open-code the NULL > > check performed by handle_irq_desc(), nor the resolution of the desc > > performed by generic_handle_domain_irq(). > > > > Use generic_handle_domain_irq() directly, as this is functioanlly > > equivalent and clearer. At the same time, delete the stale comments, > > which are no longer helpful. > > > > There should be no functional change as a result of this patch. > > > > Signed-off-by: Mark Rutland > > Cc: Marc Zyngier > > Cc: Thomas Gleixner > > --- > > kernel/irq/irqdesc.c | 24 ++++-------------------- > > 1 file changed, 4 insertions(+), 20 deletions(-) > Yup, that's really neat. I somehow missed that when I moved some of > the legacy stuff to be ARM specific. > > On a vaguely related note, I think you can drop the EXPORT_SYMBOL_GPL > on handle_irq_desc() now. Seems so: [mark@lakrids:~/src/linux]% git grep -w handle_irq_desc arch/arm/kernel/irq.c: handle_irq_desc(desc); include/linux/irqdesc.h:int handle_irq_desc(struct irq_desc *desc); kernel/irq/irqdesc.c:int handle_irq_desc(struct irq_desc *desc) kernel/irq/irqdesc.c: return handle_irq_desc(irq_to_desc(irq)); kernel/irq/irqdesc.c: return handle_irq_desc(irq_resolve_mapping(domain, hwirq)); I'll add a patch to clean that up. Thanks, Mark