Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1822945pxb; Fri, 22 Oct 2021 08:18:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7XHfmB3BJK32/tUmWAsdwXc5PameCnTNx1fNzZQXjkNI+jU6EhttyZ8zoiAwGudu58g8r X-Received: by 2002:a05:6402:5188:: with SMTP id q8mr764325edd.332.1634915937612; Fri, 22 Oct 2021 08:18:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634915937; cv=none; d=google.com; s=arc-20160816; b=oeY3CHqQb0IOPez6yvAgKusuGkhuM4o/ahdr2frKHRIaDxswi6CGI/2bppVOxWIxfb dhTeI/Z/QPXYkiL4WikckV9Q3lDb8Vmrzq0cX02hrxaZlrOdDpi+lrz8Tq3oiPM794OE QZRaCIvegntl7jcl0kLVp8NRdAudRUS8MFXV+jXim4UTys6jCjTJE1Zpzrfteozb/s69 DP+spC02bUODQpkzjFcTRP8I0Po4ZwvP4DWzdbqvs0l94UXmPCSuy/smGON8I3RfIn+N rcCiIw53chDz7INW8RltvGaKuTNFj7DRy8k5ncpirj0KdADJFB8WMREJvEhJIO0Ft+0W 1tDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=ANjxMyzEaBerOwzLK0Q3RxHvXsNIIMRJZ4VhyjUE2w8=; b=mVY7G0ZpUwTspPsLvDAvXurqQ38a4PNbeMxbC8EqmgOrXLQxhmRwSNK+oHwWChBnjy 1Hk6sfeYnqWWGhFOAP11rE19SlSZXOmoguOfVz/Ru2meddzkj/hbgsMG3ZljQY2BMS6I NdnfO6i3WEkId0m2rpr7mKXOZ4ofr3omlAtFkPsVV//mCfNgF/9SJFJnwDGHZko06+/W I8GlrwJ2Va+QBItIdpkWR4gfR2eOjqhwwzgqI9/R/xoRCRd/7R4DPrE7CkfF1wJm/EYl UELt9n+VaSyDQb++02ug6HCO7Inb79BV+u/Hp4wqf8X0dXiFkZj1rAIhY4cL6xNIJtoa iujA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Um61NSl9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do4si17700582ejc.579.2021.10.22.08.18.33; Fri, 22 Oct 2021 08:18:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Um61NSl9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233268AbhJVPSv (ORCPT + 99 others); Fri, 22 Oct 2021 11:18:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233181AbhJVPSp (ORCPT ); Fri, 22 Oct 2021 11:18:45 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B74BDC061764 for ; Fri, 22 Oct 2021 08:16:27 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id w12-20020a056830410c00b0054e7ceecd88so4802316ott.2 for ; Fri, 22 Oct 2021 08:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=ANjxMyzEaBerOwzLK0Q3RxHvXsNIIMRJZ4VhyjUE2w8=; b=Um61NSl9XZjxdivHLbY9cyH91To30EM1MV27+M0ag4zCerhQSBBvzx1BRSBoHD6Vu7 NJy+RmfZJ7bdbaMjkyaUbT2mKri6WdrUNzA/5s1Ab25uWmeNmfEqRa6CoZMRzcv4pAnW GqG4yWcCLcl+b1P6/mXuBprj0JiQzSfEfm7op605Qg+C4BnrvkZthiuK4P+Hh6YBev+i S+LHJUy3hnl+GrLAfnleLK8RjDegxB6WzfRslI1sEu4869lFJcADzxfcTFz23+dxroRV OaX1gIYVqHHhZ1Vvejvi5Wkow+QtUwGJ16Cg6KHA2PwABXN5QvlxxcWk2uN7/lAtlV4y r3dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=ANjxMyzEaBerOwzLK0Q3RxHvXsNIIMRJZ4VhyjUE2w8=; b=r5I7SiDgYoTgnbwi+K+NmEGBIir6cOFQmS+kyucSrcYw84XzQXIXWg7rUSiQOTnIhT lWtjTuD9yWKH3xxptiA9Cj4HD86MpO7Mx8LdFPBGpJNLrNvE4diJPyQeWOI35C/u4/oQ ZftSPSDE1Hon+gs6PWHGXrcSJhEeRgKAC1fSsWemakOu2zHlqm/dHjbdL9kMCEbntk7J ness/Hh9TwY96xfe1o9I9a2JKAduYJRlaAxRfmc/wbmbhn0aqZ/IRgeMx3lLVdrcpcMg SJ/1r3Bid9sGdBMRxcYi6GTXbMOsVdu9TZhEmSER+oJCnqi95CgQCnVIvnJ5Vq+X+jfN VtTQ== X-Gm-Message-State: AOAM53205vMOlYY7787sGTg2M5wh4O+qwbwZOio3E9LfaehwZ48hI0JE 3+JIkbEZwVwqrlD36F8atJzHQA== X-Received: by 2002:a9d:7644:: with SMTP id o4mr397173otl.270.1634915786523; Fri, 22 Oct 2021 08:16:26 -0700 (PDT) Received: from [127.0.1.1] (rrcs-24-173-18-66.sw.biz.rr.com. [24.173.18.66]) by smtp.gmail.com with ESMTPSA id y5sm1733409otg.52.2021.10.22.08.16.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 08:16:26 -0700 (PDT) From: Jens Axboe To: John Garry Cc: ming.lei@redhat.com, anders.roxell@linaro.org, naresh.kamboju@linaro.org, linux-block@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org In-Reply-To: <1634890340-15432-1-git-send-email-john.garry@huawei.com> References: <1634890340-15432-1-git-send-email-john.garry@huawei.com> Subject: Re: [PATCH] blk-mq-sched: Don't reference queue tagset in blk_mq_sched_tags_teardown() Message-Id: <163491578487.92334.5273496329606212281.b4-ty@kernel.dk> Date: Fri, 22 Oct 2021 09:16:24 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Oct 2021 16:12:20 +0800, John Garry wrote: > We should not reference the queue tagset in blk_mq_sched_tags_teardown() > (see function comment) for the blk-mq flags, so use the passed flags > instead. > > This solves a use-after-free, similarly fixed earlier (and since broken > again) in commit f0c1c4d2864e ("blk-mq: fix use-after-free in > blk_mq_exit_sched"). > > [...] Applied, thanks! [1/1] blk-mq-sched: Don't reference queue tagset in blk_mq_sched_tags_teardown() commit: 8bdf7b3fe1f48a2c1c212d4685903bba01409c0e Best regards, -- Jens Axboe