Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1825434pxb; Fri, 22 Oct 2021 08:21:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwew1Qm9MKGgAWSyfnWAwrfAes9agW0roREqdqKPKVTnD86xUzarAXiCP1Wz/zxwUSBy8w6 X-Received: by 2002:a17:907:e8b:: with SMTP id ho11mr280835ejc.148.1634916100942; Fri, 22 Oct 2021 08:21:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634916100; cv=none; d=google.com; s=arc-20160816; b=RNZzjGfv6qI44bSzrXW94RXP8de8WFX+rdcQK4wv/tu0bMh5Kku5I8mUkApvpZdBaI UhXkKAEz5lLCP8u25fBC+5Jz5Z+H9V4FPL0izWHhp1uLGv358uW/KKkqg2Owyu2ZDYpU vMY9/kSe7o29jv4j+yXMgddTUgQ7OL9U/dOr9tPaisTAwuCXG8KtKDGIA0dB2wk8pxD5 fUJYcXc+9OcWQz3W5Rrncqu/ZFS929YbxDTY0JUn6uxxJhiiZbw8LhRu4qxGoRG7TKRR AgWNVxEcemeIM2YR4StMSt1hRDg2XWjBVexePIr5ltMUE386q6vFddzHKDwRrOuCDPyz YuoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=+iGdVI9981VXoJ/yoHzazHLZSfwfCzt3ObQ6p88vklU=; b=KdLQWm/XZi+8Ob6ZgvOu9uJBZTxElVRAuek4noK+ljEUtu2qoTwSmje06NvD4/3gLc aSDOzH63AOarOO5fXHdfvTSvA2/zFN1teDLLzZVp1mRLJTxWOBtFSn936B+MsX0CqLjj PidGeNxd2dXtf3uZjWuMT0tK1UxjOL2mUz1s9WZW7plnjaQdlDhwOQIqUCCArtjDl5io Aw/ulFyvihd3yJH1r/2VbOdi6MXbdxt0x4z97SHmhLUnNXXmN3iP5n6Cvnz0xNeNy7cy 3fYb1kRpALM7RLfziBv9HVVvz4JF+v68oTfGZ8sp38bMUKS8hTYhXbh+/jrI3g80Yiye LEwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r20si12238467edd.587.2021.10.22.08.21.17; Fri, 22 Oct 2021 08:21:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233343AbhJVPUl (ORCPT + 99 others); Fri, 22 Oct 2021 11:20:41 -0400 Received: from foss.arm.com ([217.140.110.172]:55776 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232384AbhJVPUk (ORCPT ); Fri, 22 Oct 2021 11:20:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B48BB1FB; Fri, 22 Oct 2021 08:18:22 -0700 (PDT) Received: from [10.57.20.104] (unknown [10.57.20.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6C5E3F694; Fri, 22 Oct 2021 08:18:18 -0700 (PDT) Subject: Re: [PATCH 09/15] irq: arm: perform irqentry in entry code To: Mark Rutland , linux-kernel@vger.kernel.org Cc: aou@eecs.berkeley.edu, catalin.marinas@arm.com, deanbo422@gmail.com, green.hu@gmail.com, guoren@kernel.org, jonas@southpole.se, kernelfans@gmail.com, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, maz@kernel.org, nickhu@andestech.com, palmer@dabbelt.com, paulmck@kernel.org, paul.walmsley@sifive.com, peterz@infradead.org, shorne@gmail.com, stefan.kristiansson@saunalahti.fi, tglx@linutronix.de, torvalds@linux-foundation.org, tsbogend@alpha.franken.de, vgupta@kernel.org, will@kernel.org References: <20211021180236.37428-1-mark.rutland@arm.com> <20211021180236.37428-10-mark.rutland@arm.com> From: Vladimir Murzin Message-ID: <0efc4465-12b5-a568-0228-c744ec0509a3@arm.com> Date: Fri, 22 Oct 2021 16:18:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20211021180236.37428-10-mark.rutland@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 10/21/21 7:02 PM, Mark Rutland wrote: > +/* > + * TODO: restructure the ARMv7M entry logic so that this entry logic can live > + * in arch code. > + */ > +asmlinkage void __exception_irq_entry > +static void nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) I'm seeing build time failure... drivers/irqchip/irq-nvic.c:50:8: error: two or more data types in declaration specifiers static void nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) ^~~~ drivers/irqchip/irq-nvic.c:50:13: warning: 'nvic_handle_irq' defined but not used [-Wunused-function] static void nvic_handle_irq(irq_hw_number_t hwirq, struct pt_regs *regs) I've fixed that locally and planing to give it a go... Cheers Vladimir