Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4354b890-28df-6f0e-d206-9b31307e48dd@gmail.com>
Date:   Fri, 22 Oct 2021 22:48:50 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v3] staging: rtl8723bs: os_dep: simplify the return
 statement
Content-Language: en-GB
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
        ross.schm.dev@gmail.com, marcocesati@gmail.com,
        insafonov@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Cc:     saurav.girepunje@hotmail.com
References: <YWhBQF4yUH0/r53A@Sauravs-MacBook-Air.local>
 <13289545.LovHZTAFgE@localhost.localdomain>
From:   Saurav Girepunje <saurav.girepunje@gmail.com>
In-Reply-To: <13289545.LovHZTAFgE@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 15/10/21 2:45 pm, Fabio M. De Francesco wrote:
> On Thursday, October 14, 2021 4:40:00 PM CEST Saurav Girepunje wrote:
>> Remove goto statement where function simply return value without doing
>> any cleanup action.
>>
>> Simplify the return using goto label to avoid unneeded 'if' condition
>> check.
>>
>> Remove the unneeded and redundant check of variable on goto.
>>
>> Remove the assignment of NULL on local variable.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>>
>> ChangeLog V3:
>>
>> 	-Remove goto statement where function simply return value
>> 	 without doing any cleanup action.
>> 	-Remove the assignment of NULL on local variable.
>> 	-Replace the goto statement added after the memcpy on V2.
>> 	 with return 0 statement.
>>
>> ChangeLog V2:
>>
>> 	-Add goto out after the memcpy for no error case return with
>> 	 ret only. On V1 doing free, which was not required for no error
>> 	 case.
> 
> You still don't explain why you changed v1. You had freed resources on 
> success path. 
"On V1 doing free" I will add more information on changelog.
That was not allowed because you introduced a change in the 
> logic and a huge bug. Therefore, in v2, you are not merely changing something 
> that "was not required". Instead you are changing something that is not 
> permitted.
> 
> Thanks,
> 
> Fabio
> 
> 
> 
Thanks Fabio for review.

Regards,
Saurav