Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 22 Oct 2021 15:22:47 -0400
From:   Dennis Zhou <dennis@kernel.org>
To:     Pavel Begunkov <asml.silence@gmail.com>
Cc:     Dennis Zhou <dennis@kernel.org>, linux-block@vger.kernel.org,
        Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
        Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2 1/2] percpu_ref: percpu_ref_tryget_live() version
 holding RCU
Message-ID: <YXMPh4jZ0dr6EFqX@fedora>
References: <cover.1634822969.git.asml.silence@gmail.com>
 <3066500d7a6eb3e03f10adf98b87fdb3b1c49db8.1634822969.git.asml.silence@gmail.com>
 <YXFytAdeF5RPRERf@fedora>
 <cdf7c768-47ad-78c4-a22a-f0f1a435b6f6@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cdf7c768-47ad-78c4-a22a-f0f1a435b6f6@gmail.com>
Precedence: bulk

On Fri, Oct 22, 2021 at 10:22:30AM +0100, Pavel Begunkov wrote:
> On 10/21/21 15:01, Dennis Zhou wrote:
> > Hello,
> > 
> > On Thu, Oct 21, 2021 at 02:30:51PM +0100, Pavel Begunkov wrote:
> > > Add percpu_ref_tryget_live_rcu(), which is a version of
> > > percpu_ref_tryget_live() but the user is responsible for enclosing it in
> > > a RCU read lock section.
> > > 
> > > Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> > > ---
> > >   include/linux/percpu-refcount.h | 33 +++++++++++++++++++++++----------
> > >   1 file changed, 23 insertions(+), 10 deletions(-)
> > > 
> [...]
> > > +
> > >   /**
> > >    * percpu_ref_tryget_live - try to increment a live percpu refcount
> > >    * @ref: percpu_ref to try-get
> > 
> > Nit: it's dumb convention at this point, but do you mind copying this
> > guy up. I like consistency.
> 
> Looks Jens already took it. If you still want it moved, do you mind
> it in a separate patch?
> 
> And I'm not sure I follow where you want it to be, currently it's
> right before percpu_ref_tryget_live, which uses it.

Don't worry about it. I meant the @ref comment line. Honestly it's not
really useful, it's just every other header block has that convention
among most of percpu related files.

If I have to make any changes in the future, I'll clean it up then.

Thanks,
Dennis

> 
> -- 
> Pavel Begunkov