Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 22 Oct 2021 16:10:48 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Li Zhijian <lizhijian@cn.fujitsu.com>
Cc:     dave@stgolabs.net, josh@joshtriplett.org, rostedt@goodmis.org,
        mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
        joel@joelfernandes.org, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] refscale: simplify the errexit checkpoint
Message-ID: <20211022231048.GF880162@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20211022105111.29455-1-lizhijian@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211022105111.29455-1-lizhijian@cn.fujitsu.com>
Precedence: bulk

On Fri, Oct 22, 2021 at 06:51:10PM +0800, Li Zhijian wrote:
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>

Good catch!

But given that errexit is only set once at the beginning, why not
eliminate this local variable in favor of a goto at the point that it
is currently assigned to?  That would permit further simplification.

							Thanx, Paul

> ---
>  kernel/rcu/refscale.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/kernel/rcu/refscale.c b/kernel/rcu/refscale.c
> index 66dc14cf5687..2cbe2a2ba387 100644
> --- a/kernel/rcu/refscale.c
> +++ b/kernel/rcu/refscale.c
> @@ -698,26 +698,25 @@ static int main_func(void *arg)
>  	// Print the average of all experiments
>  	SCALEOUT("END OF TEST. Calculating average duration per loop (nanoseconds)...\n");
>  
> -	if (!errexit) {
> -		buf[0] = 0;
> -		strcat(buf, "\n");
> -		strcat(buf, "Runs\tTime(ns)\n");
> -	}
> +	if (errexit)
> +		goto err;
> +
> +	buf[0] = 0;
> +	strcat(buf, "\n");
> +	strcat(buf, "Runs\tTime(ns)\n");
>  
>  	for (exp = 0; exp < nruns; exp++) {
>  		u64 avg;
>  		u32 rem;
>  
> -		if (errexit)
> -			break;
>  		avg = div_u64_rem(result_avg[exp], 1000, &rem);
>  		sprintf(buf1, "%d\t%llu.%03u\n", exp + 1, avg, rem);
>  		strcat(buf, buf1);
>  	}
>  
> -	if (!errexit)
> -		SCALEOUT("%s", buf);
> +	SCALEOUT("%s", buf);
>  
> +err:
>  	// This will shutdown everything including us.
>  	if (shutdown) {
>  		shutdown_start = 1;
> -- 
> 2.33.0
> 
> 
>