Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <cb85b8a6-b82f-3054-5d76-57af018d6b2a@oracle.com>
Date:   Fri, 22 Oct 2021 16:26:59 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.0
Subject: Re: [PATCH v2] mm: Optimise put_pages_list()
Content-Language: en-US
To:     "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@techsingularity.net>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20211007192138.561673-1-willy@infradead.org>
From:   Anthony Yznaga <anthony.yznaga@oracle.com>
In-Reply-To: <20211007192138.561673-1-willy@infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1gweGY5dEsyR2YvU3ZmTllVSlVqMVc5UUpXaGgrUEY4N3c5VDVLRVh2dDVF?=
 =?utf-8?B?STZiaWpEcllGbUYrcGZod3NnR1N4dCt6c0FzMUtyY3NGNVNSanF1elJhbjhC?=
 =?utf-8?B?VkMyWTBnWXhvaEpCSnVSbFF0RGdHMlgybk45a1FTcXpSNjEvTmVxVzZqNk4z?=
 =?utf-8?B?ZFhyQm4yWVg5MjlsMVp3b3h0anIxTjU3TWZoUkFWYmUxNW9KNGJsSXA4bjM4?=
 =?utf-8?B?ZXV0RWd1dXhyTG9IRmYvMkhOcjJtdWpLZUlNVGZrUUNjaWt6Njd4bVYvWlZJ?=
 =?utf-8?B?VlhxV3Z2V2VaWWEyVGZ3cjNNZzJxWDlpN21HMGZSblFaSXNnZEVneStxOExJ?=
 =?utf-8?B?RUJjS2tNRDZuaVJiUy9oQ0FxbVppSU5SM0lnUUtBV2luMGFVd1dJUmMvNnBM?=
 =?utf-8?B?UldxVHJmajIrNVJ3T2hVazVzZFVHdWpMQ3NaL0NQK203cFpnZnhYa2RLV01K?=
 =?utf-8?B?d0NRcndUclkvTHZJZGlLVzdwb21KeDhBdHdpdmc4VkFNT2NJdk1mcUEwR25K?=
 =?utf-8?B?dkxiYU02Q01LcTB4eC80aUcwbXF3YnhiYWxhcjMzZ281N0diN0RuZWZJdW9i?=
 =?utf-8?B?NytVbU5UdXhvMXUvNHNwSXdkMnFQdllVcG5OcUtOamdaMytWVXg2K2ZzRVl3?=
 =?utf-8?B?YlJxVUJ3RHNZeTlaSjlOVWxIZ1FDT2VsdUd2QjQ2V3h4Y1AzSjRUZVFLa09X?=
 =?utf-8?B?cXM5eTJyR0xCL2QvN2tqbEV5WnBjZVQwdzl5Q2NzVUZDa0NlZmlTMFg1N2FX?=
 =?utf-8?B?Z0pHbjhoU1Mxd2ZOUnV4Zlc5S2t1dTRraTkyL2d5VHVSRXFtclNLeSs3S0Jn?=
 =?utf-8?B?N01ycWl0b3VGWGhtZnFaR082ZisrNSszQ2JhUS9iRldmVG11RjhlQTJsSjg3?=
 =?utf-8?B?NGxoMGJrWUpadFl2UzBKUEYwOWUwVXIvVEJuUTFTU0h1Y1VuWGk1MDJpUU5L?=
 =?utf-8?B?UXBCZG9SOXJhV0hFNWlNT2ZiVUI1VjVQc1lvcnEzMWVrd1c2K21RdGlKaEc2?=
 =?utf-8?B?VUNEQ1RSL2M5TC9BS2pzdWdWL3VOZ0hzTGZmMUk3TGhPOHhGeTdCcjQrcmxG?=
 =?utf-8?B?aXYvaEs3aTNIdExleHk3b3RKV21WSzhBQm01Y1NMaE9UZm81VHdQVEpWKytk?=
 =?utf-8?B?RkJncEFxN21tdEI2S1JPZ3l3bi9xd1ZVK2JzNk44azBtTmFsYXB3dlhua2Zv?=
 =?utf-8?B?cS8ycDhVS2F1dGh0V1k5OXZCWWIyRS9sS2Ywb2cxWGd0UDVNdUdjMmpsakh6?=
 =?utf-8?B?SmU3Zm93UEptcG5xajlpMGJBLzFnZUlwakZQeENJZmw4YnBRNjhRSDRBRXNn?=
 =?utf-8?B?aWJRbElJazUvSCtva2lQMWRER0t5dnBzQVlyQU9EVTk1b1JzekExcHBKenNs?=
 =?utf-8?B?RUE2Y0VkaTdHbVZhWTMvc3dNOWJVTjZ3Ykk0bW43emhESlhRRldaZUJrVmhv?=
 =?utf-8?B?Qko5WXRQSU11bUUzZG1TOXFKZ1hqMU9OWjJrYzZCYWMvRjhGdnkycEREc2Vp?=
 =?utf-8?B?NXViMnRaeTlHaWQvYkplQXRzcnNGdmR4SUxTaHc3bUZKMFp0MnJCTUFQbVBi?=
 =?utf-8?B?RjRTQVlqQllsZkFzeVpINy9KMEpqcnAyZzlCWXJHMmY4cUtFa25KbThzMmg3?=
 =?utf-8?B?ek5CMGYxakpjMVpUSFRQdW1mUjdzTVBrQzVscE9PM0MyMkV4emxuaTdjRHJx?=
 =?utf-8?B?ODRKN0hhenJtSFZDSEQ2MGdZTTZWemRqR2w0YXhhdlNKZjNwOW1OZzlGWHFt?=
 =?utf-8?B?d25od21RejVTVkxuUmVKTkFFY0xLb1U3MEZLVXYzakRDbmt1dWYwQ1NOeUgv?=
 =?utf-8?B?L2F6UDg5TEE0QlFkdzc4NUJSVkl3YU53ZU5VY0d2TVNTYmY0WUZCdzlxNmcx?=
 =?utf-8?B?ZnRWdWJ2bE92QVRyaXpvd2lSa0Fad0ZydmN2bkVvdVNnZmN4aU9ISCtXUFRp?=
 =?utf-8?Q?IItLSqP3opP4gnOY1IbVXh8uBB2DEN6f?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb50668b-631f-4663-2a7a-08d995b3759a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2438.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 23:27:05.7006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: anthony.yznaga@oracle.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2519
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10145 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110220132
X-Proofpoint-GUID: h33Z5M4C0-NxyHfn2rwl5qNfh52uA6a-
X-Proofpoint-ORIG-GUID: h33Z5M4C0-NxyHfn2rwl5qNfh52uA6a-
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/7/21 12:21 PM, Matthew Wilcox (Oracle) wrote:
> Instead of calling put_page() one page at a time, pop pages off
> the list if their refcount was too high and pass the remainder to
> put_unref_page_list().  This should be a speed improvement, but I have
> no measurements to support that.  Current callers do not care about
> performance, but I hope to add some which do.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> v2:
>   - Handle compound pages (Mel)
>   - Comment why we don't need to handle PageLRU
>   - Added call to __ClearPageWaiters(), matching that in release_pages()
>
>   mm/swap.c | 23 ++++++++++++++++-------
>   1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/mm/swap.c b/mm/swap.c
> index af3cad4e5378..9f334d503fd2 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -134,18 +134,27 @@ EXPORT_SYMBOL(__put_page);
>    * put_pages_list() - release a list of pages
>    * @pages: list of pages threaded on page->lru
>    *
> - * Release a list of pages which are strung together on page.lru.  Currently
> - * used by read_cache_pages() and related error recovery code.
> + * Release a list of pages which are strung together on page.lru.
>    */
>   void put_pages_list(struct list_head *pages)
>   {
> -	while (!list_empty(pages)) {
> -		struct page *victim;
> +	struct page *page, *next;
>   
> -		victim = lru_to_page(pages);
> -		list_del(&victim->lru);
> -		put_page(victim);
> +	list_for_each_entry_safe(page, next, pages, lru) {
> +		if (!put_page_testzero(page)) {
> +			list_del(&page->lru);
> +			continue;
> +		}


I know that compound pages are not currently passed to put_pages_list(),

but I assume the put_page_testzero() should only be done on the head

page similar to release_pages()?


Anthony

> +		if (PageHead(page)) {
> +			list_del(&page->lru);
> +			__put_compound_page(page);
> +			continue;
> +		}
> +		/* Cannot be PageLRU because it's passed to us using the lru */
> +		__ClearPageWaiters(page);
>   	}
> +
> +	free_unref_page_list(pages);
>   }
>   EXPORT_SYMBOL(put_pages_list);
>