Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 22 Oct 2021 16:38:48 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Wan Jiabing <wanjiabing@vivo.com>
Cc:     Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        kael_w@yeah.net
Subject: Re: [PATCH] net: dsa: sja1105: Add of_node_put() before return
Message-ID: <20211022163848.07aa8fd3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211021094606.7118-1-wanjiabing@vivo.com>
References: <20211021094606.7118-1-wanjiabing@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 21 Oct 2021 05:46:06 -0400 Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/net/dsa/sja1105/sja1105_main.c:1193:1-33: WARNING: Function
> for_each_available_child_of_node should have of_node_put() before return.
> 
> Early exits from for_each_available_child_of_node should decrement the
> node reference counter.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Applied, thanks.