Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2294974pxb; Fri, 22 Oct 2021 18:56:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzomLp3/SvWEsLAV48dkGQUYe8oPw6ZlgT8Lrvr8/aO/jUYfWCEYwgR1jpfjsRb6RrbYIyd X-Received: by 2002:a50:c31a:: with SMTP id a26mr4705040edb.193.1634954200641; Fri, 22 Oct 2021 18:56:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634954200; cv=none; d=google.com; s=arc-20160816; b=wMhSfWbArjOaprwd8odFMrnYkRzq081gzZcXjGmbqVEA7F01ZlH0uYyWzSeN1CxWCq jHgrHhcWuJLkGBRIGb6B4yAebwiyxFogQPzYAD8Sowq/5Avm0wPTQ/p9OqQfQqiUPIc4 r+BH4Nhd/Oqlo/la6z5M/yGRvLCWFSA4YgT6qqg0rFIgktQuwtFEKERQC43M9j+CXI8v oUi5JIejG3ftXU1QPp6jGCgGW/ASiWNHZUXk1ayp9s9kfWk64Hmba5VGwodjzSrHRzlC ebIDemYfQMLvFUydnhP/e6EqnDtQ43TBeJV839tSsuEcLbw6aNPNtDWTJnT6dG3G07xs jKlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dmarc-filter:sender:dkim-signature; bh=7dGf38pZUs6IEWVOM5eMZ7cDqKy8omQd+uK12KjLWAs=; b=lfpHvQ7+YH9mtw0teZ2si3xVx2SpAbZSCUmlwoQGY5q2oghXWwz13lkSe5zKl1LJAQ oA4aLoHa+LqcMKk5tBj3o9c2RLkEtqxgaspHw92arTmBBivzdTaGRap7bsyTedhgdIWl kjzKXeNMEdvodDsu61wbAYytIykI3yLanvc1nmgBlO085yuKWz5LWvdnFwqAL6u0GYCP /QfjyPZWQxVfqj+l2QoUtA4bbDH69B/Erv9XP1XXwWQo3vGmBAP+nI33ytdv2DFH8z22 tq7DGeVIS4rT86Xz5KTronSbRiP1wDGkFqgwUFvk22V0Rv/oqqrkGV3vlzM2qMdZ4rNT lPbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=T25v0YBS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t14si19281264edd.142.2021.10.22.18.56.17; Fri, 22 Oct 2021 18:56:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=T25v0YBS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230438AbhJWB4i (ORCPT + 99 others); Fri, 22 Oct 2021 21:56:38 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:21303 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbhJWB4i (ORCPT ); Fri, 22 Oct 2021 21:56:38 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634954060; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=7dGf38pZUs6IEWVOM5eMZ7cDqKy8omQd+uK12KjLWAs=; b=T25v0YBShpmyNBKHxRvVjYIRfkye6GKjWvvCamGDug2FeaWxe0fL94fyBG/wuXVCxJbnCuJg SIP0s/JOOWsbv/Uhwsx1eFxOXp4j++EZY9ewIQUp0MnRKHm6mDB+jjS8DPcs7chQSUi/R9iu 6l+Ymj2fSi2oSUBiZEdZNgpDJuM= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 61736b47b03398c06c5fdd77 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 23 Oct 2021 01:54:15 GMT Sender: quic_luoj=quicinc.com@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 58CE0C4360D; Sat, 23 Oct 2021 01:54:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [192.168.1.4] (unknown [183.192.232.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luoj) by smtp.codeaurora.org (Postfix) with ESMTPSA id C6871C43460; Sat, 23 Oct 2021 01:54:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org C6871C43460 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=fail (p=none dis=none) header.from=quicinc.com Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=quicinc.com Subject: Re: [PATCH v4 02/14] net: phy: at803x: use phy_modify() To: "Russell King (Oracle)" , Luo Jie Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org References: <20211022120624.18069-1-luoj@codeaurora.org> <20211022120624.18069-3-luoj@codeaurora.org> From: Jie Luo Message-ID: <2ca852f6-dbd5-8909-65d2-377adb918c33@quicinc.com> Date: Sat, 23 Oct 2021 09:54:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2021 8:15 PM, Russell King (Oracle) wrote: > On Fri, Oct 22, 2021 at 08:06:12PM +0800, Luo Jie wrote: >> Convert at803x_set_wol to use phy_modify. >> >> Signed-off-by: Luo Jie > On v3, Andrew gave you a reviewed-by. You need to carry that forward > especially if nothing has changed. > > Reviewed-by: Russell King (Oracle) Thanks Russell for this comments, will follow it.