Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2525787pxb; Sat, 23 Oct 2021 01:39:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiBSyIVxYONtqsTeqX21oHPoVwGJ6tS1A7UsfQ7mk1yuOmgSENex3AGCahSED0C4Q5uii2 X-Received: by 2002:a50:d802:: with SMTP id o2mr6844460edj.331.1634978355574; Sat, 23 Oct 2021 01:39:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634978355; cv=none; d=google.com; s=arc-20160816; b=wVRsSV6qXecrdfQx5Z7sMVLbLF0KV3M4pH2XbTytXsHMjQyj3OwA5KLjWZqFdUIbl0 Xt7PQhCfjFbLzjyoveFuC0PYBtV2mbV6hh9l1wK0Dvy76tgUNLhVdcl92wRnSMB75NUj i+aT1urZC10X7Tmu/cLLHGna6zyjOTBCSCk2rjBF29bOUESW33zzx92ZunsLjoh8Q6oI T7jJoNs3887MaDD0gGjOoHphS+6wSWiC7j/OnRBNlMgrreQnrDCkWmxxHVTq4eMIhPEY g7x/Z4Xk1BsdGw5iqIU1ICR8hb7jgHtu7++QPFqUGNlhvdm8CAiYZKeT51szDQ6j+50Z gKJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=JWYazItGGDmxB3tlCZwxquRKPod4Oq86y096NCBmtDA=; b=KX2DYDTVs+GPfksujY0eSWFfcyOyYhW9pTGh2WXTQAIoqx1QK2t5MHcbI1nJ3QLsN4 AuEntbn3JOCFP2l0GATqQqyd9hsJNBmOGCTSZPF8QujWytWqSl3zCIfHN8JrQCAcRRWZ PAJhoiJbcpRTr+OMKwtvNXxODpbkzo+vRph4T5H5ZTUQfBT9YQw97e6wdhW+eILiFQDO UgbBIkYZd6XjAZFlqLZ8uzB7jlbyVNUpOc5+60CHSFapyXMwaW20D2Qmt2yRT5CKOVeR FvF9vFp0y6//cnfg7pYER4Z87ALRSuZK6USybmG2IIthWaB4fvuzKXIkPgJcv/vHDO9H 2Kpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=0BOyAcQ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si14039574ejt.760.2021.10.23.01.38.20; Sat, 23 Oct 2021 01:39:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=0BOyAcQ7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbhJWIVr (ORCPT + 99 others); Sat, 23 Oct 2021 04:21:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229908AbhJWIVq (ORCPT ); Sat, 23 Oct 2021 04:21:46 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B270FC061764; Sat, 23 Oct 2021 01:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JWYazItGGDmxB3tlCZwxquRKPod4Oq86y096NCBmtDA=; b=0BOyAcQ7YXM1XCoGZnUqYY1gQa pr0MuZVpOz5yJUiRHTr/nv52T9U431VthHWOIo6YCmXDm+q4qcrAPKN08ppjYzi8oH/69/rPoHBn+ sJIiHvEgttWn0CHaRX30XAiDYAijD33khmEGKvdwp3HmpaTOIFj+PcQYR3qsWTDAnDY9gF4+BnZsT F7u+yUZx+JwKZEh1MmuFkH7iLZ4D4+hzYSlC0oyYkfYWDDbLVIDW0nH8rUtdpNNrRTbhX2LMmIvoZ UjtxI0nK8go0sG2Ga0Wp9ZL2NyTp2ZtKqJtcCgiSw5/Px1XpZ8ljzH47XVTO8GASqUMtzR2mKkh51 6oVwVI3g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55250) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1meCFK-0002Uk-Op; Sat, 23 Oct 2021 09:19:18 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1meCFI-0001xk-Ta; Sat, 23 Oct 2021 09:19:16 +0100 Date: Sat, 23 Oct 2021 09:19:16 +0100 From: "Russell King (Oracle)" To: Jie Luo Cc: Luo Jie , andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH v4 01/14] net: phy: at803x: replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS Message-ID: References: <20211022120624.18069-1-luoj@codeaurora.org> <20211022120624.18069-2-luoj@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 23, 2021 at 09:53:15AM +0800, Jie Luo wrote: > > On 10/22/2021 8:13 PM, Russell King (Oracle) wrote: > > On Fri, Oct 22, 2021 at 08:06:11PM +0800, Luo Jie wrote: > > > Replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS defined in mdio.h. > > > > > > Signed-off-by: Luo Jie > > On v3, Andrew gave you a reviewed-by. You need to carry those forward > > especially if the patches have not changed. > > > > Reviewed-by: Russell King (Oracle) > Thanks Russell for this reminder, will follow it. But, from what I can tell, you still haven't followed it in your v5 posting either. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!