Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751728AbXAATGK (ORCPT ); Mon, 1 Jan 2007 14:06:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753580AbXAATGK (ORCPT ); Mon, 1 Jan 2007 14:06:10 -0500 Received: from mx1.redhat.com ([66.187.233.31]:52588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbXAATGJ (ORCPT ); Mon, 1 Jan 2007 14:06:09 -0500 Date: Mon, 1 Jan 2007 14:05:38 -0500 From: Dave Jones To: "Robert P. J. Day" Cc: Arjan van de Ven , Folkert van Heusden , Paul Mundt , Denis Vlasenko , Linux kernel mailing list Subject: Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"? Message-ID: <20070101190538.GA20443@redhat.com> Mail-Followup-To: Dave Jones , "Robert P. J. Day" , Arjan van de Ven , Folkert van Heusden , Paul Mundt , Denis Vlasenko , Linux kernel mailing list References: <200612302149.35752.vda.linux@googlemail.com> <1167518748.20929.578.camel@laptopd505.fenrus.org> <20061231183949.GA8323@linux-sh.org> <20070101015932.GP13521@vanheusden.com> <1167646450.20929.921.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 23 On Mon, Jan 01, 2007 at 05:27:10AM -0500, Robert P. J. Day wrote: > > both look good... I'd be in favor of this. Maybe also add a part > > about using GFP_KERNEL whenever possible, GFP_NOFS from filesystem > > writeout code and GFP_NOIO from block writeout code (and never doing > > in_interrupt()?GFP_ATOMIC:GFP_KERNEL !) > > it strikes me that that latter part is starting to go beyond the scope > of simple coding style aesthetics and getting into actual coding > distinctions. would that really be appropriate for the CodingStyle > doc? i'm just asking. Adding a separate 'good practices' doc wouldn't be a bad idea. Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/