Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2573246pxb; Sat, 23 Oct 2021 02:59:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhQDkTI7ERvDncZV31wq0tV3nAz2Bl1dn4sK9VjF+ClFMLqgIhuaZ+gePmBYeuf3Nvh+fv X-Received: by 2002:aa7:88c5:0:b0:44e:20c:1f26 with SMTP id k5-20020aa788c5000000b0044e020c1f26mr5554495pff.22.1634983181337; Sat, 23 Oct 2021 02:59:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634983181; cv=none; d=google.com; s=arc-20160816; b=hB1u/tHfr7fJnrW86TrX0+cYJuN+OS7myKiD/OBiRRpq3+neohoPhI4q7ql/HZeIcP DFh+He9IbHy/Ohm9QHomNlxCgyomAGwRFYFr4H4977vaAu5gJ19OsGn6pXdsdveUdewR gAWGQ2ssNunwL/fKmQkQUdZfiDCVqxyYveFcc+W3uO1osanLDr+cMdAs8cG+0ANvfe76 9bu0xmpE1icx12BJewjyFk75bRdxSfN/C+ECjLHnXd3YjtUv5VrOh8pGa0ipuSgskwHR kS0ZN/UMFBmc5xsK/Yl4ssCJwm6URBS43hfBKWnsupd1t/81pKPnRGQL4yEoc8aSmnvS HrDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=dHMTt1k0Cd68+zir1t9TVpYzECWPKdraKiS6FAr1kE0=; b=Km5KyZhQwsR8+HBvrqr+QxqyQJFuH3vEtyNOY+cQVmmemaVFQRkLZDvSFjnW6EiaHa XAeHgen/05X98QSc3qI5746mAMts3NLyFngcke91SuSEV91yVKoutBA5TXJupGethSDX HgRLaXwR2p4GJxQ8JhXAzUrfuY3nAKvkvY9o2UjkyL/9VEsaUqRqP3X26QajMuF33iPi h+6Ya637Ri3RibajkPfpe0b2izhqOM4Fil+OhnxMOI4LuvkJGyHu3mbhdYah3JC6wDIi 6mlYAY/tQISGyYlwxsB4XRc/25yfrWNYwJCYaFSnESa+daAR0mUSAm6J9sHumlL1jPPU wcMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=jFpAGPV8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x23si18215229pfh.31.2021.10.23.02.59.26; Sat, 23 Oct 2021 02:59:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=jFpAGPV8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231391AbhJWKAZ (ORCPT + 99 others); Sat, 23 Oct 2021 06:00:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230126AbhJWKAO (ORCPT ); Sat, 23 Oct 2021 06:00:14 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7B6BC061234; Sat, 23 Oct 2021 02:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dHMTt1k0Cd68+zir1t9TVpYzECWPKdraKiS6FAr1kE0=; b=jFpAGPV8mZxUi3fR8OaQ1yJzGy ozPKJMOd7T7FKHVXLaCnw1rohhVYgbeBn1i4Iy5vBmMqojerpnIxPElHR8Za/zMpZUBQwwsoXaoob adtJAyv9cK9WPNjRHnlvR8W42nGbEDkaRUUrikPMMoh1O1rByRrtgF2cMNkvAkNcOfVrLgucmi5SK ISljpc9GkDNT7La+h+yxSSXDYPxmRDLXz/I4sr9wzcFUCXb3GAfG6dJUjCiL3T0+6XNsTA4/4Uzej xXgvdF4WM3WOL1IwKhb3E+MQ9Gd0ARq9Y63qvxbHU6uVNSetWXSPGanG0yuq8YuFePA1efndAMMZ/ xUNm+ObA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55252) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1meDm1-0002Yj-3D; Sat, 23 Oct 2021 10:57:09 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1meDlz-00020f-GC; Sat, 23 Oct 2021 10:57:07 +0100 Date: Sat, 23 Oct 2021 10:57:07 +0100 From: "Russell King (Oracle)" To: Luo Jie Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH v6 01/14] net: phy: at803x: replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS Message-ID: References: <20211023095453.22615-1-luoj@codeaurora.org> <20211023095453.22615-2-luoj@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211023095453.22615-2-luoj@codeaurora.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 23, 2021 at 05:54:40PM +0800, Luo Jie wrote: > Replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS defined in mdio.h. > > Signed-off-by: Luo Jie > Reviewed-by: Andrew Lunn This is still wrong. Andrew reviewed it, and then I did. I gave you a reviewed tag as well. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!