Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2582138pxb; Sat, 23 Oct 2021 03:13:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhmr8CfGxb2rS9gkbts1AnaY5BOGXAeN3/dzjs26A0Z6+IbCPAy4Xg9r7EEUJjcosVDmyq X-Received: by 2002:a05:6402:4256:: with SMTP id g22mr7697928edb.399.1634984005752; Sat, 23 Oct 2021 03:13:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634984005; cv=none; d=google.com; s=arc-20160816; b=awHqe9mLBqYeLY1Wd+LmODgABLa/yCtIbMd/5/tm/YFYmwq/PIH0UiCsMXjejJ7SXw ko6jJIG4+iz4pT5YhDGClobbif8VBd5AVUag/W3I5hyft5I4WPhTWAV94S8aQNzYth3o 9eMdY5MVbbB1hcNZu9otxL+8Dp7VDiFEdZwA6HdRu074K0RCDtM0OUXAUu3kUPznY7Lg jXZwHApY43932FzWCnev/RcL8oLNAF59JuzumTqWwKZXroitKVgUmxLOZuqzMIKoUW/a q2QAQLQU6KggRWIOu28j1dt+w7gWs2MU4FzMI46RcjJjkc0eeH3kZrdgnroMFQ1DVUNP iQnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dmarc-filter:sender:dkim-signature; bh=8r0u4wEsrbWPZjLz0OfeebwILxlsOucWP5LkIJgPIaI=; b=pC3mborxF9tS1Qn9sGF3XeF++dGyMMIg6qGM+s3vY57alunRPwe+YCLJIHtKEGNPga fQf4xbwi4Ln81SsYUAzLWzZb4g1UBibJFj1RHi0JBDvYw8s5qf4GSbYzTXFGDq45ID0n jeR/R9nzz93CwBwbkibAL5tT6vV5LuHsqawtycFYb5sogojjBKCbEzp6aY2HGNjbhVKm i7Jo5tihNO7/ZFDqFsos+9jG77QWyYJ+BS3HLvT8We80c5l452oQHC+7fallgRaZAdTu oMXhCNwR1a6AuRqBuI8V/waWjio/BmWLrlqO5EQ2QMxsSre3Vv1vJMH1r0rlhiNKY+un Hkrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=TUd7J1WQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id et17si308325ejc.499.2021.10.23.03.12.46; Sat, 23 Oct 2021 03:13:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=TUd7J1WQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbhJWKLk (ORCPT + 99 others); Sat, 23 Oct 2021 06:11:40 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:56095 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230140AbhJWKLj (ORCPT ); Sat, 23 Oct 2021 06:11:39 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634983761; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=8r0u4wEsrbWPZjLz0OfeebwILxlsOucWP5LkIJgPIaI=; b=TUd7J1WQvwRlXMzw3B6zONnrK+TXtg8zKBr8AhmQJVKHR+o/HhlAAaUD4+rtHSJek6lA0wrS 03cOYQGPv1ILML335e2P8BPZ1urHBAIXzdMxo4rfS+X5epdZLGfFha8mRZKO1aMOlqoW6Zum Yo0zlasGW5G93DQuKnUxipH88wY= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 6173df4114914866fa632252 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 23 Oct 2021 10:09:05 GMT Sender: quic_luoj=quicinc.com@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9DE20C4360D; Sat, 23 Oct 2021 10:09:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [192.168.1.4] (unknown [183.192.232.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luoj) by smtp.codeaurora.org (Postfix) with ESMTPSA id 80F58C4338F; Sat, 23 Oct 2021 10:09:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 80F58C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=fail (p=none dis=none) header.from=quicinc.com Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=quicinc.com Subject: Re: [PATCH v6 01/14] net: phy: at803x: replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS To: "Russell King (Oracle)" , Luo Jie Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org References: <20211023095453.22615-1-luoj@codeaurora.org> <20211023095453.22615-2-luoj@codeaurora.org> From: Jie Luo Message-ID: <7755cacf-09e3-19f5-6976-10c323eee750@quicinc.com> Date: Sat, 23 Oct 2021 18:08:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2021 5:57 PM, Russell King (Oracle) wrote: > On Sat, Oct 23, 2021 at 05:54:40PM +0800, Luo Jie wrote: >> Replace AT803X_DEVICE_ADDR with MDIO_MMD_PCS defined in mdio.h. >> >> Signed-off-by: Luo Jie >> Reviewed-by: Andrew Lunn > This is still wrong. Andrew reviewed it, and then I did. I gave you a > reviewed tag as well. Thanks Russell for the review comment, i will add it in the next patch set V7.