Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 23 Oct 2021 12:31:58 +0200
From:   Len Baker <len.baker@gmx.com>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Len Baker <len.baker@gmx.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Iurii Zaikin <yzaikin@google.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sysctl: Avoid open coded arithmetic in memory allocator
 functions
Message-ID: <20211023103158.GA4145@titan>
References: <20211016152829.9836-1-len.baker@gmx.com>
 <YWr7UN1+RkayVWy2@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YWr7UN1+RkayVWy2@casper.infradead.org>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Matthew,

On Sat, Oct 16, 2021 at 05:18:24PM +0100, Matthew Wilcox wrote:
> On Sat, Oct 16, 2021 at 05:28:28PM +0200, Len Baker wrote:
> > +static size_t new_dir_size(size_t namelen)
> > +{
> > +	size_t bytes;
> > +
> > +	if (check_add_overflow(sizeof(struct ctl_dir), sizeof(struct ctl_nod=
e),
> > +			       &bytes))
> > +		return SIZE_MAX;
> > +	if (check_add_overflow(bytes, array_size(sizeof(struct ctl_table), 2=
),
> > +			       &bytes))
> > +		return SIZE_MAX;
> > +	if (check_add_overflow(bytes, namelen, &bytes))
> > +		return SIZE_MAX;
> > +	if (check_add_overflow(bytes, (size_t)1, &bytes))
> > +		return SIZE_MAX;
> > +
> > +	return bytes;
> > +}
>
> I think this is overkill.  All these structs are small and namelen is
> supplied by the kernel, not specified by userspace.  It really complicat=
es
> the code, and I don't see the advantage.
>
Ok, understood. I will send a v2 without this function.

Thanks for the review,
Len