Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2669239pxb; Sat, 23 Oct 2021 05:22:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTt65UHSLCJ+HvV+MyDklFHwTy+39hdLB1I5shACC4lFUwoxo8UJetkokT9zP0Vx9bU2/E X-Received: by 2002:a17:90b:2494:: with SMTP id nt20mr20219040pjb.19.1634991751157; Sat, 23 Oct 2021 05:22:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634991751; cv=none; d=google.com; s=arc-20160816; b=q9qYkxCUdbA9fTbDwbFTI/fmQbUECkJYE3m550ePo4QvyDXNgZ1/DjLECFO/qXZNst xaWGOQW8Wk+F+qziJa4k8yX1x/FVr+IKvMYg69I32+A9b+GZk9yeFgB+TXW2/aOzzyHS pon41q8UVoBBhPUE62GjUtw2AXAbuUitU3UdFRy6BWne3RmGvR9K//BMwc9R81QhzqY5 qHz62L3b1CIF72xvLEWzOxAYZ1vElI9bQZQ0OjryD+J+v6I/h589aE6CpCibrtNZ9x0U R6b/KBGSkDjcVw35L9RU/0UDyVSEdOtyf4p3xDpDXnAHAzo+5Ryp/qhY0yDJlrY26/IV LPHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:reply-to:cc:from:to:dkim-signature:date; bh=GG4tUVfOrpHe6Cd9R03tfHXWzUXIPi4QaFA+XbWzydI=; b=Ol+/GxGy0bVlFuDIyp46VWl0JpOb1oEX5Uiu/2dIGg73vZ3MAs70v/pzYGEan/f/jP Nu1YoEeoZApG1hjlM/L8iy255ogyMuGkxLhR2YTRRc5s8tQzAQqFDpucnHz3ZOzt5Uh0 2dPX0sKNYY1l4rBqhZJcaQBwwikEK0YR5pwsy443SysjtNbsY5pocxdKv2ajD0ME4ZK7 rboiCoWYwd5JtfYSBBi8SBSAADjxr5Hp9kO+OKhHqtMEp12ulzI9ZJcQ7obvGs3NP2a0 eXrHRnxzXcAX8toW4YxStxnmQAD9a1a5kIB2sXVuOzW21kpJYiihnihfnSKG/+P3zJ1O vT0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=AfZZAR9w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nu15si21118085pjb.179.2021.10.23.05.22.03; Sat, 23 Oct 2021 05:22:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=AfZZAR9w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229813AbhJWMVz (ORCPT + 99 others); Sat, 23 Oct 2021 08:21:55 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]:27030 "EHLO mail-40131.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbhJWMVu (ORCPT ); Sat, 23 Oct 2021 08:21:50 -0400 Date: Sat, 23 Oct 2021 12:19:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1634991566; bh=GG4tUVfOrpHe6Cd9R03tfHXWzUXIPi4QaFA+XbWzydI=; h=Date:To:From:Cc:Reply-To:Subject:From; b=AfZZAR9wTmzyooI6hInfocai8sWVjg5SuP6fVB2J3d4FGS6gQh0FyI6XmelurR6FC t7mMGjEJiErx33eJyN5/qVWB6QB4JYhcm7eeRccDj0Gkhl6K1nOajiu+yfrM4e7Br+ j3kkWCsygrBwf5lhHpQ8voGpnLtzOS4B3j3X/vAYvZIWyHy3+b7cgx2Bu7XelC0bWn 34WLuugx08P9HJo+/sydhh6ra1W9gl4NHHuCn9H27KokxFG3DTIWw76w1Xt/omxr2r le5D4MtZm4yOPUxqQoh/K7zDvd4RKmNMGRGfPG6TAHzZASIpv+wkPH8yose6Yrg7hJ gbBPBr2VuUp9g== To: "David S. Miller" , Jakub Kicinski From: Alexander Lobakin Cc: =?utf-8?Q?=C5=81ukasz_Stelmach?= , Alexander Lobakin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Alexander Lobakin Subject: [PATCH net-next] ax88796c: fix fetching error stats from percpu containers Message-ID: <20211023121148.113466-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rx_dropped, tx_dropped, rx_frame_errors and rx_crc_errors are being wrongly fetched from the target container rather than source percpu ones. No idea if that goes from the vendor driver or was brainoed during the refactoring, but fix it either way. Fixes: a97c69ba4f30e ("net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Dr= iver") Signed-off-by: Alexander Lobakin --- drivers/net/ethernet/asix/ax88796c_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethern= et/asix/ax88796c_main.c index cfc597f72e3d..91fa0499ea6a 100644 --- a/drivers/net/ethernet/asix/ax88796c_main.c +++ b/drivers/net/ethernet/asix/ax88796c_main.c @@ -672,10 +672,10 @@ static void ax88796c_get_stats64(struct net_device *n= dev, =09=09stats->tx_packets +=3D tx_packets; =09=09stats->tx_bytes +=3D tx_bytes; -=09=09rx_dropped +=3D stats->rx_dropped; -=09=09tx_dropped +=3D stats->tx_dropped; -=09=09rx_frame_errors +=3D stats->rx_frame_errors; -=09=09rx_crc_errors +=3D stats->rx_crc_errors; +=09=09rx_dropped +=3D s->rx_dropped; +=09=09tx_dropped +=3D s->tx_dropped; +=09=09rx_frame_errors +=3D s->rx_frame_errors; +=09=09rx_crc_errors +=3D s->rx_crc_errors; =09} =09stats->rx_dropped =3D rx_dropped; -- 2.33.1