Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2776016pxb; Sat, 23 Oct 2021 07:46:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsPHN9PngZ+puLiR4zGMGwXrC/muCuFS9m8W9grnVqtv4hOqlNLiR3L4cZ1O+5o/pye0xA X-Received: by 2002:a17:906:184a:: with SMTP id w10mr7925713eje.273.1635000370109; Sat, 23 Oct 2021 07:46:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635000370; cv=none; d=google.com; s=arc-20160816; b=soCBoOR61pVvoAbL00DPA2SR03BMDjjwQWLaEjlwgnKCnX+K+m95evqX1hGLW24qHA kCj0XR21ZlgPXsBlQ/UbCFgzMeEGLfhSV2C528ZK6ZCwPViqhnsmRG4TAFCr+/Qon76R 7DjatuxqONLpKcNEiGhVhUFdaJMIDrANKDB3p7JOx133NBmjJdMW+3Re38ekEZo3WhX/ TOZqkpifBYHgaYXKiXQsM6kTI1CrRpbP9uBuPoV5WZgfdkidQLjbt7betjXsXlpbCi0a +a2aQtV8rUVpHOicauIIi33vajNVdl5rd5vMwybg6SFMf/z42AhekpE+fNx41VGYarVU C4HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/GpXbf5mv36tQwc/bTcJYuehy8KVgYrO7OXGBic3rVM=; b=dn/5YVo/Aq4I3Te6vg9tIXnUhzFkph8mMJHoh3UcEIFQE+Pr2NOf3Oi7hqJjK8b0kp WjexkoVZ26GrkpGeOD+0D0/YnzpL1Bu5xf8PPp+rD6f7GvS0h2XAu+X0zFCWAJQVGBJy VzVivjkcRLyzbh1kYC11Jay5vB53g6+CwA+g46PLNqY1Ddq8ALUSTyXFT6Fb3zHXVGcZ hB0+PScAw6DSiejp2UHJfy/PWJvWHoZyw62Mbp5gmDePmjy0AUXPJOVWM9aUhlgJUD3j ITH5pvh8Y49JdddjV2GB3GEnn90Bv1qIcvlrAcJrMi9kRpapgngSqZJV90G38J9alPea gpRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=WfeKEeta; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jr21si15975703ejb.14.2021.10.23.07.45.30; Sat, 23 Oct 2021 07:46:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=WfeKEeta; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230393AbhJWObU (ORCPT + 99 others); Sat, 23 Oct 2021 10:31:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230230AbhJWObS (ORCPT ); Sat, 23 Oct 2021 10:31:18 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EA77C061714; Sat, 23 Oct 2021 07:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/GpXbf5mv36tQwc/bTcJYuehy8KVgYrO7OXGBic3rVM=; b=WfeKEetaNauyIRfLFF7zoE+sHK 1H4TQQkf2An5p+RXqSoPLo5BLKlbbnXCsIItwbd8NbTMgId+cUl0mSwcf3rYPUX8ZnK6ctn83nOV4 bxoImy/LlrzcAk6TuixjAckaSkze/SVieW1iC9LHGKt/v90lNjxNPI3Q4R0DzHQSDPkmDsohsknFA Huxj5mX2ZPjY5F4zh0DMdAqn08uGogkUP23NUCP6H5OHeqdFUVFiOy+yKibozozmJKRWROEeuA5+X rKT3WKQD9VqZTbbJLIO119L4QqUsaFdgwlfU07M6vcE47TqsAjDeBtvLBbAimgeiEKfa2DZA/FS6x a8J4s35A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1meHzR-00EgNJ-Tf; Sat, 23 Oct 2021 14:27:37 +0000 Date: Sat, 23 Oct 2021 15:27:17 +0100 From: Matthew Wilcox To: Len Baker Cc: Luis Chamberlain , Kees Cook , Iurii Zaikin , "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2][next] sysctl: Avoid open coded arithmetic in memory allocator functions Message-ID: References: <20211023105414.7316-1-len.baker@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211023105414.7316-1-len.baker@gmx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 23, 2021 at 12:54:14PM +0200, Len Baker wrote: > Changelog v1 -> v2 > - Remove the new_dir_size function and its use (Matthew Wilcox). Why do you think the other functions are any different? Please provide reasoning.