Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d0050bf2-e8d0-c2e7-66cb-f3099dfe8d53@opensynergy.com>
Date:   Sun, 24 Oct 2021 10:23:38 +0300
Subject: Re: [PATCH v6 1/1] iio/scmi: Add reading "raw" attribute.
Content-Language: en-US
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     jbhayana@google.com, lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, Vasyl.Vavrychuk@opensynergy.com
References: <20211019075949.17644-1-andriy.tryshnivskyy@opensynergy.com>
 <20211019075949.17644-2-andriy.tryshnivskyy@opensynergy.com>
 <20211020185118.7a02cbf8@jic23-huawei>
 <4e73398f-126a-0e1a-6eed-88d2d37778c2@opensynergy.com>
 <20211021103607.38c85766@jic23-huawei>
From:   Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
In-Reply-To: <20211021103607.38c85766@jic23-huawei>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2Faem1ZUDFjMHZYckMxVkkwSUw1ZDhBWVpCVzNkZlVzalYxZ2JCMjg5RUUy?=
 =?utf-8?B?V3ZobnJpUVBSNzVxZXFXdzFsUUVLLzJkUTdDNGVMUk1KZzBLQk9XbFYwanVU?=
 =?utf-8?B?enRGWW1RbjZVam92akxsRG00WmpUYkJSckcxMUVHT1JCREw2a0xFVXVldEZX?=
 =?utf-8?B?RnVSdytzalVJU2NqZVRZRkZ4a3ZJYjloSlBqRW1weU9qbTNyVFQwWE10SDhE?=
 =?utf-8?B?ejRWV1R3NGY4azlrSHhoZ0lHSGgwZllpNUlsbjBYNHVTelZUWDhsS0diTGs1?=
 =?utf-8?B?NVY4NWtwcWFyczFodTNwa2VCeE9aKzRuS2VPb2l3d1gvSkpJdVByY2Zad3VT?=
 =?utf-8?B?MHVDYlByNHg3ZWVpT1B1Z1lVRGsyNXIzbTRhQ21ndDNMUlUvLzhnZERCWmtX?=
 =?utf-8?B?eFpObkRlSVphQ0tRelFpY2RJN0dla2NmN2lvcW5wdHIrQ05ReEZYenhMeWgy?=
 =?utf-8?B?NzNZOEM0Ulh6K3dtdmQrMjFrZWYrRm1HM1FQUkdYcDVCZm90ZjhVSmJIWFg5?=
 =?utf-8?B?b3NzZG85TXBhS0pGSWtDSkErY0d3Ky9JdFdHUjUyVWhjanVxZHFDQWlmSUxx?=
 =?utf-8?B?cW9yVlBQdWhtT0dEME9xbitwTjhLL1Q4c29mclNEeDB2czFuVTcrTU9vM2xs?=
 =?utf-8?B?THh3b2gxOTFhMGZOdkN0V0sxTXFqMWtjSXhFMFpod2ZGSlNyZnlnaDA1YkFB?=
 =?utf-8?B?QU95QVZvSndrYzlWeEhXZHd5Nlh1UWRXZVRMbjRzMFA2d2xUZzczOEdBZDJW?=
 =?utf-8?B?dlM0c3RXSWU1V2cyTTNFTEk0UDRkTFBWamdPdnB4bnQ2K3dOQ2s4Nm9NVzh1?=
 =?utf-8?B?S3QxUXpBdUs0N1lvUk5PVENlSVpndlBXVXNya2pNMUZGVXUyOGVtUTg4TEpR?=
 =?utf-8?B?UDJYOTNzZFgyejdJVE94SVRIVlB2dExxTTgvM0RPSk02eHJyYTJ2UmxrN3lT?=
 =?utf-8?B?TkFwQVRGWFVIdVY0TkZtRWJVQStaVXhQRGNuQzdnL1dBV2phYTlXSisyci85?=
 =?utf-8?B?cFhmYVAyTzVqUldFbGtqQUk0R3MzK1docTRSN000NHhoZ1hnSDRGK0UzRjhX?=
 =?utf-8?B?TEdNL3Z2WHl4eklFbDAzOHZ3bSt5MVRwcW5KdFJlYkdoZkY3OEJFcHJHVCty?=
 =?utf-8?B?K1E1U1RpZjc4S0dBUDNjMFF4VElYOUpoSzVyUWRXOE9KcHBxWm9kUWNHWS8v?=
 =?utf-8?B?QXZtY1I1SWJRdmFFZ2lHKzM5aWJTbWpaR2lWYUMyeWRyUy9DNUN5VVdvOGRx?=
 =?utf-8?B?RWZkRlRCV2RFdWxXQzFBa21vWnpxS0diTnNsblloSU1UcW5paFhjK0ZKYk5M?=
 =?utf-8?B?VGxHcFFzMmJYQmcxekNzRTB5Si9KNE9OYW5zcTVPUEdOd3dqRGRxVkRocysv?=
 =?utf-8?B?OU1sMTlsZDBiSXRxbWlrc0Uwd2t0VUVMcXNpb01sQ294Zm03Z1ZEYmZJU1Fj?=
 =?utf-8?B?dHg3TXZKWlp2TXkybTUyKzVtT0NRdFppeVd3aG1jVlNLZ0FJOEk0cGZwb2Z5?=
 =?utf-8?B?blluVyswUTBSSHVkamY2dkFWTm5hSjZUOFErRVVzMU5laGZJajhjYy84TnpD?=
 =?utf-8?B?aVNQRmZEbVllUDBqd2ZZT0NyaFFtV0tiQkgycnR6ZGYwd04xWDVpaDF4UDRE?=
 =?utf-8?B?ZUg5SWZjTmpUWlZCKzBxNGlFREhKVEtyT0Y3a1FGNVJkc0hMSFMrM0hOMWhk?=
 =?utf-8?B?aHowUHJrVisya2xhQXNKWXE1MEtWSmkxeGdWa0o5RW1jdDdXd014dFRCQS9B?=
 =?utf-8?B?M3RObjlTL3Qrbmd5cVpROTJ3UERIeHpQb2hLUlNpODZ1U3VEQ2Z0VlhLSlpM?=
 =?utf-8?B?YThCRm5mcitrRUpYWlNZTmEvN0NkTXYvbDF3ZkF2a0RQNHpyby9oWHFPdXBX?=
 =?utf-8?B?M0pqTU1JbGxFT2huU05IRmFoQW9ZaWY4WmR0WTl6amdjK21Db2JTa251RGkx?=
 =?utf-8?B?VjZ2M2NBMVRkMGVvajVGcDdSWkRwNUJKY0hkK2d5dkZSNE9iZmx2OVlaTm5l?=
 =?utf-8?B?cENLZFhpWnZWcG0yMWZPMkUrQVF1RE5FODRSeUlBMHdGekdoTHNPUHkrVnA5?=
 =?utf-8?B?Y25NSVJoSXA5NWdpaXBvV1RZTFBKaFJDVlRUTkRlaERRSWhPMVJjZ2dRdWJR?=
 =?utf-8?B?MjFhNVBXbW1kN1dpOFhCSUZlWTBseUJlTENoWkpCNndFRTBkZWxlWGpMY2g3?=
 =?utf-8?Q?ZupW+W7+X6xsLJU4QsZk1Xk=3D?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4345ff4-7d78-468a-d39c-08d996bf33a9
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2021 07:23:40.1072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H+K+c20AUn5S0Poh1+Nw1yyVXtmIbMEF+yCbJ50psuf6qQa3oI+AmiyrDgoyHkghMM3PH/2PZ4KrIMS3uzcWBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4103
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>>> On Tue, 19 Oct 2021 10:59:49 +0300
>>> Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com> wrote:
>>>
>>>> Add IIO_CHAN_INFO_RAW to the mask and implement corresponding
>>>> reading "raw" attribute in scmi_iio_read_raw.
>>>> Introduce new type IIO_VAL_INT_64 to read 64-bit value
>>>> for "raw" attribute.
>>>>
>>> Change log needs to be below the --- otherwise we'll store it forever
>>> in git.  A linked tag (which will be generated when I apply)
>>> is sufficient for this sort of historical info.
>>>
>> Sorry, this is my first patch, I was not aware of that.
>> Thanks for the explanation.
>> Quick question: since next version will include 2 patches,
>> I guess a change log should be moved back to the cover letter, right?
> It's a trade off for which there are no firm rules.
> Sometimes changes are well isolated in individual patches, in which case
> the best bet is to put the change logs in each patch, sometimes they are
> more global things that affect the whole series in which case the change
> log is best in the cover letter.
>
> However, for a given series pick one or other style (don't mix!) as
> otherwise it would get really confusing.  Mostly no one really minds
> where the log is as long as we can find it easily.
>
> Jonathan

thank you for the clarification!

best regards,
Andriy.