Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <20912d4e-8417-73d6-a42f-ceaada6e3cf3@opensynergy.com>
Date:   Sun, 24 Oct 2021 19:58:52 +0300
Subject: Re: [PATCH v7 1/2] iio: core: Introduce IIO_VAL_INT_64.
Content-Language: en-US
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     jbhayana@google.com, lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, Vasyl.Vavrychuk@opensynergy.com,
        andy.shevchenko@gmail.com
References: <20211024091627.28031-1-andriy.tryshnivskyy@opensynergy.com>
 <20211024091627.28031-2-andriy.tryshnivskyy@opensynergy.com>
 <20211024171015.3b6b46e5@jic23-huawei>
From:   Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
In-Reply-To: <20211024171015.3b6b46e5@jic23-huawei>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2x0ZURGTzdJY3V4OHdwZVl1aUI5cW9rc3oxejIvVHU0cExMWGVHeS9LUDVN?=
 =?utf-8?B?ZGRrYk9QZmswc2gvUnBlSGRRZW83clhMeGhmeUNWd0tNVlNqU21qdWpJSUtI?=
 =?utf-8?B?OGlOSTNWVTRqK0hJYUJPcjJDWG5ocHpjN3RMZFFVR2VIVGJEYVBqZ25xcXh2?=
 =?utf-8?B?VUwvYlNva1RyK2l0TU4vOS82S0RNd3ozekltZjZzcDlIZEZBV3ZvcmJpOFVz?=
 =?utf-8?B?TUV3Nit0bm1DSzA0OVVBcE1UU3JpZzlMYjZvNUVtWWdoUUNQVFlKR0hxUjB6?=
 =?utf-8?B?OWZsNE5OMVAxRnFobnhOOHBINWlvdEtJVXVlM2pwQWlRS1lTMm9mYkl6bEtF?=
 =?utf-8?B?Q2tGWlZ2M3dHQVo2anAxbk1sQ3Y3RHJpZzkrK09HSXJ5S29xUjArNCtuWTdh?=
 =?utf-8?B?TGh6MGpzcU43MmkzVkw5TGxNUVlKTjZWR3RvTEFwbXhCZHFsK2JsQWkwUysv?=
 =?utf-8?B?SFYrcUFHeGlTL0psdndkbUl3bTBHUDJZTkxVcHFIa1hsK1k5RTZLVDNJQVk5?=
 =?utf-8?B?QnpqVlZsRVQ2SllnNFhlQ0g1TFdBcGRaY3BkcEUzTW9LNURhTGxUVXp5elJo?=
 =?utf-8?B?U1l5U1pYSDBJS1YyZCswaDYrU3Z1bE9KcXllcGt1bk1Ha0hZZ2pSazk5b3Yw?=
 =?utf-8?B?dGtublJKNklmWEtCMWFET2toZVgrNVlZeXBqZ2FIVGJGdlJlckxPaGwzdEZa?=
 =?utf-8?B?L0ZSWC9sTkNSQ2haTzVIR3VPM0NVRUxvaG9kUWt2alhubnBUMkZ2bjhXNkhx?=
 =?utf-8?B?akh2clA1REQxejlieDFXbnlnL1A5c0gwZy85Y1o1dnVPc2Q4MTNCUEcrTGlP?=
 =?utf-8?B?bFlvdnB0VjN0WWZ3M1c2TmVEZTh5VzlDNUNJck0yR1QvWS9kR3I2eldWdjlC?=
 =?utf-8?B?cEx4bG9iTTNkbndoUDA2K3laQm9ZdHZKWGxoZnc4Q3ltMW9HWGVkVG4rZURv?=
 =?utf-8?B?L0h6dVI4MmhHVUw5cURQUWtQRlZodHBSUFZJelQydXl4UittNUpGU2psVUVD?=
 =?utf-8?B?TWcxNG9EcWZuNGxYeHFWR2lXV21zOGtDSjNQN29mQVA3US83OUhEdytrOGNm?=
 =?utf-8?B?UHpCZHJuNEY2U2t0U0NZREtuRmM5a2pVSjZvcUdkWnpHdlZZWkR2L1locUtD?=
 =?utf-8?B?RUx5WU03SDRodW8zd0RWWEJoK3VsMlRZTC9jbXo1MSs4Ulp6OEpjTG4xM1dY?=
 =?utf-8?B?djVPb3RiNkhocDBydDBzMldhaWVreE1OMUY2TTh6YlJwZzg5SHdOaWdRckRa?=
 =?utf-8?B?eEdnZGpiVlBxaDVrbExKQkVRd1VOMzR1ZDFlZGdUNjBLeGpON0FWcDNPd0hi?=
 =?utf-8?B?MDJ5dnhqSmVyRitOMGE4R3dMN3RKUUY1TFFQZnQwZjlqdFFMV0FObEl0YldF?=
 =?utf-8?B?aHY2MG1hS2Q4M3JyOEl6a2IyamJsZjJQZkY3bDB1UDQ5empNZGNHMGZDVkJS?=
 =?utf-8?B?NGZRQnJvd1QzOTlkVm5FZHB1SDRjZGc5TjJ3dElFZTYzY3g3VktnNGpLNmlW?=
 =?utf-8?B?Tmd2YWt4c0xVVEJQcDZTMXdFdklYeFlKUGpWK0ltUHdyWGdzQldvNndNTFVl?=
 =?utf-8?B?WmtTNDV6OC80ZW9yL0V0MjJwVG1ndzZaYkFqdGNUZ3M4YWEzOHVSSUhDSWN2?=
 =?utf-8?B?ZndyN1VXNmZaemYyV0dhMktkQkphWm1RbUw0RURTeTVBcG9OT2RXTWNnLzgz?=
 =?utf-8?B?N3lRM08vdkx5U1JlanBad202dHNKdkFzS2U3M2d2dWdncmVjSjNGTm9sSzYx?=
 =?utf-8?B?WmRzWU5YakZLVlJRSk55OWh2di9Yam5aSWtFRVdMYnZFU2I2akRIRHh2c3Rv?=
 =?utf-8?B?NVA0cW5rMmFtQ1RML09kc1I3TlgxTzZjbXVjNkN2MzFzVGk4UVpQTitVcGs3?=
 =?utf-8?B?cUpFZ0I1YTZoTnF4NlM1dWQ5ZEpZVXNvR2p5MlBEbTdzaDRGOFR1elU0cmFu?=
 =?utf-8?B?S0xEV1NacCtlVHJhTFpiK3ZMTFpCamNKMktTTGNBWnNEd3F6UFRSM1JMaHAz?=
 =?utf-8?B?Y1UrUFFoU0lNM3pmRitRUm9BaTYrNVcveEQ3QmEwNGEzQWVFaDVEeElpcGpB?=
 =?utf-8?B?WU9pQ1FpSEhKcjcxL0FsMnkrN2RvalNvTEVkYXpXc2JFY0hMVGo3Rm5SbTdY?=
 =?utf-8?B?ek9FcDRMZncxandieTN3eVc3LzJqbGxrdjRod3NURUdWZjBSbkxVWjc2Um5r?=
 =?utf-8?Q?OYf4KE8ZzJTXEq33ItxTucM=3D?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2847dec4-c6de-4053-f4c5-08d9970f8fc2
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6359.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2021 16:58:54.2997
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zmRHKGEHf+hFDWB0Y+wQd6euJ3vi14N3YzbhriXO98pZP5BeKO7taZD1wKYmhRuDHGmYU0GF5rPlR0ZqrijzAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6950
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24.10.21 19:10, Jonathan Cameron wrote:

> CAUTION: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
>
> On Sun, 24 Oct 2021 12:16:26 +0300
> Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com> wrote:
>
>> Introduce IIO_VAL_INT_64 to read 64-bit value for
>> channel attribute. Val is used as lower 32 bits.
>>
>> Signed-off-by: Andriy Tryshnivskyy <andriy.tryshnivskyy@opensynergy.com>
>> ---
>>   drivers/iio/industrialio-core.c | 3 +++
>>   include/linux/iio/types.h       | 1 +
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
>> index 6d2175eb7af2..49e42d04ea16 100644
>> --- a/drivers/iio/industrialio-core.c
>> +++ b/drivers/iio/industrialio-core.c
>> @@ -702,6 +702,9 @@ static ssize_t __iio_format_value(char *buf, size_t offset, unsigned int type,
>>        }
>>        case IIO_VAL_CHAR:
>>                return sysfs_emit_at(buf, offset, "%c", (char)vals[0]);
>> +     case IIO_VAL_INT_64:
>> +             tmp2 = (s64)((((u64)vals[1]) << 32) | (u32)vals[0]);
>> +             return sysfs_emit_at(buf, offset, "%lld", tmp2);
>>        default:
>>                return 0;
>>        }
>> diff --git a/include/linux/iio/types.h b/include/linux/iio/types.h
>> index 84b3f8175cc6..bb6578a5ee28 100644
>> --- a/include/linux/iio/types.h
>> +++ b/include/linux/iio/types.h
>> @@ -24,6 +24,7 @@ enum iio_event_info {
>>   #define IIO_VAL_INT_PLUS_NANO 3
>>   #define IIO_VAL_INT_PLUS_MICRO_DB 4
>>   #define IIO_VAL_INT_MULTIPLE 5
>> +#define IIO_VAL_INT_64 6 /* 64-bit data, val is lower 32 bits) */
> I'm guessing the closing bracket is left over of some editing?
>
> Otherwise fine and I can tidy that up whilst applying.

Yes, it's a typo. Please remove it while applying. Thanks!

> Note that this is almost certainly too late for this cycle (we are
> about a week away from merge window subject to whatever Linus says
> for rc7 and new stuff needs some time to soak in next), but I'll
> plan to get it queued up early in the next one.
>
Noted. Thanks a lot!

>>   #define IIO_VAL_FRACTIONAL 10
>>   #define IIO_VAL_FRACTIONAL_LOG2 11
>>   #define IIO_VAL_CHAR 12

Best regards,
Andriy.