Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3808837pxb; Sun, 24 Oct 2021 11:36:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYp8gDChLDfqImzzTHkHXJNLrqyf+aFZfmD5+b5jnpWimoQPR8CqBKbQ8dKUIpV9CCAp47 X-Received: by 2002:a17:907:86a1:: with SMTP id qa33mr10232398ejc.270.1635100570949; Sun, 24 Oct 2021 11:36:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635100570; cv=none; d=google.com; s=arc-20160816; b=TV2WiMW841heUdLx1WWW0X0vWTRun6e2AtrIk3oe/hfWo4T7z8v3bTfIhERDnGcYR8 3e8OwJX6PyiLouINMehRpH+HZx7ei5YVdKINzhli9WHZGg+GgakryraHYUN4QXFp/cSE 0bFO+i3gBv1lWAjmu+uKpEM/BobPquPAy9p+Ms+UiVYddnNXYdABHMIJdXye0TiCZ+eL JQuBF3qEbqG65kQt05byYSIWJP/En0DlM02+uNVQpDdzvaG/Cuc6o3BW+C6r5ZIEMpP9 3E3pJw5DlJsPSl8Lb1GFhcG05SB5++Kp7FGiOBgrdBqg6eFBbinspZQv0HjxIieL7RNP ZN+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KsE8bAKtk3MMk6J9dfIOonF+Rf8RiCJlBGgSXgxzIlU=; b=Tjnef47hQHKZ78RppI1l6Sq8//jkHwiXVkXGaziuvBCvtnjANWQl5BVy7GytcFv29Y 1MSpYzOGOJjt+TDg9YghduaRKnt/CiBI/8ZRYGxNa6lyKakBU5xqrL87kKL0wJ+f3ueP IOtitwOflknNshGorlbfkwa+sX3U6bODkjHa7nFxFFr29LahTWnEadkUFeenA+rq4B6R 8Xl9wCXaZGsAv1ef47xiI7ZWX0RRRrPh/BSuWzDjVlX2nr5AvDP6YL5ovoliTmpBui+3 maFOS8vX4AaG1RmccW7PUvkRjH8adAi3J1YIjNksesSUdaK/+oyi0XD//nRKllf0ejiU jBRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=WFbUCsDJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y15si4844339ejp.742.2021.10.24.11.35.47; Sun, 24 Oct 2021 11:36:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=WFbUCsDJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231664AbhJXScJ (ORCPT + 99 others); Sun, 24 Oct 2021 14:32:09 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55718 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231484AbhJXScI (ORCPT ); Sun, 24 Oct 2021 14:32:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=KsE8bAKtk3MMk6J9dfIOonF+Rf8RiCJlBGgSXgxzIlU=; b=WFbUCsDJ03cY/aChhnT/Bu7h1E WEdDsW8jdGiWJ/pzMSE5cRh/xNYRMn8D7DEeicaaB0kSOesm0nPiy5Y6TDBbW86DuABjznxUcMsBf JTCDspANapVIHqqdGwPTww3PzjjJOxpygW2jSjm9cWa5NroAm+sSiB1EmEliLg+F4c2E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1meiFG-00BZwd-Mu; Sun, 24 Oct 2021 20:29:22 +0200 Date: Sun, 24 Oct 2021 20:29:22 +0200 From: Andrew Lunn To: Luo Jie Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH v7 03/14] net: phy: at803x: improve the WOL feature Message-ID: References: <20211024082738.849-1-luoj@codeaurora.org> <20211024082738.849-4-luoj@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211024082738.849-4-luoj@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 24, 2021 at 04:27:27PM +0800, Luo Jie wrote: > The wol feature is controlled by the MMD3.8012 bit5, > need to set this bit when the wol function is enabled. > > The reg18 bit0 is for enabling WOL interrupt, when wol > occurs, the wol interrupt status reg19 bit0 is set to 1. > > Call phy_trigger_machine if there are any other interrupt > pending in the function set_wol. > > Signed-off-by: Luo Jie Reviewed-by: Andrew Lunn Andrew