Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211022144040.3418284-1-javierm@redhat.com> <14a41bd8-cd70-b9d0-ce1c-869cfde8bdcb@suse.de>
 <015855d9-62f3-be81-a4c1-b8439534ec06@redhat.com>
In-Reply-To: <015855d9-62f3-be81-a4c1-b8439534ec06@redhat.com>
From:   Neal Gompa <ngompa13@gmail.com>
Date:   Sun, 24 Oct 2021 16:43:39 -0400
Message-ID: <CAEg-Je8-sSSo-4t_FvqquonPJF7y=-zpQLLX5PjkhEKG-xop=A@mail.gmail.com>
Subject: Re: [RFC PATCH] drm/aperture: Add param to disable conflicting
 framebuffers removal
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Peter Robinson <pbrobinson@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 24, 2021 at 4:40 PM Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> Hello Thomas,
>
> Thanks a lot for your feedback.
>
> On 10/22/21 21:05, Thomas Zimmermann wrote:
>
> > There's still the question of the semantics of this parameter. It's a
> > bit fuzzy.
> >
> > If you use 'disable_handover' (as you mentioned in another mail), it
> > would mean that only the handover itself is disabled. So if simpledrm i=
s
> > not bound to the device, then a native driver should load. That would b=
e
> > hard to implement with the current code base, where we have to take old
> > fbdev drivers into account.
> >
> > (And to be pedantic, we don't really do a handover of the device. We
> > hot-unplug the generic platform device, so that the driver for the
> > native device can operate the HW without interference.)
> >
> > Simpledrm only acquires an aperture, but never removes a driver. If
> > there is a driver already, simpledrm would fail. Only native drivers tr=
y > to remove drivers and would trigger the test. So your patch is more
> > something like 'disable_native_drivers'.
> >
> > I'd go with 'disable_native_drivers', or maybe 'disable_device_handover=
'
>
> That works for me and "drm.disable_native_drivers" is also what Neal mean=
t
> with his "drm.noplatformdrv", but yours is much easier to remember / type=
.
>

I'm good with that too. :)

--=20
=E7=9C=9F=E5=AE=9F=E3=81=AF=E3=81=84=E3=81=A4=E3=82=82=E4=B8=80=E3=81=A4=EF=
=BC=81/ Always, there's only one truth!